Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2014-03-06 Thread yash ladia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/ --- (Updated March 6, 2014, 10:57 p.m.) Review request for Amarok. Changes

Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2014-03-06 Thread yash ladia
> On March 6, 2014, 10:04 p.m., Myriam Schweingruber wrote: > > Are you sure that function is correct? There is a huge different between > > changing metadata for a track and actually changing the track The earlier code (_trackDataChanged) updated the lyrics (name, text and position of scr

Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2014-03-06 Thread yash ladia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/ --- (Updated March 6, 2014, 10:52 p.m.) Review request for Amarok. Changes

Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2014-03-06 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/#review52306 --- Are you sure that function is correct? There is a huge differe

Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2014-03-06 Thread yash ladia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/ --- Review request for Amarok. Bugs: 302299 https://bugs.kde.org/show_bug

GSoC *draft* Proposal for "Lyric Support Improvements"

2014-03-06 Thread vedant agarwala
Hello everyone, I am applying to GSoC 2014 for the idea "Lyric Support Improvements". I am appending my draft proposal. The proposal isn't complete; only the scrolling lyrics part is written while the lyrics fetching is left. Please review and tell me where something is ambiguous or incorrect. I h