Re: Review Request 111449: Week 3: Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111449/ --- (Updated Oct. 23, 2013, 12:38 a.m.) Status -- This change has been di

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/ --- (Updated Oct. 23, 2013, 12:38 a.m.) Status -- This change has been di

Re: Review Request 111212: Kill long running scripts

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/ --- (Updated Oct. 23, 2013, 12:39 a.m.) Status -- This change has been di

Re: Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111552/ --- (Updated Oct. 23, 2013, 12:39 a.m.) Status -- This change has been di

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113356/ --- (Updated Oct. 23, 2013, 12:38 a.m.) Status -- This change has been di

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

2013-10-22 Thread Anmol Ahuja
> On Oct. 20, 2013, 7:06 p.m., Matěj Laitl wrote: > > Thanks for finally posting this patch, please give me a couple of days to > > review it. > > Matěj Laitl wrote: > I guess this review could be discarded because you've resubmitted it in > multiple parts? yep, I'll discard it plus some

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

2013-10-22 Thread Matěj Laitl
> On Oct. 20, 2013, 3:36 p.m., Matěj Laitl wrote: > > Thanks for finally posting this patch, please give me a couple of days to > > review it. I guess this review could be discarded because you've resubmitted it in multiple parts? - Matěj ---

Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113384/ --- Review request for Amarok. Repository: amarok Description --- The s

Review Request 113387: GSoC 2013 Revamping Scripting - Part 4/6 : Script Console

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113387/ --- Review request for Amarok. Repository: amarok Description --- The n

Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113390/ --- Review request for Amarok. Repository: amarok Description --- Misce

Review Request 113386: GSoC 2013 Revamping Scripting - Part 3/6 : Scripts

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113386/ --- Review request for Amarok. Repository: amarok Description --- Chang

Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113385/ --- Review request for Amarok. Repository: amarok Description --- Chang

Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

2013-10-22 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389/ --- Review request for Amarok. Repository: amarok Description --- Chang

Jenkins build became unstable: amarok_master #669

2013-10-22 Thread KDE CI System
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

2013-10-22 Thread Jai Luthra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113346/ --- (Updated Oct. 22, 2013, 10:14 a.m.) Status -- This change has been ma

Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113346/#review42155 --- This review has been submitted with commit d42e43fbd5bdcb1a75b

Re: Review Request 113057: I am trying to kill Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2013-10-22 Thread Matěj Laitl
> On Oct. 2, 2013, 7:34 p.m., Matěj Laitl wrote: > > Hi, thanks for your patch. Unfortunately, this is not the right approach. > > Instead of tracking user changes, the logic under apply button should be: > > 1. watch every state change in the applicable controls and pressing of the > > apply b