Re: Tagguessing: SoK project proposal

Hello Vedant, For the LastFmFingerprintProvider we will first have to generate a “fingerprint” of the track using the Last Fm Fingerprinter. did you look at this Fingerprinter? If yes, you must know that it needs a FingerprintableSource, which atm are only sources for individual codec types

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 3:48 p.m., Matěj Laitl wrote: > > > > Myriam Schweingruber wrote: > I am just wondering: since Amarok doesn't play APE tracks anyway, why > bother? AFAIK there is no phonon backend currently that provides the MAC > codec, and ape files shouldn't even show up in the col

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

> On Sept. 18, 2013, 9:46 p.m., Alex Merry wrote: > > I'm torn between following Amarok's internals (which you do) and following > > MPRIS2, meaning it should be called UserRating and return/allow a double > > between 0.0 and 1.0. > > > > There's also the question of how urgent this is, as the

Tagguessing: SoK project proposal

Hello everyone, Below is the outline for my "Improving and Modularizing tag guessing" Season of KDE project: Implementation Details: Creating a generic framework for tag getters: I will replace the existing musicbrainz directory by a taggetter directory. It will contain Controller and Provider c

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

> On Sept. 20, 2013, 11:33 a.m., Matěj Laitl wrote: > > src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml, lines 21-23 > > > > > > Hmm, I must say I don't like having a rating property for a "player" > >

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > > > Myriam Schweingruber wrote: > I am just wondering: since Amarok doesn't play APE tracks anyway, why > bother? AFAIK there is no phonon backend currently that provides the MAC > codec, and ape files shouldn't even show up in the col

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, line 67 > > > > > > Shouldn't that be toBool() > > isCompilation is AFAIK a boolean value. > > Bruno Léon wrote: >

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > > > Myriam Schweingruber wrote: > I am just wondering: since Amarok doesn't play APE tracks anyway, why > bother? AFAIK there is no phonon backend currently that provides the MAC > codec, and ape files shouldn't even show up in the col

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 3:48 p.m., Matěj Laitl wrote: > > I am just wondering: since Amarok doesn't play APE tracks anyway, why bother? AFAIK there is no phonon backend currently that provides the MAC codec, and ape files shouldn't even show up in the collection folder, as neither the vlc nor gs

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 3:48 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, line 67 > > > > > > Shouldn't that be toBool() > > isCompilation is AFAIK a boolean value. > > Bruno Léon wrote: >

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

> On Sept. 19, 2013, 1:48 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, line 67 > > > > > > Shouldn't that be toBool() > > isCompilation is AFAIK a boolean value. That makes sense to me but