Re: Review Request 110426: KWalletHelper class for services using the KWallet

2013-08-26 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review38695 --- src/services/KWalletHelper.h

Re: Review Request 110426: KWalletHelper class for services using the KWallet

2013-08-26 Thread Stefan Derkits
> On Aug. 26, 2013, 7:07 p.m., Vedant Agarwala wrote: > > Fixed the problems and incorporated Matej's patch. > > > > Builds, passes tests and runs now. I didn't test it fully. I ran Amarok > > with this patch and at Amarok start-up I got the KWallet Dialog for Amarok > > ("Do you want to allow

Re: Review Request 110426: KWalletHelper class for services using the KWallet

2013-08-26 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review38691 --- Fixed the problems and incorporated Matej's patch. Builds, pas

Re: Review Request 110426: KWalletHelper class for services using the KWallet

2013-08-26 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/ --- (Updated Aug. 26, 2013, 7:03 p.m.) Review request for Amarok. Descriptio

Re: Review Request 110426: KWalletHelper class for services using the KWallet

2013-08-26 Thread Vedant Agarwala
> On Aug. 25, 2013, 8:47 a.m., Mark Kretschmann wrote: > > Any news for this patch? I am working on it. Likely to be done in a couple of days - Vedant --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboar

Re: Review Request 112263: EBN: Check for foreach loop issues.

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/ --- (Updated Aug. 26, 2013, 10:11 a.m.) Status -- This change has been ma

Re: Review Request 112263: EBN: Check for foreach loop issues.

2013-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/#review38604 --- This review has been submitted with commit 552a100adaffdb6352e