Re: Review Request 112023: Disable move/copy actions for non-writeable UMS collections.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112023/ --- (Updated Aug. 25, 2013, 9:09 p.m.) Review request for Amarok. Changes --

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 2:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of b

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38527 --- Thanks for the patch. Please answer some remarks below. share

Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/ --- Review request for Amarok. Description --- Fix reading of Album Artis

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

> On Aug. 25, 2013, 2:19 p.m., Mark Kretschmann wrote: > > What's the current status of this patch? > > Matěj Laitl wrote: > Well, the question is whether we want such big complication of code for > little gain. I fear that not, at not least in the current for of the patch. > I'd be also a

Review Request 112263: EBN: Check for foreach loop issues.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/ --- Review request for Amarok. Description --- More janitor work. EBN: C

Re: Review Request 112248: 313504: prefer QLatin1String

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112248/ --- (Updated Aug. 25, 2013, 10:29 a.m.) Status -- This change has been di

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

> On Aug. 25, 2013, 8:49 a.m., Mark Kretschmann wrote: > > What's the current status of this patch? > > Matěj Laitl wrote: > Well, the question is whether we want such big complication of code for > little gain. I fear that not, at not least in the current for of the patch. > I'd be also a

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

> On Aug. 25, 2013, 10:49 a.m., Mark Kretschmann wrote: > > What's the current status of this patch? Well, the question is whether we want such big complication of code for little gain. I fear that not, at not least in the current for of the patch. I'd be also against adding another duplicate

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

> On Aug. 25, 2013, 10:47 a.m., Mark Kretschmann wrote: > > Does anyone here have an actual iDevice for testing this? I'll handle the patch incl. testing, but I'm unfortunately rather time-constrained now, so in the worst case it'll have to wait till the second half of September. Sorry about t

Re: Review Request 112255: UMS: Fix set album cover

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112255/#review38516 --- This review has been submitted with commit c62665ccbd053d83d4f

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109369/#review38520 --- What's the current status of this patch? - Mark Kretschmann

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111824/#review38519 --- Does anyone here have an actual iDevice for testing this? - Ma

Re: Review Request 110426: KWalletHelper class for services using the KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review38518 --- Any news for this patch? - Mark Kretschmann On May 20, 2013,

Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112221/ --- (Updated Aug. 25, 2013, 8:45 a.m.) Status -- This change has been mar

Re: Review Request 112199: 313504: Check for foreach loop issues

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112199/ --- (Updated Aug. 25, 2013, 8:40 a.m.) Status -- This change has been mar

Re: Review Request 112199: 313504: Check for foreach loop issues

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112199/#review38515 --- This review has been submitted with commit 01a4ce741420f76c794

Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112221/#review38517 --- This review has been submitted with commit 61350cc9e95ba228f7e

Re: Review Request 112169: Stop after current track to tray menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112169/#review38514 --- I can't say that I am 100% happy with this addition. It does ad

Re: Review Request 112248: 313504: prefer QLatin1String

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112248/#review38513 --- Sorry, I am against this one because I think it considerably de