Re: ToolTips and Automatic Formatting

2013-08-17 Thread Yuri Chornoivan
п'ятниця, 16-сер-2013 10:44:45 Mark Kretschmann написано: > Heya, > > as we noticed recently, many of Amarok's ToolTips look very ugly and > have readability issues because they are not formatted. Therefore a > longer ToolTip is being rendered as one giant long line. The Qt API > offers automatic

Review Request 112141: Bug 313504: Check validity of i18n calls

2013-08-17 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112141/ --- Review request for Amarok. Description --- Check validity of i18n cal

Review Request 112140: Bug 313504: style: prefer QString::isEmpty() over a "null compare"

2013-08-17 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112140/ --- Review request for Amarok. Description --- style: prefer QString::isE

Review Request 112139: Bug 313504: style: prefer QString.clear over a null-assign

2013-08-17 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112139/ --- Review request for Amarok. Description --- style: prefer QString.clea

Re: git HEAD compile error

2013-08-17 Thread Mathias Panzenböck
On 08/17/2013 09:37 AM, Mark Kretschmann wrote: On Fri, Aug 16, 2013 at 9:03 PM, Mark Kretschmann wrote: On Fri, Aug 16, 2013 at 6:19 PM, Mathias Panzenböck wrote: Current HEAD (141c1191f8849cfa91e8684edd11ab5b726ef101) gives me this compile error: Linking CXX shared module ../../../../lib/a

Fwd: [amarok] [Bug 322457] Append & Play doesn't work

2013-08-17 Thread Myriam Schweingruber
Sending that question where it belongs, not everybody reads bug reports... -- Forwarded message -- From: Matěj Laitl Date: Sat, Aug 17, 2013 at 3:43 PM Subject: [amarok] [Bug 322457] Append & Play doesn't work To: amarok-bugs-d...@kde.org https://bugs.kde.org/show_bug.cgi?id=322

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-08-17 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- (Updated Aug. 17, 2013, 4:08 p.m.) Status -- This change has been mar

Jenkins build is back to normal : amarok_master #612

2013-08-17 Thread KDE CI System
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Build failed in Jenkins: amarok_master #611

2013-08-17 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [amarok_master] $ /bin/

Re: Review Request 112023: Disable move/copy actions for non-writeable UMS collections.

2013-08-17 Thread Matěj Laitl
> On Aug. 12, 2013, 6:57 p.m., Matěj Laitl wrote: > > src/core/collections/Collection.h, lines 125-135 > > > > > > Hmm, I don't like the combination of 2 bools to signify 3 possible > > values (because you introd

Re: Review Request 112023: Disable move/copy actions for non-writeable UMS collections.

2013-08-17 Thread Frank Meerkoetter
> On Aug. 12, 2013, 4:57 p.m., Matěj Laitl wrote: > > src/core/collections/Collection.h, lines 125-135 > > > > > > Hmm, I don't like the combination of 2 bools to signify 3 possible > > values (because you introd

Re: git HEAD compile error

2013-08-17 Thread Mark Kretschmann
On Fri, Aug 16, 2013 at 9:03 PM, Mark Kretschmann wrote: > On Fri, Aug 16, 2013 at 6:19 PM, Mathias Panzenböck > wrote: >> Current HEAD (141c1191f8849cfa91e8684edd11ab5b726ef101) gives me this >> compile error: >> >> Linking CXX shared module ../../../../lib/amarok_data_engine_labels.so >> CMakeF