Re: Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Konrad Zemek
> On Aug. 10, 2013, 7:26 p.m., Mark Kretschmann wrote: > > I'm not so sure about the warning that is shown when an unwritable UMS > > collection is loaded. First of all it seems to me this would belong on a > > higher level, as other collections could be read-only as well. Second, I'm > > not

Re: Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Frank Meerkoetter
> On Aug. 10, 2013, 7:26 p.m., Mark Kretschmann wrote: > > I'm not so sure about the warning that is shown when an unwritable UMS > > collection is loaded. First of all it seems to me this would belong on a > > higher level, as other collections could be read-only as well. Second, I'm > > not

Re: Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/#review37483 --- I'm not so sure about the warning that is shown when an unwrita

Re: Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/ --- (Updated Aug. 10, 2013, 4:44 p.m.) Review request for Amarok. Changes --

Re: Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/#review37473 --- src/core-impl/collections/umscollection/UmsCollection.cpp

Review Request 111991: Better handling of non-writeable UMS collections

2013-08-10 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/ --- Review request for Amarok. Description --- If an UMS-collection is no

Jenkins build is back to normal : amarok_master #591

2013-08-10 Thread KDE CI System
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Build failed in Jenkins: amarok_master #590

2013-08-10 Thread KDE CI System
See Changes: [kretschmann] Try to fix build. -- [...truncated 4318 lines...] [ 97%] Building CXX object src/services/magnatune/CMakeFiles/amarok_service_magnatunestore.dir/MagnatuneDownloadHandler.o [ 9

Build failed in Jenkins: amarok_master #589

2013-08-10 Thread KDE CI System
See Changes: [kretschmann] Jamendo service: Use direct file download instead of BitTorrent. -- [...truncated 4097 lines...] Building CXX object src/context/applets/albums/CMakeFiles/amarok_context_apple

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-10 Thread Christoph Feck
> On July 22, 2013, 12:57 p.m., Lukáš Tinkl wrote: > > The problem is that udisks2 no longer associates drives with a block > > device, nothing we can circumvent. Does commit b92df276 ("Do not clean the cache in UDisks2 backend") work around this udisks2 issue, in other words, is this patch no