Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 1. 5. 2013 Konrad Zemek wrote: > Amarok 2.x importer should support importing data from both a full mysql > server and mysql-embedded file. To make reading from both sources simpler, > existing MySqlStorage and MySqlEmbeddedStorage classes will be used. The > importer's code should be as decoupl

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
On 01.05.2013 00:42, Matěj Laitl wrote: My bet that support code for actually using SqlCollection would be much heavier than implementing the A 2.x importer without it. Technical reasons not to use SqlCollection: 1. you'll be instantiating the beast just to use 2% of its functionality. SqlColl

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 1. 5. 2013 Konrad Zemek wrote: > Matěj Laitl wrote: > > Kondad wrote: > > > To ensure that metadata from current version of Amarok can always be > > > synchronized, Collections::SqlCollection class will be used > > > > I don't think this is a good idea at all. It is like using a cannon to > > s

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
On 30.04.2013 23:12, Matěj Laitl wrote: On 30. 4. 2013 Konrad Zemek wrote: Amarok 2.x importer should support importing data from both a full mysql server and mysql-embedded file. To ensure that metadata from current version of Amarok can always be synchronized, Collections::SqlCollection class

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 30. 4. 2013 Konrad Zemek wrote: > Amarok 2.x importer should support importing data from both a full mysql > server and mysql-embedded file. To ensure that metadata from current > version of Amarok can always be synchronized, Collections::SqlCollection > class will be used I don't think this is

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
Thank you for your tireless work! I outlined the changes below. I'm not posting the whole proposal this time since only two points were added in the text. On 29.04.2013 23:12, Matěj Laitl wrote Some more things to iron out about StatSyncing::Amarok2Provider: * would you support both a) conne

Re: GSoC proposal draft: Audio СD collection refactoring.

2013-04-30 Thread Matěj Laitl
On 30. 4. 2013 Tatjana Gornak wrote: > Hi all, > > I am looking forward to get some feedback on my proposal. Thanks in advance. Glad to see your proposal. Sorry for complications caused by me not publicly communicating my MTP intents early enough. > ==Motivation and Goals== > Current implementa

Re: GSoC Application Review

2013-04-30 Thread Anmol Ahuja
It wasn't supposed to be private, that was accidental. Resending it to the amarok-devel mailing list. Thanks for the thorough review :) On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > On 30. 4. 2013 Anmol Ahuja wrote: > > And for classes like CollectionLocation, should I create wrappers

Fwd: GSoC proposal review

2013-04-30 Thread Abhinandan Ramprasath
Thank you for reviewing my proposal. It has been really helpful. On Tue, Apr 30, 2013 at 5:44 PM, Matěj Laitl wrote: > On 28. 4. 2013 Abhinandan Ramprasath wrote: > > I hope I'm not too late with this. > > Not strictly late, but we cannot reply within hours, so you may have little > time to pro

Re: GSoC draft application

2013-04-30 Thread vedant agarwala
Matej, Thank-you once again for your comments. I have drastically changed my proposal based on it. I didn't want you to read my entire application again so I just comment on some things that I have changed but I'm not so confident about. Regards, Vedant On Tue, Apr 30, 2013 at 2:11 AM, Matěj Lait

Re: GSOC proposal critical feedback

2013-04-30 Thread Matěj Laitl
On 29. 4. 2013 HARDIK Dhimmar wrote: > *Proposal for Google Summer of Code - 2013 to KDE community (Amarok)* > *Proposal Title:* > *Unified CUE File and Audiobook support in Amarok.*** > > *Brief Description:* > > Amarok is a music player which has a very > use

Re: GSoC proposal review

2013-04-30 Thread Matěj Laitl
On 28. 4. 2013 Abhinandan Ramprasath wrote: > I hope I'm not too late with this. Not strictly late, but we cannot reply within hours, so you may have little time to process the feedback. > Also, I don't have many bug fixes to show for, I can see my chances of > getting in are greatly hindered by