Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 22, 2013, 12:28 p.m.) Review request for Amarok. Descript

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 22, 2013, 12:27 a.m.) Review request for Amarok. Descript

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 22, 2013, 12:02 a.m.) Review request for Amarok. Descript

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 21, 2013, 11:45 p.m.) Review request for Amarok. Descript

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
> On April 21, 2013, 9:02 p.m., Matěj Laitl wrote: > > src/transcoding/TranscodingSelectConfigWidget.h, line 62 > > > > > > I don't think you set this value anywhere anymore. (there's a switch > > case for it, but

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
> On April 21, 2013, 9:02 p.m., Matěj Laitl wrote: > > src/transcoding/TranscodingSelectConfigWidget.h, line 62 > > > > > > I don't think you set this value anywhere anymore. (there's a switch > > case for it, but

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Matěj Laitl
> On April 21, 2013, 3:32 p.m., Matěj Laitl wrote: > > src/transcoding/TranscodingSelectConfigWidget.h, line 62 > > > > > > I don't think you set this value anywhere anymore. (there's a switch > > case for it, but

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Anmol Ahuja
> On April 21, 2013, 9:02 p.m., Matěj Laitl wrote: > > src/transcoding/TranscodingSelectConfigWidget.h, line 62 > > > > > > I don't think you set this value anywhere anymore. (there's a switch > > case for it, but

Re: Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method

2013-04-21 Thread Matěj Laitl
> On April 21, 2013, 12:05 a.m., Matěj Laitl wrote: > > src/core/playlists/Playlist.h, line 143 > > > > > > I think you've also forgot to remove some description() implementations > > under podcasts. > > > >

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-21 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/#review31374 --- Thanks, this starts to look really well, although see below for

Re: Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method

2013-04-21 Thread Vedant Agarwala
> On April 21, 2013, 12:05 a.m., Matěj Laitl wrote: > > src/core/playlists/Playlist.h, line 143 > > > > > > I think you've also forgot to remove some description() implementations > > under podcasts. > > > >

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-21 Thread Matěj Laitl
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote: > > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 251-253 > > > > > > Should be that easy (if this is *the* thing on your TODO list): > > > > beginIns

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-21 Thread Alberto Villa
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote: > > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 251-253 > > > > > > Should be that easy (if this is *the* thing on your TODO list): > > > > beginIns