[KDE Bugtracking System] REMINDER: current Amarok regressions

2013-04-19 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions -- Bug 231187: https://bugs.kde.org/show_bug.cgi?id=231187 Priority: NOR Severity: normal Platform: unspecified Assignee: amarok-bugs

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-19 Thread Alberto Villa
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote: > > src/dialogs/MusicBrainzTagger.cpp, line 92 > > > > > > I'd also add: > > "...for each undecided Track. Alternatively, you can click on Select > > Best Ma

Re: Regarding GSOC project

2013-04-19 Thread Myriam Schweingruber
On Fri, Apr 19, 2013 at 10:16 PM, Abhay Sombanshi wrote: > Hello ma'am, > > I have read the documentation that you provided me in your previous mail.It > was really a great help as I've understood the basic functioning of the > classes from the documentation provided. > > Is there any way that I c

Re: 2 New Amarok GSoC Ideas Added, Take a Look!

2013-04-19 Thread HARDIK DHIMMAR
I am GSOC enthusiastic person and want to contribute to open source. I want to directly come to the point: First: Presently amarok is not supporting bollywood lyrics. I have studied the source code and found that it loads the English songs lyrics from http://lyrics.wikia.com/ dynamically using jav

Re: Regarding GSOC project

2013-04-19 Thread Abhay Sombanshi
Hello ma'am, I have read the documentation that you provided me in your previous mail.It was really a great help as I've understood the basic functioning of the classes from the documentation provided. Is there any way that I can see in terminal which functions are being executed when i click a b

Jenkins build became unstable: amarok_master #346

2013-04-19 Thread KDE CI System
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/ --- (Updated April 19, 2013, 3:30 p.m.) Status -- This change has been ma

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/#review31295 --- This review has been submitted with commit 0b1391318ae98c5f077

Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

2013-04-19 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110070/ --- (Updated April 19, 2013, 3:13 p.m.) Review request for Amarok. Changes -

Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

2013-04-19 Thread Konrad Zemek
> On April 19, 2013, 11:28 a.m., Matěj Laitl wrote: > > src/playlist/proxymodels/SortScheme.h, line 66 > > > > > > I think some compilers choke on "implicit template argument" like this, > > safer way would be: ty

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-19 Thread Anmol Ahuja
> On April 19, 2013, 4:26 p.m., Matěj Laitl wrote: > > src/playlist/PlaylistModel.cpp, lines 255-257 > > > > > > If this makes the tooltip too wide, perhaps the \n can be replaced by > > to actually force the ne

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-19 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/ --- (Updated April 19, 2013, 6:12 p.m.) Review request for Amarok. Descripti

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-19 Thread Matěj Laitl
> On April 14, 2013, 2:53 p.m., Matěj Laitl wrote: > > Good direction, although please see suggestions below to make the patch > > perfect. Also please adapt Transcoding::SelectConfigWidget::fillInChoices() > > to cope with new Transcoding::Configuration::prettyName() semantics and to > > show

Re: Review Request 110081: Launching amarok with --cdplay adds CD in playlist

2013-04-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110081/#review31281 --- Thanks for fixing this annoying bug. You've however opened a ca

Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

2013-04-19 Thread Matěj Laitl
> On April 18, 2013, 12:30 p.m., Matěj Laitl wrote: > > Thanks for the investigation and the patch, it looks very good and contains > > very welcome cleanups. Also kudos for including & cleaning up the test > > case. As I'm not really proficient in this part of Amarok code, let's give > > othe

Re: Review Request 110070: Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

2013-04-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110070/#review31279 --- Ship it! This looks even better, I think I'll just merge it on

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109817/#review31274 --- This looks very well, thanks. In the mean time I got more ideas

Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists

2013-04-19 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110082/ --- Review request for Amarok. Description --- As agreed on the review fo

Please help me with reviewing patches!

2013-04-19 Thread Matěj Laitl
Hi fellow devs, it is nice that you want to participate in the decision-making process (and some of you in a vocal way), have you also considered participating in the actual development process? :-) Our reviewboard is overwhelmed with patches desiring your attention, and I start to feel rather

Re: Review Request 109781: Bug #312407 - don't transcode from mp3 to mp3

2013-04-19 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- (Updated April 19, 2013, 1:47 p.m.) Review request for Amarok. Changes -