Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

2013-03-05 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109224/#review28647 --- Please don't apply this patch. Here's why: Amarok is really no

Re: Review Request 107473: Changes in processing playlist files

2013-03-05 Thread Tatjana Gornak
> On March 5, 2013, 12:11 a.m., Matěj Laitl wrote: > > Tatjana, thanks for your continued effort on this review. :-) There seem to > > be a couple of problematic places that may cause regressions, please take a > > look at them so this can be merged. (which I hope can be done rather soon, > >

Re: Review Request 107473: Changes in processing playlist files

2013-03-05 Thread Tatjana Gornak
> On March 5, 2013, 12:11 a.m., Matěj Laitl wrote: > > src/playlist/PlaylistRestorer.h, line 56 > > > > > > Class-wise this is redundant with m_tracks and should be avoided. Just > > create local iterator in proce

Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

2013-03-05 Thread Vedant Agarwala
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109283/ --- (Updated March 5, 2013, 7:12 p.m.) Review request for Amarok. Changes --

Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

2013-03-05 Thread Matěj Laitl
> On March 5, 2013, 12:48 p.m., Matěj Laitl wrote: > > src/services/lastfm/LastFmServiceSettings.cpp, lines 255-256 > > > > > > I think this will duplicate the label in case it is already in the > > combo box. (b

Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

2013-03-05 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109224/ --- (Updated March 5, 2013, 5:02 p.m.) Review request for Amarok. Changes --

Re: Review Request 109224: Patch for bug 315932 in Amarok. Resolving the window not coming up on launching the second time in Amarok.

2013-03-05 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109224/#review28595 --- I think this breaks "Click on mp3 file in Dolphin to have it op

Re: Review Request 109162: Fix: double click item to add to playlist in double click mode

2013-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109162/#review28593 --- This review has been submitted with commit 40b1e87cad749a80609

Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

2013-03-05 Thread Vedant Agarwala
> On March 5, 2013, 12:48 p.m., Matěj Laitl wrote: > > src/services/lastfm/LastFmServiceSettings.cpp, lines 255-256 > > > > > > I think this will duplicate the label in case it is already in the > > combo box. (b

Re: Review Request 108907: Added transcoding for opus format

2013-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/#review28590 --- This review has been submitted with commit 18c75c41c267fe81174

Re: Review Request 103999: Extend the scope of the playground

2013-03-05 Thread Matěj Laitl
> On Sept. 5, 2012, 6:19 a.m., Bart Cerneels wrote: > > I would like to see the code you are working on that has a need for this > > change. I still think that it should go directly in core. Ryan, we are very sorry for any wasted efforts that could have been caused by past Amarok developers te

Re: Review Request 108907: Added transcoding for opus format

2013-03-05 Thread Martin Brodbeck
> On Feb. 26, 2013, 12:50 p.m., Martin Brodbeck wrote: > > Ship It! > > Matěj Laitl wrote: > > Stupid me, there's never a faultless patch from me. :-/ > > No faultless patch was ever posted to reviewboard, at least not when I'm > the reviewer. :-) And these were just nitpicks. >

Re: Review Request 109283: Bug 140198 - JJ: feature request: option to selectively disable submitting certain tracks/albums from collection to last.fm

2013-03-05 Thread Matěj Laitl
> On March 5, 2013, 1:41 a.m., Dan Meltzer wrote: > > Hi. All sorts of things going on here. My biggest question is that it > > seems as if you are designing this to only allow one label to be set as the > > "banned" label. Why not a list of labels? Also, keep your patch on topic. > > For