Review Request 109162: Fix: double click item to add to playlist in double click mode

2013-02-25 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109162/ --- Review request for Amarok, Matěj Laitl and Ralf Engels. Description --

Re: Review Request 109156: Be consistent with width range of playlist layout setting.

2013-02-25 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109156/ --- (Updated Feb. 25, 2013, 11:12 p.m.) Review request for Amarok. Descripti

Re: Review Request 108907: Added transcoding for opus format

2013-02-25 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- (Updated Feb. 26, 2013, 8:08 a.m.) Review request for Amarok and Matěj Lai

Re: Review Request 109157: Amarok buildsystem cleanup preview

2013-02-25 Thread Matěj Laitl
> On Feb. 25, 2013, 9:48 p.m., Edward Hades Toroshchin wrote: > > Why do you want the intermediate libs at all? > > Matěj Laitl wrote: > In general, all points mentioned in > http://www.cmake.org/Wiki/CMake/Tutorials/Object_Library#Motivation hold > here, especially "This approach is easy

Re: Review Request 109157: Amarok buildsystem cleanup preview

2013-02-25 Thread Matěj Laitl
> On Feb. 25, 2013, 9:48 p.m., Edward Hades Toroshchin wrote: > > Why do you want the intermediate libs at all? In general, all points mentioned in http://www.cmake.org/Wiki/CMake/Tutorials/Object_Library#Motivation hold here, especially "This approach is easy to use and helps organize the pro

Review Request 109156: Be consistent with width range of playlist layout setting.

2013-02-25 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109156/ --- Review request for Amarok. Description --- 1. Always make minimum wid

Re: Review Request 108907: Added transcoding for opus format

2013-02-25 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/#review28082 --- Ship it! Looks good to me, thanks! If you want to help even m

Re: Review Request 109157: Amarok buildsystem cleanup preview

2013-02-25 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109157/#review28081 --- Why do you want the intermediate libs at all? - Edward Hades T

Re: Review Request 109156: Be consistent with width range of playlist layout setting.

2013-02-25 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109156/#review28079 --- Hi, thanks for the patch. While we think about the actual chang

Review Request 109157: Amarok buildsystem cleanup preview

2013-02-25 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109157/ --- Review request for Amarok and Build System. Description --- Hi fellow