Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

2013-02-19 Thread Darth Codus
Thanks :) I'll get to the documentation in a short while. But aren't conflicting default shortcuts bad user experience? On Feb 20, 2013 3:21 AM, "Matěj Laitl" wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108964/ > > Ship it! > > Looks

Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

2013-02-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/#review27752 --- Ship it! Looks good to me, will merge in a few moments. Anmol,

Can we stop using MusicBrainz id as track uniqueid (was: [Bug 315329])

2013-02-19 Thread Matěj Laitl
Hi, it has been brought to my attention on https://bugs.kde.org/show_bug.cgi?id=315329 that MusicBrainz changed semantics of the "MusicBrainz id" stored in various meta tags in a way that we IMO cannot use it as track unique identifier any longer. In short, the "MusicBrainz id" is now a recordi

Support for Chapters in m4b files

2013-02-19 Thread Abhinandan Ramprasath
This is regarding the bug: https://bugs.kde.org/show_bug.cgi?id=240409 The file attached decodes m4b files and displays the chapter markers and the time. To compile it please install the "libmp4v2-dev" package ( add option -lmp4v2 while compiling ). For this to work I need the file path and file n

Re: Review Request 109040: Support for loading asx playlists.

2013-02-19 Thread Joel Mandell
Okay, anyways I added the "complete" first patch-file now ... 2013/2/19 Joel Mandell >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109040/ > Review request for Amarok. > By Joel Mandell. > > *Updated Feb. 19, 2013, 1:56 p.m.* > Description

Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

2013-02-19 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/ --- (Updated Feb. 19, 2013, 3:37 p.m.) Review request for Amarok. Changes --

Re: Review Request 109040: Support for loading asx playlists.

2013-02-19 Thread Joel Mandell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109040/ --- (Updated Feb. 19, 2013, 1:56 p.m.) Review request for Amarok. Descriptio

Re: Review Request 107473: Changes in processing playlist files

2013-02-19 Thread Matěj Laitl
> On Feb. 9, 2013, 12:55 a.m., Matěj Laitl wrote: > > src/core-impl/playlists/types/file/PlaylistFile.h, lines 71-73 > > > > > > What is the difference between save() and savePlaylist()? Also, if we > > don't allo

[amarok] playground/src/context: Remove unused playground applets and engines: cloud, jssample, jsengine, lastfmevents, scriptedsample, video, wiki

2013-02-19 Thread Matěj Laitl
Git commit 29ce6d1461e9f49d70c06c72f6fa93da1c72ba14 by Matěj Laitl. Committed on 19/02/2013 at 12:40. Pushed by laitl into branch 'master'. Remove unused playground applets and engines: cloud, jssample, jsengine, lastfmevents, scriptedsample, video, wiki These weren't built even with WITH_PLAYGR

Re: Review Request 109040: Support for loading asx playlists.

2013-02-19 Thread Matěj Laitl
> On Feb. 19, 2013, noon, Edward Hades Toroshchin wrote: > > Thanks for the patch. > > > > Unfortunately we won't be able to accept it, because someone else is > > already working on ASX playlist as well as on general playlist code cleanup. > > > > In the future, please ask us before you do an

Re: Review Request 109040: Support for loading asx playlists.

2013-02-19 Thread Joel Mandell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109040/ --- (Updated Feb. 19, 2013, 11:37 a.m.) Review request for Amarok. Descripti

Re: Amarok build error

2013-02-19 Thread vedant agarwala
Thanks. I'm able to build amarok by the guide provided with amarok itself and your bolg is similar to it so I'm sure it will work too :) I guess I shouldn't waste much time on my question: which missing dependency is causing that error. I ran cmake but according to it I had all the dependencies in

Re: Amarok build error

2013-02-19 Thread Myriam Schweingruber
On Tue, Feb 19, 2013 at 10:07 AM, vedant agarwala wrote: > Hello. > How to fix the following error while building amarok: > > > Linking CXX shared module > ../../../../../../lib/amarok_collection-mysqlecollection.so > /usr/bin/ld: cannot find -lmysqld Isn't that obvious? You apparently don't have

Amarok build error

2013-02-19 Thread vedant agarwala
Hello. How to fix the following error while building amarok: Linking CXX shared module ../../../../../../lib/amarok_collection-mysqlecollection.so /usr/bin/ld: cannot find -lmysqld Thanks, Vedant ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Review Request 108907: Added transcoding for opus format

2013-02-19 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- (Updated Feb. 19, 2013, 10:11 a.m.) Review request for Amarok and Matěj La

Re: Review Request 108907: Added transcoding for opus format

2013-02-19 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- (Updated Feb. 19, 2013, 9:18 a.m.) Review request for Amarok and Matěj Lai

Re: Review Request 108907: Added transcoding for opus format

2013-02-19 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- (Updated Feb. 19, 2013, 9:01 a.m.) Review request for Amarok and Matěj Lai