Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-17 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated Feb. 18, 2013, 11:38 a.m.) Review request for Amarok. Descripti

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-02-17 Thread Matěj Laitl
> On Nov. 8, 2012, 12:02 p.m., Matěj Laitl wrote: > > Hi Alberto, > > any news on this? I'd like to merge this when last changes are made for > > 2.7; don't hesitate to tell me that I've put too much work on your back, > > we'll be certainly able to handle that case. Still no updates, Alberto?

Re: Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

2013-02-17 Thread Matěj Laitl
> On Feb. 12, 2013, 2:49 p.m., Matěj Laitl wrote: > > I don't think creating a custom subclass is the right way to implement drag > > & drop support. The right way should be implementing QAbstractItemModel for > > the queue (with drag&drop methods) and then the GUI would automatically > > supp

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Wyatt Epp
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Edward Hades Toroshchin
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-17 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- Review request for Amarok. Description --- 1. Disabled Pre-amplifier

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Matěj Laitl
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Fwd: Another bug in equalizer

2013-02-17 Thread Ralf Engels
Thanks for noticing the error. I think the following patch should fix the problem: http://commits.kde.org/amarok/aef8f57124c39ad8df46e92333175ea7a850e7f4 We also have a bug tracker that we are usually using for this kind of request. Cheers, Ralf Am Sonntag, 17. Februar 2013, 12:11:27 schrieb

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Ralf Engels
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Bart Cerneels
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Matěj Laitl
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-17 Thread Bart Cerneels
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Fwd: Another bug in equalizer

2013-02-17 Thread Matěj Laitl
Hi Harsh, overlooks happen, such e-mails are best sent directly to amarok-devel with CC to patch author. Ralf, can you have a look at it? Matěj -- Forwarded Message -- Sir, The default value entry of 'manual' preset was deleted in a patch submitted on 2012-01-22 by Ral