Re: Review Request 100321: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

2013-02-09 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100321/#review27100 --- Ralf, do you want to incorporate some of the suggestions into t

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
> On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlayli

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
> On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlayli

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
> On Feb. 9, 2013, 5:36 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlaylis

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 2:21 a.m.) Review request for Amarok. Changes --

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27059 --- The patch looks good now, just some last trivial things. (sorry