Re: Review Request: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review24408 --- src/core-impl/playlists/types/file/PlaylistFile.h

Re: Review Request: Changes in processing playlist files

> On Nov. 27, 2012, 8:08 a.m., Bart Cerneels wrote: > > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp, line 218 > > > > > > Here is the real reason why lazy loading is needed. Reading > > playlist-file c

Re: Review Request: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review24407 --- Looks like I still had some unpublished comment from the last v

Re: Review Request: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review24399 --- Hi, thanks for the updated revision! As this is a bigger one, p

Re: Review Request: Fix one small memoy leak when switch track in amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108050/#review24397 --- This review has been submitted with commit d9904f05ce8b8a634f9

Re: Review Request: Fix one small memoy leak when switch track in amarok

> On Jan. 1, 2013, 7:48 p.m., Bart Cerneels wrote: > > I don't know what that code is supposed to do, but if it's executed on each > > track change it likely is a real leak. Test if it doesn't cause dangling > > pointer crashes and ship it. It doesn't cause dangling pointers and fixes a real l

Re: Review Request: Fix one small memoy leak when switch track in amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108050/#review24379 --- Ship it! I don't know what that code is supposed to do, but if