Tomahawk Integration Status

Hi everyone, as the only GSoC project that isn't yet fully finished, I believe that I owe you an explanation about its current status. I had worked a lot in it this weekend and got several things done. To begin with, Libtomahawk often slows down my plans with some unexpected but necessary last-mi

Re: Review Request: Statistics Synchronization: final review request

> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote: > > src/statsyncing/collection/CollectionProvider.cpp, lines 126-132 > > > > > > I think this should be implemented in QueryMaker as a blocking API > >

Re: Review Request: Statistics Synchronization: final review request

> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote: > > src/services/lastfm/SynchronizationAdapter.cpp, lines 38-43 > > > > > > This should be Qt::AutoConnection. Otherwise it will deadlock if > > artists(

Re: Review Request: Statistics Synchronization: final review request

> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote: > > Haven't run it yet, but at least it compiles okay :) > > Matěj Laitl wrote: > Thanks for the attentive review, I didn't expect somebody to dive that > deep and I'm grateful. So, what's your "ready to be merged" opinion on th

Re: Review Request: Statistics Synchronization: final review request

> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote: > > src/services/lastfm/SynchronizationAdapter.cpp, lines 38-43 > > > > > > This should be Qt::AutoConnection. Otherwise it will deadlock if > > artists(

Re: Review Request: Statistics Synchronization: final review request

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107348/ --- (Updated Nov. 18, 2012, 5:12 p.m.) Review request for Amarok and Myriam Sc