Re: Review Request: WIP - Dedicated equalizer controller

2012-09-20 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106511/ --- (Updated Sept. 21, 2012, 12:45 a.m.) Review request for Amarok. Changes

Re: Review Request: WIP - Dedicated equalizer controller

2012-09-20 Thread Ryan McCoskrie
> On Sept. 20, 2012, 3:21 p.m., Matěj Laitl wrote: > > src/EqualizerController.h, lines 37-44 > > > > > > All methods lack documentation, which is unacceptable for a component. > > > > From the names it seem

Re: Review Request: WIP - Dedicated equalizer controller

2012-09-20 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106511/ --- (Updated Sept. 20, 2012, 11:24 p.m.) Review request for Amarok. Changes

Re: Review Request: WIP - Dedicated equalizer controller

2012-09-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106511/#review19224 --- I tend to like the general idea of moving the publicly-availabl