Re: Review Request: Track statistics refactor (intended to be merged ASAP)

2012-09-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106494/ --- (Updated Sept. 18, 2012, 5:08 p.m.) Review request for Amarok, Bart Cernee

Re: Review Request: Track statistics refactor (intended to be merged ASAP)

2012-09-18 Thread Matěj Laitl
> On Sept. 18, 2012, 4:13 p.m., Ralf Engels wrote: > > As already noted: Similar to a version that I already proposed. > > > > Improvement for later: > > - Think about statistics: Do two tracks that represent the same track (e.g. > > same tags) have the same statistics object? Do we have a 1:1

Re: Review Request: Use multiple inheritance to get an implementation for statistics handling

2012-09-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106276/#review19114 --- My answer to this is https://git.reviewboard.kde.org/r/106494/

Re: Review Request: Track statistics refactor (intended to be merged ASAP)

2012-09-18 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106494/#review19113 --- Ship it! As already noted: Similar to a version that I already

Review Request: Track statistics refactor (intended to be merged ASAP)

2012-09-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106494/ --- Review request for Amarok, Bart Cerneels and Ralf Engels. Description