Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-15 Thread Phalgun Guduthur
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 15, 2012, 6:55 p.m.) Review request for Amarok, Vishesh Hand

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-15 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/#review17460 --- First round of my review, I haven't peek actual Nepomuk classes

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-15 Thread Phalgun Guduthur
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 15, 2012, 4:39 p.m.) Review request for Amarok, Vishesh Hand

Re: Review Request: GSoC : Nepomuk plugin for Amarok

2012-08-15 Thread Phalgun Guduthur
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 15, 2012, 4:38 p.m.) Review request for Amarok, Edward Hades

Re: [Tomahawk Integration] GSoC Final Report

2012-08-15 Thread Teo Mrnjavac
On Wed, Aug 15, 2012 at 4:54 AM, Lucas Lira Gomes wrote: > Hi folks, > > for the general happiness, herein I announce that the playlist > synchronisation is working perfectly in both directions. Also, I solved some > problems with the track resolution process of the MetaProxy class. So, I'd > love

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-15 Thread Edward Hades
On Wed, Aug 15, 2012 at 02:17:34AM +0200, Sven Krohlas wrote: > Before, the user had to explicitly share his location with Amarok > for any data to leave his network. Not Amarok does it automatically > on every startup without any warning. That's true, but the user did not know that. > > I agree

Request to install more optional Amarok deps on build.k.o

2012-08-15 Thread Matěj Laitl
Hi Torgny, first, let me send kudos to you for setting up CI for us, we've seen visible improvement in our development process since then. Looking at the build log [1] (search "following OPTIONAL packages"), there is a couple of optional dependencies that aren't installed on the building system

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-15 Thread Zhengliang Feng
> On Aug. 14, 2012, 8:30 a.m., Bart Cerneels wrote: > > src/core-impl/collections/spotifycollection/SpotifySettings.cpp, line 217 > > > > > > You probably should do readAll() here. The data will be fully available

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-15 Thread Zhengliang Feng
> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/support/Controller.cpp, line 424 > > > > > > I think there should be a restart delay here. Imagine that t

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-15 Thread Zhengliang Feng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105285/ --- (Updated Aug. 15, 2012, 6:47 a.m.) Review request for Amarok. Changes --

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-15 Thread Zhengliang Feng
> On Aug. 14, 2012, 8:14 a.m., Bart Cerneels wrote: > > src/core-impl/collections/spotifycollection/SpotifyCollection.cpp, line 149 > > > > > > QAction is a QObject so could be parented to SpotifyCollection to be >

Re: Review Request: GSoC report: Integrate Spotify into Amarok #4 (squashed commits, recent on top)

2012-08-15 Thread Zhengliang Feng
> On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > Actually these are from PlaydarCollection, I will reformat all signal & slot names later. > On Aug. 13, 2012, 4:43 p.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/spotifycollection/support/Controller.cpp, lin

[Tomahawk Integration] GSoC Final Report

2012-08-15 Thread Lucas Lira Gomes
Hi folks, for the general happiness, herein I announce that the playlist synchronisation is working perfectly in both directions. Also, I solved some problems with the track resolution process of the MetaProxy class. So, I'd love to receive any feedback if possible. On the other hand, if you are o

Jenkins build is still unstable: amarok_master #227

2012-08-15 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #228

2012-08-15 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #226

2012-08-15 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Jenkins build is still unstable: amarok_master #225

2012-08-15 Thread Jenkins CI Daemon
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel