Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/#review15763 --- In principle ok, but please have a look at my comments. The Sem

spotify collection post mid-term TODO

* SpotifyCollection Object only created if Controller status is OK and general initialization workflow * Download resolver binary from kollide from settings dialog * Pass API key on build, shepherd changes into resolver repo. * Controller GPLv3 issue -> get an exception from Leo and Muesli or we'

Jenkins build is still unstable: amarok_master #183

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] src: Fix DynamicModel test

Hi, the problem with our test running on Jenkins are that we have still less stuff that we are currently assuming. For example phonon might not really work as expected. Also not we get a big hit from our habit of creating the singleton objects in the Amarok object. The comments for e.g. Amaro

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/ --- (Updated July 12, 2012, 2:15 p.m.) Review request for Amarok, Ralf Engels

Re: Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/ --- (Updated July 12, 2012, 1:38 p.m.) Review request for Amarok, Ralf Engels

Review Request: SoK - Unit Test : core/meta/support/PrivateMetaRegistry

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105525/ --- Review request for Amarok, Matěj Laitl and Sven Krohlas. Description -

Re: [amarok] src: Fix DynamicModel test

On 12. 7. 2012 Matěj Laitl wrote: > Again, place for hard-to-find bugs in future. You should > Amarok::Compontents::setEngineController( new EngineControllerMock() ) in > test's initTestCase() instead. And when https://git.reviewboard.kde.org/r/105524/ is merged, you even can use plain vanilla

Re: [amarok] src: Prevent hang in testmetamultitrack.

On 12. 7. 2012 Matěj Laitl wrote: > Because I'm the author of the original change, I'll take responsibility to > fix the test that is broken by it. Okay, it is done in http://git.reviewboard.kde.org/r/105524/ - please review. It removes the mutex altogether and it fixes a couple more things incl

Review Request: EngineController: fixes to canDecode() and supportedMimeTypes(): make them non-static, thread-safe even on first call. (squached patches, recent on top)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105524/ --- Review request for Amarok, Ralf Engels and Sven Krohlas. Description -

Re: [amarok] src: Prevent hang in testmetamultitrack.

On 11. 7. 2012 Ralf Engels wrote: > Git commit 115cb80f9bd94b23640ca9245c97d6c8e25d2c97 by Ralf Engels. > Committed on 11/07/2012 at 16:25. > Pushed by rengels into branch 'master'. > > Prevent hang in testmetamultitrack. > > The class variable mutex had problems in the destructor. > The function

Re: [amarok] src: Fix DynamicModel test

On 11. 7. 2012 Ralf Engels wrote: > Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels. > Committed on 10/07/2012 at 11:03. > Pushed by rengels into branch 'master'. > > Fix DynamicModel test > > Don't rely on engine controller to be there. > Don't create actions for a tty applica