[Tomahawk Integration] GSoC Report

Hi everyone, Last two weeks weren’t the most productive of all, since some tests and a project consumed a lot of my time. In spite of that, I finally managed to play tomahawk streams in Amarok. To query others collections is working too. For those curious, tomahawk service is using capabilities, s

Re: Review Request: SoK - Unit Test : core/collections/QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105172/ --- (Updated June 26, 2012, 8:05 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/collections/QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105172/ --- (Updated June 26, 2012, 7:59 p.m.) Review request for Amarok, Matěj Laitl

Re: Review Request: SoK - Unit Test : core/collections/QueryMaker

> On June 26, 2012, 9:29 a.m., Matěj Laitl wrote: > > tests/core/collections/MockQueryMaker.cpp, line 18 > > > > > > No need to include moc. if the Q_OBJECT is in .h file. > > Jasneet Bhatti wrote: > When I remo

Re: Review Request: SoK - Unit Test : core/collections/QueryMaker

> On June 26, 2012, 9:29 a.m., Matěj Laitl wrote: > > tests/core/collections/MockQueryMaker.cpp, line 18 > > > > > > No need to include moc. if the Q_OBJECT is in .h file. When I remove the cpp implementation, I get

Re: Review Request: SoK - Unit Test : core/collections/QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105172/#review15160 --- The test is generally OK, but please address/answer following c