On 11. 4. 2012 Bart Cerneels wrote:
> Big one, took a while to understand everything that was happening.
> Perhaps splitting up the code deduplication and inline rename would
> have been a better option.
You're right, sorry about that. My commit-making part of the brain was having
a walk or somet
On 11. 4. 2012 Bart Cerneels wrote:
> I think the style for function statements should be applied to the
> contents of SIGNAL/SLOT macro's as well. i.e. space after and before
> the parentheses. I don't use that style for macros since they are not
> functions, with the capitals it's clear they aren
I think the style for function statements should be applied to the
contents of SIGNAL/SLOT macro's as well. i.e. space after and before
the parentheses. I don't use that style for macros since they are not
functions, with the capitals it's clear they aren't.
Probably best to stick to the style.
S
On Wed, Apr 11, 2012 at 11:10, Matěj Laitl wrote:
> I'm running this through review board as there seems no general
> agreement on Meta::Track:type() semantics. (Speaking of which, I'd be
> most satisfied if it returned (the most specific) mime-type represented
> using dedicated class that would s
> On April 10, 2012, 4:57 p.m., Matěj Laitl wrote:
> > I agree that current hard-coded value of 200px is a bit suboptimal. But I
> > doubt there is a significant group of users that makes use of multiple
> > per-file covers. When I order Amarok to replace track cover, I want Amarok
> > to "mak
> On April 10, 2012, 4:57 p.m., Matěj Laitl wrote:
> > I agree that current hard-coded value of 200px is a bit suboptimal. But I
> > doubt there is a significant group of users that makes use of multiple
> > per-file covers. When I order Amarok to replace track cover, I want Amarok
> > to "mak
> On April 10, 2012, 1:55 p.m., Bart Cerneels wrote:
> > Overall I think this is a lot of config for a pretty esoteric feature. It's
> > nice to have embedded covers, but can't we implement a default that works
> > for the 98%?
The problem why I implemented the 'overwrite mode' option was that
