Re: GSoC 2012 : Improvised proposal for 'Semantic Collection for Amarok'

2012-03-24 Thread Phalgun Guduthur
On Sat, Mar 24, 2012 at 3:25 PM, Matěj Laitl wrote: > On 2012-03-22, Phalgun Guduthur wrote: > > I have been working towards the 2012 GSoC idea 'Semantic Collection for > > Amarok' since a month now. I have already sent in my first rough draft of > > the proposal. > > > > At that time, I promise

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307/ --- (Updated March 24, 2012, 12:03 p.m.) Review request for Amarok. Changes

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Jasneet Bhatti
> On March 22, 2012, 9:46 p.m., Matěj Laitl wrote: > > src/amarokurls/BookmarkModel.cpp, line 571 > > > > > > Please don't add DEBUG_BLOCKs and debug() for code that you are not > > actually debugging. (I know, it

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Jasneet Bhatti
> On March 24, 2012, 11:03 a.m., Matěj Laitl wrote: > > src/amarokurls/AmarokUrl.h, line 47 > > > > > > Please add the following documentation comment before the method: > > > > /** > > * Sets the url a

Amarok idea need feedback

2012-03-24 Thread Igor Vileikis
I hope someone will consider my idea and I'll get feedback https://docs.google.com/document/d/1akDrnxW2aBOSVaOdOmwQOvi0XD3h1gl8xvhZGV18MA4/edit ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307/#review11802 --- The patch greatly improved, thanks! There is just a bunch of mi

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307/#review11800 --- src/amarokurls/AmarokUrl.h

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Matěj Laitl
> On March 22, 2012, 9:46 p.m., Matěj Laitl wrote: > > src/amarokurls/BookmarkModel.cpp, line 571 > > > > > > Please don't add DEBUG_BLOCKs and debug() for code that you are not > > actually debugging. (I know, it

Re: GSoC 2012 : Improvised proposal for 'Semantic Collection for Amarok'

2012-03-24 Thread Matěj Laitl
On 2012-03-22, Phalgun Guduthur wrote: > I have been working towards the 2012 GSoC idea 'Semantic Collection for > Amarok' since a month now. I have already sent in my first rough draft of > the proposal. > > At that time, I promised a proof of Concept and you can it submitted on the > review boar

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307/ --- (Updated March 23, 2012, 10:50 p.m.) Review request for Amarok. Changes

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-24 Thread Jasneet Bhatti
> On March 22, 2012, 9:46 p.m., Matěj Laitl wrote: > > src/widgets/BookmarkTriangle.h, line 37 > > > > > > What if slider width changes during the bookmark lifetime? Also, please > > also document new (or better, ev

Updated Proposal for QML Context View

2012-03-24 Thread Saurabh Sood
Hi, I have updated my proposal for QMLify Amarok Context View. I have changed some aspects of the timeline, and am still working on it. Please go through it, and suggest changes. Also, I made a sample class for Proof of Concepts, which I successfully integrated with the existing Amarok code. Do i s

[GSoC Ideas]Unit testing

2012-03-24 Thread Veaceslav Munteanu
Hello, my name is Veaceslav Munteanu and I'm year 2 student at Polytechnic University from Bucharest. I'm interested into writting unit tests for Amarok. Can you please provide me with more info about this task(how many tests I'm must write, for which part of the program, another things that I s