[Bugzilla] Release blockers

2012-02-06 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 233170: http://bugs.kde.org/show_bug.cgi?id=233170 Priority: HI Severity: crash Platform: Unlisted Binaries Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary

Re: Re: Incremental scanning (Bart Cerneels)

2012-02-06 Thread Ralf Engels
> Date: Mon, 6 Feb 2012 10:20:29 +0100 > From: Bart Cerneels > To: amarok-devel > Subject: Re: Incremental scanning > Message-ID: > > Content-Type: text/plain; charset=ISO-8859-1 > > On Wed, Feb 1, 2012 at 14:31, Ville Ranki wrote: > > > > Hello, > > > > I've been implementing increment

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-02-06 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/ --- (Updated Feb. 6, 2012, 10:37 p.m.) Review request for Amarok. Changes --

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-02-06 Thread Mathias Stephan Panzenböck
> On Feb. 2, 2012, 11:31 a.m., Matěj Laitl wrote: > > shared/tag_helpers/TagHelper.cpp, line 358 > > > > > > This change doesn't seem to be directly related to support for mod, > > s3m.. files. Could you provide ra

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-02-06 Thread Mathias Stephan Panzenböck
> On Feb. 6, 2012, 7:07 p.m., Matěj Laitl wrote: > > The last revision looks all-fine to me. When commiting, I would also apply > > following last-bits patch: > > > > diff --git a/CMakeLists.txt b/CMakeLists.txt > > index 87dc1

Re: Review Request: Another approach to fix bug 291068, be more permissive

2012-02-06 Thread Matěj Laitl
> On Feb. 6, 2012, 9 a.m., Bart Cerneels wrote: > > If it works as mentioned I like to see it committed. Can't test currently > > since my laptop is 60 km away and I'm stuck with an OSX macbook today ;). > > > > The "forbidden" drop indicator can probably be implemented safer (and with > > les

Re: Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-06 Thread Matěj Laitl
> On Feb. 6, 2012, 9:06 a.m., Bart Cerneels wrote: > > Why do we even show these plugins at all? It's feels like a big > > implementation detail that should not be expose to the user to me. Hmm, with a bit of thinking I must fully agree with you. If no one else opposes, I will implement this.

Re: Review Request: tag reading support for mod, s3m, it and xm files

2012-02-06 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review10375 --- The last revision looks all-fine to me. When commiting, I would

Re: Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103871/#review10359 --- This review has been submitted with commit 3788b0ee6d6407c1b45

Re: Incremental scanning

2012-02-06 Thread Bart Cerneels
On Wed, Feb 1, 2012 at 14:31, Ville Ranki wrote: > > Hello, > > I've been implementing incremental scanning for Amarok. > > Reason for this is that with large connection on a slow > network share (sftp over ADSL for example) scanning can > take hours. Also currently all scanned files are lost if >

Re: Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-06 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103871/#review10369 --- Why do we even show these plugins at all? It's feels like a big

Re: Review Request: Another approach to fix bug 291068, be more permissive

2012-02-06 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103856/#review10368 --- If it works as mentioned I like to see it committed. Can't test