Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-26 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603/#review10114 --- Hmm, either I'm completely dumb or v4 of the patch you submitte

Re: Draft message to packagers: Patch for Amarok 2.5.0 to fix critical usability bug with KDE 4.8

2012-01-26 Thread Bart Cerneels
I've send the message. 2012/1/26 Bart Cerneels : > I'm not subscribed to the packagers list either. You could have just send it > and it will certainly be let through in moderation by the list admin. > > > On Thursday, January 26, 2012, Matěj Laitl wrote: >> Hi list, >> as Myriam repeatedly menti

Re: Draft message to packagers: Patch for Amarok 2.5.0 to fix critical usability bug with KDE 4.8

2012-01-26 Thread Bart Cerneels
I'm not subscribed to the packagers list either. You could have just send it and it will certainly be let through in moderation by the list admin. On Thursday, January 26, 2012, Matěj Laitl wrote: > Hi list, > as Myriam repeatedly mentioned, we need to push a patch to packagers so that > Amarok c

Draft message to packagers: Patch for Amarok 2.5.0 to fix critical usability bug with KDE 4.8

2012-01-26 Thread Matěj Laitl
Hi list, as Myriam repeatedly mentioned, we need to push a patch to packagers so that Amarok can be used with KDE 4.8. Some known Amarok developer (Bart, Ralf, Mark?) should probably send (a variant of) following message to kde-packager list. I've tested the 2.5.0 + attached patch personally wit

Re: Re: Review Request: Bump the taglib dependency to 1.7

2012-01-26 Thread Daniel Faust
Hi, actually taglib 1.7 is not needed, I just forgot to wrap the #include around the #ifdef ... So I could either fix that and we can go back to taglib 1.6 or I'll remove all the #ifdef ... that are already used. greetings Daniel Commit Hook am Mittwoch, 25. Januar 2012 > >