Re: Review Request: Bump the taglib dependency to 1.7

2012-01-24 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103781/#review10068 --- Ship it! Needs to be mentioned in the README as well. - Bart

Re: Review Request: Fix for bug 289751

2012-01-24 Thread Volker Christian
> On Jan. 24, 2012, 8:39 a.m., Bart Cerneels wrote: > > Good catch. Something that could have been discovered in code review a lot > > earlier I guess. > > > > Will you commit? I think i am not able to commit as i didn't have permisions therefor. Shall i request for a developer account? - V

Re: [amarok] cmake/modules: Revert "FindMySQLAmarok.cmake fix argumets when calling mysql_config"

2012-01-24 Thread Matěj Laitl
On 19. 12. 2011 Christophe Giboudeaux wrote: > On Monday 19 December 2011 00:38:47 Matěj Laitl wrote: > > I tried to solve http://mail.kde.org/pipermail/amarok-devel/2011- > > December/009663.html > > > > Specifically, the problem is that mysql_config (at least 5.1.56) > > doesn't accept --variabl

Fwd: Re: qtscriptgenerator with Qt 4.8 / Amarok

2012-01-24 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - Original Message From: - Tue Jan 24 18:30:31 2012 Subject: Re: qtscriptgenerator with Qt 4.8 / Amarok From: Kent Hansen In-Reply-To: <4f16f9da.6060...@asbest-online.de> Date: Tue, 24 Jan 2012 18:34:27 +0100 To: Sven Krohlas De

Re: Review Request: Fix for bug 289751

2012-01-24 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103774/#review10036 --- Ship it! Good catch. Something that could have been discovered