Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103752/ --- Review request for Amarok and Teo Mrnjavac. Description --- Rework tr

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/#review9969 --- Ship it! Since the prettyName automatically falls back to the d

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-20 Thread Bart Cerneels
> On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 > > > > > > I don't understand this. Do not add a new playlist if there were no > > playlists p

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/#review9962 --- src/browsers/playlistbrowser/PlaylistBrowserModel.cpp

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/#review9961 --- This looks good (apart from some whitespace errors), let's see w

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 20, 2012, 10:43 a.m.) Review request for Amarok and Bart Cer

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Volker Christian
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 19, 2012, 9:30 p.m.) Review request for Amarok. Changes --

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-20 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/#review9960 --- src/browsers/playlistbrowser/PlaylistBrowserModel.cpp

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Volker Christian
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 19, 2012, 3:17 p.m.) Review request for Amarok. Summary (u

Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-20 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/ --- Review request for Amarok. Description --- Avoid trying to add no row

Review Request: Possibility to give an USM-Collaction a descriptive name

2012-01-20 Thread Volker Christian
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- Review request for Amarok. Description --- I sometimes missed the pos