[Bugzilla] Release blockers

2012-01-16 Thread bugzilla_noreply
The following bugs are blocking the next Amarok release: This search was scheduled by bcooks...@kde.org. Bug 233170: http://bugs.kde.org/show_bug.cgi?id=233170 Priority: HI Severity: crash Platform: Unlisted Binaries Assignee: amarok-bugs-d...@kde.org Status: REOPENED Summary

Re: Review request: MemoryMeta changes and new iPod collection

2012-01-16 Thread Matěj Laitl
On 11. 1. 2012 Bart Cerneels wrote: > > With a small bit of work, UmsCollection could get support for: > > * album covers if MetaFile::FileAlbum::{image(),hasImage()} is > > implemented * compilations if MetaFile::FileAlbum::isCompilation() is > > implemented (see ArtistHelper::bestGuessAlbumArtis

Re: Review Request: Visualization with projectM

2012-01-16 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102277/#review9879 --- Sorry for the late reply, first bought a house and then moved an

Re: Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

2012-01-16 Thread Ralf Engels
> On May 15, 2011, 11:12 a.m., Ralf Engels wrote: > > This request has been lying around unchanged for quite some time. > > > > The patch doesn't look that bad but what about the discussions? > > Nobody seemed to miss an "Add preset" button till now, so why add one? > > > > Can you summarize t

Re: Review Request: Prevent FavoredRandomTrackNavigator choosing files chosen very recently (fix bug 244442)

2012-01-16 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101836/#review9877 --- Ship it! Looks ok despite some small coding style things. I wil

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-01-16 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review9875 --- Sorry for the late response. Still a nice patch, except for the

Re: Review Request: Add an absolute date filter

2012-01-16 Thread Daniel Faust
> On Jan. 15, 2012, 10:56 p.m., Ralf Engels wrote: > > Sorry, not working for me. > > that works: > > geändert:>04.01.2012 > > geändert:<04.01.2010 > > It does show only a subset of the whole collection. > > > > that doesn't work: > > geändert:04.01.2012 > > It always seem to show the whole coll

Re: Review Request: Add an absolute date filter

2012-01-16 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103546/ --- (Updated Jan. 16, 2012, 4:21 p.m.) Review request for Amarok. Changes --

Re: Review Request: Remove setUidUrl function from EditCapability

2012-01-16 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103704/#review9859 --- Ship it! Good one, setUidUrl() should have never been in EditCa

Re: How to get the playableUrl only when the track is about to be played?

2012-01-16 Thread Matěj Laitl
On 14. 1. 2012 Dirley wrote: > Ok, I tried that, but it didnt work. Right after prepareToPlay, the > EngineController calls `play(track.playableUrl())`. Since the playable url > is being retrieved, the track playableUrl is still empty. So Amarok stops > the playback. I need a way to make the engine