Re: 2.5.0 tarball problems

2011-12-27 Thread Myriam Schweingruber
On Mon, Dec 26, 2011 at 15:12, Modestas Vainius wrote: > Hello, > > On šeštadienis 17 Gruodis 2011 23:33:18 Matěj Laitl wrote: >> On 17. 12. 2011 Modestas Vainius wrote: >> > current 2.5.0 tarball does not build. The problem is in the doc/nl (could >> > be related to kdelibs 4.6.5): >> > >> > cd .

Re: Request for review: my patch queue for 2.6

2011-12-27 Thread Sam Lade
On 27/12/11 08:56, Bart Cerneels wrote: > On Sat, Dec 24, 2011 at 15:40, Matěj Laitl wrote: >> On 20. 12. 2011 Bart Cerneels wrote: >>> Just make sure you squash the commits that belong together :) >> >> Do you mean some specific commits? E.g. there are 3 UpdateCapability removal- >> related commi

Re: Review Request: Add an absolute date filter

2011-12-27 Thread Daniel Faust
> On Dec. 27, 2011, 8:51 a.m., Bart Cerneels wrote: > > The code certainly looks good and it's a useful advanced feature. I have > > not tested it yet though. > > How does it integrate with the query editor dialog? What is the query editor dialog? If you mean the EditFilterDialog, absolute dat

Re: Request for review: my patch queue for 2.6

2011-12-27 Thread Bart Cerneels
On Sat, Dec 24, 2011 at 15:40, Matěj Laitl wrote: > On 20. 12. 2011 Bart Cerneels wrote: >> Just make sure you squash the commits that belong together :) > > Do you mean some specific commits? E.g. there are 3 UpdateCapability removal- > related commits, but each one stands on its own (with commit

Re: Review Request: Add an absolute date filter

2011-12-27 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103546/#review9291 --- The code certainly looks good and it's a useful advanced feature