Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Rick W. Chen
On 06 Nov 2011 21:41 +0100, Bart Cerneels: > On Sun, Nov 6, 2011 at 13:29, Rick W. Chen wrote: > > On 06 Nov 2011 09:22 +0100, Bart Cerneels: > >> Micro option! And as far as I can tell because only one user > >> complained on the forums. Unless Rick has a personal preference. > >> Still, we need

Most voted bugs in Amarok

2011-11-06 Thread Myriam Schweingruber
Hi all, please find below the list of the bugs most voted for: 187587 norNORNEW2.4.1Linucue sheet not working for files in collection488278897 norNORNEW2.4.3LinuAmarok uses ~40% of CPU until main window is m

Most often reported bugs in Amarok

2011-11-06 Thread Myriam Schweingruber
Hi all, Please find below the list of the most reported bugs in Amarok. Regards, Myriam 197343 36Tools/Cover Manager crashLinux2.4.1Amarok crashed when setting custom album cover (SetCustomCoverAction::slotTriggered)233170

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014/#review7986 --- Ship it! Ship It! - Matěj Laitl On Nov. 6, 2011, 7:29 p.m.,

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Bart Cerneels
On Sun, Nov 6, 2011 at 13:29, Rick W. Chen wrote: > On 06 Nov 2011 09:22 +0100, Bart Cerneels: >> Micro option! And as far as I can tell because only one user >> complained on the forums. Unless Rick has a personal preference. >> Still, we need to be very hesitant to add micro options. >> >> The a

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust
On Nov. 6, 2011, 6:10 p.m., Daniel Faust wrote: > > Good work, Daniel! Please fix remaining minor fix and I'll be happy to > > merge this. (or, do you have commit access yourself?) I can commit myself once everything is fine. - Daniel

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014/ --- (Updated Nov. 6, 2011, 7:29 p.m.) Review request for Amarok. Changes ---

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014/#review7978 --- src/core-impl/collections/support/TextualQueryFilter.cpp

Re: Review Request: Find field names (filter keywords) even if they are translated

2011-11-06 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014/ --- (Updated Nov. 6, 2011, 5:45 p.m.) Review request for Amarok. Changes ---

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Rick W. Chen
On 06 Nov 2011 09:22 +0100, Bart Cerneels: > Micro option! And as far as I can tell because only one user > complained on the forums. Unless Rick has a personal preference. > Still, we need to be very hesitant to add micro options. > > The arguments for having the backgrounds: > - Reduces the "fie

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Bart Cerneels
Micro option! And as far as I can tell because only one user complained on the forums. Unless Rick has a personal preference. Still, we need to be very hesitant to add micro options. The arguments for having the backgrounds: - Reduces the "field of grey" effect when the browsers are empty. - Gener

Re: Review Request: Add new collection filter to find exact matches

2011-11-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102252/#review7972 --- This review has been submitted with commit 3e7122a2879260b531f9

Re: Review Request: make all like conditions case insensitive

2011-11-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103015/#review7971 --- This review has been submitted with commit be77608b9ba0386c3bfc