Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Lucas Gomes
On Nov. 3, 2011, 8:34 a.m., Lucas Gomes wrote: > > I'll take a look at the provider not appearing at runtime, probably a > > QtGroupingProxy thing. Another problem is that the provider keep showing on PodcastBrowser even if I disable the gpodder service. - Lucas ---

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103034/ --- (Updated Nov. 4, 2011, 1:27 a.m.) Review request for Amarok, Stefan Derkit

Re: Review Request: Re-Add old "Normal" moodbar style

2011-11-04 Thread Florian Eßer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103036/ --- (Updated Nov. 3, 2011, 9:22 p.m.) Review request for Amarok. Changes ---

Re: Review Request: Re-Add old "Normal" moodbar style

2011-11-04 Thread Florian Eßer
> On Nov. 3, 2011, 9:17 p.m., Rick W. Chen wrote: > > I'm fine with replacing the Happy one with the old default option. > > Happy has always seem a bit too happy... Hmm, than maybe the next person comes running and complains about the regression that his/hers beloved happy style got removed. (

Re: Review Request: Change misleading/ambiguous message when deleting tracks from collection (bug 263693)

2011-11-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103026/#review7917 --- This review has been submitted with commit c38f70b6ba2f3ddf1eec

Re: Review Request: Re-Add old "Normal" moodbar style

2011-11-04 Thread Bart Cerneels
> On Nov. 4, 2011, 7:43 a.m., Bart Cerneels wrote: > > src/moodbar/MoodbarManager.cpp, line 337 > > > > > > We should use an Enum here, not hardcoded numerical values. > > > > If you add this it's OK to com

Re: Review Request: Re-Add old "Normal" moodbar style

2011-11-04 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103036/#review7931 --- src/moodbar/MoodbarManager.cpp

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103034/#review7930 --- src/services/gpodder/GpodderProvider.cpp