Re: Review Request: Prevent last.fm credential popup on Amarok start if none are set

2011-07-24 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102079/#review5075 --- src/services/lastfm/LastFmService.cpp

Re: Review Request: Prevent last.fm credential popup on Amarok start if none are set

2011-07-24 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102079/#review5074 --- FYI: http://quickgit.kde.org/?p=amarok.git&a=commitdiff&h=202c4

Review Request: Prevent last.fm credential popup on Amarok start if none are set

2011-07-24 Thread Sam Lade
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102079/ --- Review request for Amarok. Summary --- As of commit 202c49ebf8b5521b0

Review Request: Add a CMake switch for building playground

2011-07-24 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/ --- Review request for Amarok. Summary --- It seems that up to now everyo

Re: Review Request: Coverbling applet build KO in current git

2011-07-24 Thread Martin Blumenstingl
> On July 24, 2011, 6:06 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 0cc4eb24c951b29e4f140d8c7e3bd7e5d79f6654 by Manu Wagner to branch master. Thanks for the patch - and sorry that it took so long to get it included. - Martin -

Re: Review Request: Coverbling applet build KO in current git

2011-07-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101602/#review5050 --- This review has been submitted with commit 0cc4eb24c951b29e4f14

Re: Review Request: Correctly read & save last track played time to/from iPods

2011-07-24 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101723/#review5039 --- Ship it! Great. I have an iPod Touch here, latest gen, so I cou

Re: Review Request: tag reading support for mod, s3m, it and xm files

2011-07-24 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review5036 --- Very cool. - Mark On June 26, 2011, 10:21 p.m., Mathias Steph

Re: Review Request: Update playlist selection at an appropriate time when text changed in search widget

2011-07-24 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101974/#review5035 --- Ship it! Makes sense to me. - Mark On July 17, 2011, 6:06 a.

Re: Review Request: Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

2011-07-24 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101966/#review5034 --- Ship it! This sounds like a very sane change to me. - Mark O

Re: Amarok is bugging udisks-daemon

2011-07-24 Thread Ralf Engels
Hi Andreas, Previously Amarok was frequently checking the modification time of all collection directories to check for changes. Since 2.4.1 we are using the KDirWatcher. That's probably what you are seeing. The solution of constantly checking modification times is very primitive. The KDirWatcher

Re: Fwd: Radio GFM integration in Amarok by default

2011-07-24 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Marco, > This is Marco from Switzerland. I'm member of the music editorial staff of > the non-commercial > german web-radio project called „Radio GFM“. > > Radio GFM plays „GEMA-FREIE MUSIK“ which means that we do only play music > which is rele

Fwd: Radio GFM integration in Amarok by default

2011-07-24 Thread Myriam Schweingruber
FYI @Sven: I think this is very interesting for you in particular. @all: don't forget to Cc the author, as his request came through the web interface. Regards, Myriam -- Forwarded message -- From: Marco Peter Date: Fri, Jul 22, 2011 at 23:51 Subject: Radio GFM integration in A

Fwd: Amarok is bugging udisks-daemon

2011-07-24 Thread Myriam Schweingruber
FYI Could somebody answer this? Don't forget to Cc the sender, he submitted this through the web interface. Regards, Myriam -- Forwarded message -- From: Andreas Roth Date: Fri, Jul 22, 2011 at 09:49 Subject: Amarok is bugging udisks-daemon To: ama...@kde.org Hi, two or thre