Unable to find qtscriptgenerator

2011-02-19 Thread Shaun Reich
I've been trying to work through this for a while now, but I just *cannot* get cmake to find qtscriptgenerator. I am running all of kde from master and am attempting to compile amarok. I have compiled qtscriptgenerator and everything, the plugins have been generated in that source directory. I've t

Re: Review Request: New dynamic bias

2011-02-19 Thread Ralf Engels
> On Feb. 19, 2011, 7:40 p.m., Leo Franchi wrote: > > So I'm against merging this review request as it is right now. However, I > > don't think I am in any place to reject completely a feature like this > > since I have not been actively developing or improving the current > > situation when i

Re: Review Request: Podcast episode filename configuration

2011-02-19 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review1518 --- Almost all new code doesn't follow amarok code formating style (

Re: Review Request: New dynamic bias

2011-02-19 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100630/#review1517 --- So I'm against merging this review request as it is right now. H

Podcast episode filename

2011-02-19 Thread sandeep
I've submitted a review request for the filename configuration. Now, I've added some extra code to replace the layout with the actual data - for example replace %artist with the artist's name. Where should this code be inserted? I've kept it in SqlPodcastProvider::downloadResult() but that doesn't

Re: Review Request: Podcast episode filename configuration

2011-02-19 Thread Sandeep Raghuraman
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/ --- (Updated Feb. 19, 2011, 5:36 p.m.) Review request for Amarok and Bart Cern

Review Request: Podcast episode filename configuration

2011-02-19 Thread Sandeep Raghuraman
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/ --- Review request for Amarok and Bart Cerneels. Summary --- Adds a dialo

Re: Review Request: fix bug 266171. Add HTML tag in guitar tabs applet for tabs from ultimate-guitar.com

2011-02-19 Thread Rainer Sigle
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100670/#review1508 --- Thanks again Martin. I've committed it to Amarok master. - Rain

Re: Review Request: New dynamic bias

2011-02-19 Thread Ralf Engels
> On Feb. 18, 2011, 8:51 p.m., Leo Franchi wrote: > > I was playing around and removed an And bias that I added and this > > happened: http://i.imgur.com/jv63T.png > > > > not sure what to do now :) > > > > Interesting. Will have a look at that. - Ralf