Re: Review Request: Up/down key track selection while using progressive search widget

2010-11-21 Thread Thomas Karpiniec
> On 2010-11-21 20:28:48, Leo Franchi wrote: > > +1 from me too. Do you have a git account, or should we push for you? I'm pretty sure I don't. If you could push it for me that would be great, thanks. :) - Thomas --- This is an automat

Re: Review Request: Up/down key track selection while using progressive search widget

2010-11-21 Thread Leo Franchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100124/#review385 --- Ship it! +1 from me too. Do you have a git account, or should we

Re: Review Request: Fixes bugs 250746, 250750 and partially fixes bug 245646

2010-11-21 Thread Dennis Francis
> On 2010-11-21 09:44:15, Bart Cerneels wrote: > > Ah, using the actions certainly is a nice move. The removeRow path for > > deleting playlistbrowser items is a tricky one, so why not avoid it when > > possible. > > Thanks for the fix. > > Bart Cerneels wrote: > Pushed to git master: >

Re: Review Request: Fixes bugs 250746, 250750 and partially fixes bug 245646

2010-11-21 Thread Bart Cerneels
> On 2010-11-21 09:44:15, Bart Cerneels wrote: > > Ah, using the actions certainly is a nice move. The removeRow path for > > deleting playlistbrowser items is a tricky one, so why not avoid it when > > possible. > > Thanks for the fix. Pushed to git master: http://commits.kde.org/amarok/22c4f

Re: Review Request: Fixes bugs 250746, 250750 and partially fixes bug 245646

2010-11-21 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100158/#review377 --- Ship it! Ah, using the actions certainly is a nice move. The rem