Re: [Amarok] d9d27ca: Font size of OSD is now configurable

2010-11-07 Thread Mark Kretschmann
On Tue, Oct 12, 2010 at 1:01 AM, Soren Harward wrote: > commit d9d27ca96e4a1e8c06aea03c8c4cddcbbd02daf7 > Author: Soren Harward > Date:   Mon Oct 11 18:57:50 2010 -0400 > >    Font size of OSD is now configurable > >    For some reason, the OSD preview in the configuration dialog ignores the >  

Re: time to update the about dialog

2010-11-07 Thread Leo Franchi
On Sunday, November 07, 2010 11:26:02 PM Myriam Schweingruber wrote: > Hi all, > > On Fri, Nov 5, 2010 at 22:53, Lydia Pintscher wrote: > > Heya folks :) > > > > I think it's time to look at who should be added to the about dialog > > for 2.4. We've had a lot of contributions from new people lat

Re: time to update the about dialog

2010-11-07 Thread Myriam Schweingruber
Hi all, On Fri, Nov 5, 2010 at 22:53, Lydia Pintscher wrote: > Heya folks :) > > I think it's time to look at who should be added to the about dialog > for 2.4. We've had a lot of contributions from new people lately and > that's really great. If you have someone in mind who has made great > cont

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

2010-11-07 Thread Soren Harward
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/#review327 --- Okay, here are my comments on r5: - Now that the TagMatch class

Re: Review Request: Improve lyrics applet

2010-11-07 Thread Martin Blumenstingl
> On 2010-11-07 04:48:01, Rick W. Chen wrote: > > I'm able to resolve the text colour problem. For the labels that were > > affected, plasma theme's text colour were used. Removing those let the > > labels use app colours. > > > > I made a patch ontop of yours at > > g...@git.kde.org:clones/a

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

2010-11-07 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/ --- (Updated 2010-11-07 19:06:34.115132) Review request for Amarok. Changes

Crash with Last.fm streams

2010-11-07 Thread Mark Kretschmann
Hey folks, we seem to have a regression when playing Last.fm streams. Amarok crashes instantly: Thread 1 (Thread 0x77ea9780 (LWP 12211)): #0 0x00fa3d80 in ?? () #1 0x7584ad13 in QObject::connect (sender=0xfa3610, signal=0x71b13b95 "2changed()", receiver=0x25ceb20, metho

Re: Re: [Amarok] b18a028: Use shared memory for collection

2010-11-07 Thread Ralf Engels
> Date: Sun, 7 Nov 2010 13:14:26 +0100 > From: Maximilian Kossick > Subject: Re: Re: [Amarok] b18a028: Use shared memory for collection > To: amarok-devel@kde.org > Message-ID: > > Content-Type: text/plain; charset=UTF-8 > > On Sun, Nov 7, 2010 at 11:33 AM, Ralf Engels wrote: > > snip >

Re: Review Request: Fixes for TagUtility. Turn back MPC files support.

2010-11-07 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100129/#review322 --- Ship it! Well looks good. Call a ship, patch over board! ;) -

Re: Review Request: Fixes for TagUtility. Turn back MPC files support.

2010-11-07 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100129/#review321 --- So what about this patch? :) - Sergey On 2010-11-07 08:43:45,

Re: Review Request: Improve lyrics applet

2010-11-07 Thread Martin Blumenstingl
> On 2010-11-07 04:48:01, Rick W. Chen wrote: > > I'm able to resolve the text colour problem. For the labels that were > > affected, plasma theme's text colour were used. Removing those let the > > labels use app colours. > > > > I made a patch ontop of yours at > > g...@git.kde.org:clones/a

Re: Updated: Re: [Amarok] 2.3.2 scanning Qt bug/regression

2010-11-07 Thread Mark Kretschmann
On Mon, Nov 1, 2010 at 12:44 PM, Lydia Pintscher wrote: > I will try to find time for this this week but I can't promise I'll > get to it at all. Sorry. I'll also need help from Jeff who's gone > until at least tomorrow. In case that we should release a 2.3.2.1, here is a short list of patches th

Re: Re: [Amarok] b18a028: Use shared memory for collection

2010-11-07 Thread Maximilian Kossick
On Sun, Nov 7, 2010 at 11:33 AM, Ralf Engels wrote: > >> Message: 1 >> Date: Sat, 06 Nov 2010 09:03:34 -0400 >> From: Jeff Mitchell >> Subject: Re: [Amarok] b18a028: Use shared memory for collection >>       scanner to      rememb >> To: maximilian.koss...@gmail.com, amarok-devel@kde.org >> Cc: k

Re: Re: [Amarok] b18a028: Use shared memory for collection

2010-11-07 Thread Mark Kretschmann
On Sun, Nov 7, 2010 at 11:33 AM, Ralf Engels wrote: > Also while playing around with taglib I never encountered a crash > directly caused by taglib. Pure luck. Use a large enough collection, and it *will* crash :) -- Mark Kretschmann Amarok Developer, Software Engineer at KO GmbH Fellow of the

Re: Re: [Amarok] b18a028: Use shared memory for collection

2010-11-07 Thread Ralf Engels
> Message: 1 > Date: Sat, 06 Nov 2010 09:03:34 -0400 > From: Jeff Mitchell > Subject: Re: [Amarok] b18a028: Use shared memory for collection > scanner to rememb > To: maximilian.koss...@gmail.com, amarok-devel@kde.org > Cc: kde-comm...@kde.org > Message-ID: <4cd55226.9030...@kde.org> >

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

2010-11-07 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/ --- (Updated 2010-11-07 09:47:32.461606) Review request for Amarok. Changes

Re: Review Request: Fixes for TagUtility. Turn back MPC files support.

2010-11-07 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100129/ --- (Updated 2010-11-07 08:43:45.646733) Review request for Amarok. Changes