[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a429dfc - [Driver][SPIR-V] Use consistent tools to convert between text and binary form (#120266)

Author: Nick Sarnie Date: 2025-01-09T15:59:21Z New Revision: a429dfc167258cf023b2e4c20874a228298372e6 URL: https://github.com/llvm/llvm-project/commit/a429dfc167258cf023b2e4c20874a228298372e6 DIFF: https://github.com/llvm/llvm-project/commit/a429dfc167258cf023b2e4c20874a228298372e6.diff LOG: [

[clang-tools-extra] [clang-tidy][use-internal-linkage] fix false positive for consteval function (PR #122141)

https://github.com/chfast approved this pull request. https://github.com/llvm/llvm-project/pull/122141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

https://github.com/erichkeane approved this pull request. I think this is fine now. https://github.com/llvm/llvm-project/pull/120327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] improve error message for missing cmath (PR #122155)

https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/122155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement __builtin_constant_p differently (PR #122099)

philnik777 wrote: > > * We check whether two pointers are in the same range > > > > Is that possible to implement in the interpreter without going back to AST > > visitors? > > I take "in the same range" meaning as "can be compared at compile time at > all" here, so yes, that would be rather

[clang] [llvm] [AArch64] Change feature dependencies of fp8 features (PR #122280)

https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/119387 >From 8781ff2355750ae61d140620b1f6862537de07e3 Mon Sep 17 00:00:00 2001 From: gbMattN Date: Tue, 10 Dec 2024 15:01:37 + Subject: [PATCH 1/8] [ASan] Add metadata to renamed instructions so ASan doesn't use t

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -3423,6 +3425,30 @@ VarDecl *BindingDecl::getHoldingVar() const { return VD; } +void DecompositionDecl::VisitHoldingVars( +llvm::function_ref F) const { + VisitBindings([&](BindingDecl *BD) { +if (VarDecl *VD = BD->getHoldingVar()) + F(VD); + }); +} + +void

[clang] [llvm] Reimplement constrained 'trunc' using operand bundles (PR #118253)

kpneal wrote: D146845 wasn't committed because it would have caused test failures. The tests are wrong, the new checks reveal this, but the new checks cannot be committed until all broken tests are fixed. Otherwise we get failures from the bots and the Verifier checks would have been reverted.

[clang] [clang] Don't infer lifetime_capture-by for reference of raw pointer types. (PR #122240)

@@ -406,7 +406,7 @@ void use() { strings.insert(strings.begin(), std::string()); std::vector pointers; - pointers.push_back(getLifetimeBoundPointer(std::string())); // expected-warning {{object whose reference is captured by 'pointers' will be destroyed at the end of th

[clang-tools-extra] c01ffab - [clang-tidy][doc] reorder release note

Author: Congcong Cai Date: 2025-01-09T23:25:33+08:00 New Revision: c01ffab6e1dac13a344a06677f413e55073d0580 URL: https://github.com/llvm/llvm-project/commit/c01ffab6e1dac13a344a06677f413e55073d0580 DIFF: https://github.com/llvm/llvm-project/commit/c01ffab6e1dac13a344a06677f413e55073d0580.diff

[clang-tools-extra] [clang-tidy] Fix misc-unused-parameters on params with attrs (PR #122286)

emaxx-google wrote: @usx95 https://github.com/llvm/llvm-project/pull/122286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

https://github.com/jvoung updated https://github.com/llvm/llvm-project/pull/122290 >From 342ff1a05caa6943fe8a86415f30b433ac30106f Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Thu, 9 Jan 2025 14:10:30 + Subject: [PATCH 1/2] [clang-tidy] Add a release note about unchecked-optional-access s

[clang-tools-extra] [clang-tidy] Fix misc-unused-parameters on params with attrs (PR #122286)

https://github.com/emaxx-google updated https://github.com/llvm/llvm-project/pull/122286 >From 3faba8c3df1901d9fb58bf0d087a2a832ac9f04a Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Thu, 9 Jan 2025 14:59:35 + Subject: [PATCH 1/2] [clang-tidy] Fix misc-unused-parameters on params with

[clang] [clang] constexpr atomic builtins (__c11_atomic_OP and __atomic_OP) (PR #98756)

hanickadot wrote: > Unfortunately we currently have two constant expression evaluators, can you > take a look at implementing this in the bytecode interpreter as well? Since > this PR is already pretty big I think it would be OK to do it in a follow-up > PR. I will try, I'm not familiar with

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -2202,6 +2202,17 @@ void ASTStmtWriter::VisitPackIndexingExpr(PackIndexingExpr *E) { Code = serialization::EXPR_PACK_INDEXING; } +void ASTStmtWriter::VisitResolvedUnexpandedPackExpr( erichkeane wrote: DID you see my comment on how to test these? I made

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

https://github.com/jvoung edited https://github.com/llvm/llvm-project/pull/122290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr atomic builtins (__c11_atomic_OP and __atomic_OP) (PR #98756)

Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: tbaederr wrote: Unfortunately we currently have two constant

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/6586 Here is the relevant piece of the build log fo

[clang] [clang][bytecode] Implement __builtin_constant_p differently (PR #122099)

tbaederr wrote: >- We check whether two pointers are in the same range > > Is that possible to implement in the interpreter without going back to AST > visitors? I take "in the same range" meaning as "can be compared at compile time at all" here, so yes, that would be rather trivial (we ha

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

@@ -137,6 +137,10 @@ llvm::AllocaInst *CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, Alloca = new llvm::AllocaInst(Ty, CGM.getDataLayout().getAllocaAddrSpace(), ArraySize, Name, AllocaInsertPt->getIterator()); + if (Alloca->getName

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: @JDevlieghere The previous attempt made some lldb build bots fail. I've now changed `TypeSystemClang.cpp` to create `ConstantExpr`s for the bitwidth values and adapted one of the tests. Please review. https://github.com/llvm/ll

[clang-tools-extra] [clang-tidy] Fix misc-unused-parameters on params with attrs (PR #122286)

https://github.com/emaxx-google updated https://github.com/llvm/llvm-project/pull/122286 >From 3faba8c3df1901d9fb58bf0d087a2a832ac9f04a Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Thu, 9 Jan 2025 14:59:35 + Subject: [PATCH] [clang-tidy] Fix misc-unused-parameters on params with attrs

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/122289 >From 813b4bee5bddfbbc3eec8a7047c51cfde825bcee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 9 Jan 2025 16:01:59 +0100 Subject: [PATC

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/122290 With caching added in https://github.com/llvm/llvm-project/pull/120249, inform in notes that the `IgnoreSmartPointerDereference` option shouldn't be needed anymore. Other caching also added earlier: https://githu

[clang-tools-extra] [clang-tidy][NFC] clean readability-use-std-min-max (PR #122288)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes 1. add `static` for internal linkage functions 2. remove `clang` prefix for `QualType` --- Full diff: https://github.com/llvm/llvm-project/pull/122288.diff 1

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Timm Baeder (tbaederr) Changes --- Patch is 43.47 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/122289.diff 40 Files Aff

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Timm Baeder (tbaederr) Changes --- Patch is 43.47 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/122289.diff 40 Files Affected: -

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-lldb Author: Timm Baeder (tbaederr) Changes --- Patch is 43.47 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/122289.diff 40 Files Affected: - (modified

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-backend-x86 Author: Timm Baeder (tbaederr) Changes --- Patch is 43.47 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull

[clang-tools-extra] [clang-tidy][NFC] clean readability-use-std-min-max (PR #122288)

https://github.com/HerrCai0907 ready_for_review https://github.com/llvm/llvm-project/pull/122288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] Reapply "[clang] Avoid re-evaluating field bitwidth" (PR #122289)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/122289 None >From 813b4bee5bddfbbc3eec8a7047c51cfde825bcee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 9 Jan 2025 16:01:59 +0100 Subject:

[clang-tools-extra] [clang-tidy][NFC] clean readability-use-std-min-max (PR #122288)

HerrCai0907 wrote: * **#122288** https://app.graphite.dev/github/pr/llvm/llvm-project/122288?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/

[clang-tools-extra] [clang-tidy][NFC] clean readability-use-std-min-max (PR #122288)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/122288 1. add `static` for internal linkage functions 2. remove `clang` prefix for `QualType` >From e12379058b4d4b22f46d7727f4ad28ecc2468f7a Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 9 Jan 2025 22:42:

[clang] Fix greatergreater (PR #122282)

https://github.com/andergnet updated https://github.com/llvm/llvm-project/pull/122282 >From e2780f01d47518bb61a5c01c9ad4d9daddb5044a Mon Sep 17 00:00:00 2001 From: W123011 Date: Thu, 9 Jan 2025 15:04:26 +0100 Subject: [PATCH 1/3] Fix >> behavior on continuation intenter --- clang/lib/Format/C

[clang-tools-extra] [clang-tidy] Fix misc-unused-parameters on params with attrs (PR #122286)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Maksim Ivanov (emaxx-google) Changes Don't suggest to comment-out the parameter name if the parameter has an attribute that's spelled after the parameter name. This prevents the parameter's attributes from being wrongly applied to th

[clang-tools-extra] [clang-tidy] Fix misc-unused-parameters on params with attrs (PR #122286)

https://github.com/emaxx-google created https://github.com/llvm/llvm-project/pull/122286 Don't suggest to comment-out the parameter name if the parameter has an attribute that's spelled after the parameter name. This prevents the parameter's attributes from being wrongly applied to the parame

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

erichkeane wrote: That seems like a heavy hand. Should we instead be checking the 'unevaluated context' state to see whether we should be emitting stuff? I can't imagine that anything from an unevaluated context should ever be emitted. https://github.com/llvm/llvm-project/pull/102857 ___

[clang] 1a73654 - [Clang] disallow attributes after namespace identifier (#121614)

Author: Oleksandr T. Date: 2025-01-09T17:01:30+02:00 New Revision: 1a73654b3212b623ac21b9deb3aeaadc6906b7e4 URL: https://github.com/llvm/llvm-project/commit/1a73654b3212b623ac21b9deb3aeaadc6906b7e4 DIFF: https://github.com/llvm/llvm-project/commit/1a73654b3212b623ac21b9deb3aeaadc6906b7e4.diff

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/121614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

https://github.com/a-tarasyuk closed https://github.com/llvm/llvm-project/pull/121614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

https://github.com/erichkeane commented: Most of this looks good, a handful of small concerns/changes I want, else pretty good. https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -1965,3 +1965,52 @@ CXXFoldExpr::CXXFoldExpr(QualType T, UnresolvedLookupExpr *Callee, SubExprs[SubExpr::RHS] = RHS; setDependence(computeDependence(this)); } + +ResolvedUnexpandedPackExpr::ResolvedUnexpandedPackExpr(SourceLocation BL, +

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -12726,11 +12726,15 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { // Likewise, variables with tuple-like bindings are required if their // bindings have side-effects. - if (const auto *DD = dyn_cast(VD)) -for (const auto *BD : DD->bindings()) - if (co

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -2556,6 +2558,15 @@ void StmtPrinter::VisitPackIndexingExpr(PackIndexingExpr *E) { OS << "]"; } +void StmtPrinter::VisitResolvedUnexpandedPackExpr( +ResolvedUnexpandedPackExpr *E) { + OS << "getExprs() + E->getNumExprs(), erichkeane

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -3423,6 +3425,30 @@ VarDecl *BindingDecl::getHoldingVar() const { return VD; } +void DecompositionDecl::VisitHoldingVars( erichkeane wrote: Rather than both of these functions, I'd prefer we have some sort of iterators that allow standard iteration over

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -2484,6 +2488,14 @@ TemplateInstantiator::TransformDeclRefExpr(DeclRefExpr *E) { if (PD->isParameterPack()) return TransformFunctionParmPackRefExpr(E, PD); + if (BindingDecl *BD = dyn_cast(D); BD && BD->isParameterPack()) { +BD = cast(TransformDecl(BD->getL

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -4167,6 +4165,8 @@ class BindingDecl : public ValueDecl { /// Set the decomposed variable for this BindingDecl. void setDecomposedDecl(ValueDecl *Decomposed) { Decomp = Decomposed; } + VarDecl *getHoldingVar() const; erichkeane wrote: Can we get the c

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -5321,6 +5321,58 @@ class BuiltinBitCastExpr final } }; +// Represents an unexpanded pack where the list of expressions are +// known. These are used when structured bindings introduce a pack. +class ResolvedUnexpandedPackExpr final +: public Expr, + private llvm

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/121417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -15991,6 +15991,13 @@ TreeTransform::TransformFunctionParmPackExpr(FunctionParmPackExpr *E) { return E; } +template +ExprResult TreeTransform::TransformResolvedUnexpandedPackExpr( +ResolvedUnexpandedPackExpr *E) { + // Default behavior is to do nothing with this tr

[clang] [Clang][P1061] Add stuctured binding packs (PR #121417)

@@ -5321,6 +5321,58 @@ class BuiltinBitCastExpr final } }; +// Represents an unexpanded pack where the list of expressions are +// known. These are used when structured bindings introduce a pack. +class ResolvedUnexpandedPackExpr final +: public Expr, + private llvm

[clang] [llvm] [BasicAA] Do not decompose past casts with different index width (PR #119365)

frasercrmck wrote: > @frasercrmck BasicAA returns MayAlias for your example. Presumably AMDGPUAA > returns NoAlias because addrspace(3) and addrspace(0) can't alias, or > something like that. Yep, you're right, sorry for the false alarm. Because it's a `amdgpu_kernel` function and `A` (`%incd

[clang] Fix greatergreater (PR #122282)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Ander (andergnet) Changes This PR fixes the issue https://github.com/llvm/llvm-project/issues/106228 were the C++ ">>" operator got a different formatting than the "<<" one when using BreakBinaryOperations. This is my first PR on

[clang] Fix greatergreater (PR #122282)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix greatergreater (PR #122282)

https://github.com/andergnet created https://github.com/llvm/llvm-project/pull/122282 This PR fixes the issue https://github.com/llvm/llvm-project/issues/106228 were the C++ ">>" operator got a different formatting than the "<<" one when using BreakBinaryOperations. This is my first PR on the

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

cor3ntin wrote: I spent sometimes on this with @zyn0217 ```cpp template using compare_three_way_result_t = _Up ::type; struct __sfinae_assign_base {}; template requires ([](W) { return true; }(_Up())) // #1 compare_three_way_result_t<_Tp, _Up> operator<=>(_Tp, _Up); //#2 struct RuntimeM

[clang] [llvm] [HLSL] Explicitly set the SPIR-V version with spv-target-env (PR #121961)

https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/121961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d723587 - [HLSL] Explicitly set the SPIR-V version with spv-target-env (#121961)

Author: Steven Perron Date: 2025-01-09T09:39:56-05:00 New Revision: d7235876867dd21b636868e242400271cca15109 URL: https://github.com/llvm/llvm-project/commit/d7235876867dd21b636868e242400271cca15109 DIFF: https://github.com/llvm/llvm-project/commit/d7235876867dd21b636868e242400271cca15109.diff

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

https://github.com/carlocab edited https://github.com/llvm/llvm-project/pull/122144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

https://github.com/carlocab edited https://github.com/llvm/llvm-project/pull/122144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add SPIR-V version of getPointer. (PR #121963)

@@ -104,6 +104,8 @@ class CGHLSLRuntime { GENERATE_HLSL_INTRINSIC_FUNCTION(SClamp, sclamp) GENERATE_HLSL_INTRINSIC_FUNCTION(UClamp, uclamp) + GENERATE_HLSL_INTRINSIC_FUNCTION(CreateResourceGetPointer, s-perron wrote: I was following the example of `Creat

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

@@ -3494,6 +3494,9 @@ def fno_struct_path_tbaa : Flag<["-"], "fno-struct-path-tbaa">, Group; def fno_strict_enums : Flag<["-"], "fno-strict-enums">, Group; def fno_strict_overflow : Flag<["-"], "fno-strict-overflow">, Group, Visibility<[ClangOption, FlangOption]>; +def fno_z

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

erichkeane wrote: > > Is kinda wrong, it should be in the instantiation of that function... > > @erichkeane I don’t quite understand: the CWG issue itself requires us to > check the constraint before substituting into the function during template > argument deduction. So it shouldn’t live in a

[clang] [Clang][OpenMP][Doc] Update OpenMPSupport.rst (PR #122174)

github-actions[bot] wrote: @CatherineMoore Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

https://github.com/MrSidims approved this pull request. https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP][Doc] Update OpenMPSupport.rst (PR #122174)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/122174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c85d516 - [Clang][OpenMP][Doc] Update OpenMPSupport.rst (#122174)

Author: CatherineMoore Date: 2025-01-09T08:33:37-06:00 New Revision: c85d5163b1d204d5886010e6640654721925a84e URL: https://github.com/llvm/llvm-project/commit/c85d5163b1d204d5886010e6640654721925a84e DIFF: https://github.com/llvm/llvm-project/commit/c85d5163b1d204d5886010e6640654721925a84e.diff

[clang] [llvm] [AMDGPU] Remove s_wakeup_barrier instruction (PR #122277)

mbrkusanin wrote: > Context? Instruction is unused. https://github.com/llvm/llvm-project/pull/122277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow attributes after namespace identifier (PR #121614)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/121614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Remove s_wakeup_barrier instruction (PR #122277)

arsenm wrote: Context? https://github.com/llvm/llvm-project/pull/122277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

https://github.com/alexey-bataev commented: Need to change the caption and summary of PR, I assume https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

https://github.com/gbMattN edited https://github.com/llvm/llvm-project/pull/119387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Split NullDereferenceChecker into a modeling and reporting (PR #122139)

=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/122139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

gbMattN wrote: > I don't see (from description) why it's needed. A reproducer of the issue can be seen [failing on godbolt here](https://godbolt.org/z/KjPP4jrod) This is based off [this bugzilla ticket](https://bugs.llvm.org/show_bug.cgi?id=47982) I forgot to put this at the top when I undraf

[clang] [llvm] [AMDGPU] Remove s_wakeup_barrier instruction (PR #122277)

llvmbot wrote: @llvm/pr-subscribers-mc Author: Mirko Brkušanin (mbrkusanin) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122277.diff 10 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (-1) - (modified) llvm/include/llvm/IR/IntrinsicsAMDGP

[clang] [llvm] [AMDGPU] Remove s_wakeup_barrier instruction (PR #122277)

https://github.com/mbrkusanin created https://github.com/llvm/llvm-project/pull/122277 None From 27d929a270ea1d8d3fa885f00794a092af12e50e Mon Sep 17 00:00:00 2001 From: Mirko Brkusanin Date: Mon, 23 Dec 2024 12:25:25 +0100 Subject: [PATCH] [AMDGPU] Remove s_wakeup_barrier instruction --- cla

[clang] [clang] Refine the temporay object member access filtering for GSL pointer (PR #122088)

@@ -1103,6 +1094,8 @@ shouldLifetimeExtendThroughPath(const IndirectLocalPath &Path) { for (auto Elem : Path) { if (Elem.Kind == IndirectLocalPathEntry::DefaultInit) return PathLifetimeKind::Extend; +if (Elem.Kind == IndirectLocalPathEntry::MemberExpr) + c

[clang] [clang] Refine the temporay object member access filtering for GSL pointer (PR #122088)

https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/122088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refine the temporay object member access filtering for GSL pointer (PR #122088)

@@ -1103,6 +1094,8 @@ shouldLifetimeExtendThroughPath(const IndirectLocalPath &Path) { for (auto Elem : Path) { if (Elem.Kind == IndirectLocalPathEntry::DefaultInit) return PathLifetimeKind::Extend; +if (Elem.Kind == IndirectLocalPathEntry::MemberExpr) + c

[clang] [clang] Refine the temporay object member access filtering for GSL pointer (PR #122088)

https://github.com/usx95 approved this pull request. Thanks. LGTM. Left one comment. https://github.com/llvm/llvm-project/pull/122088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP] [Modules] Delay reading type source info of the preferred_name attribute. (PR #122250)

https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/122250 >From 0a615576181a538bc0d8eff6499ad87cbdeb89c3 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Thu, 9 Jan 2025 09:36:35 +0100 Subject: [PATCH 1/2] [WIP] Delay reading type source info of the preferred_n

[clang] [AArch64][SME] Add diagnostics for SME attributes on lambda functions (PR #121777)

@@ -1328,4 +1328,57 @@ void SemaARM::handleInterruptAttr(Decl *D, const ParsedAttr &AL) { ARMInterruptAttr(getASTContext(), AL, Kind)); } +// Check if the function definition uses any AArch64 SME features without +// having the '+sme' feature enabled and warn

[clang] [AArch64][SME] Add diagnostics for SME attributes on lambda functions (PR #121777)

https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/121777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Update stale test after #97265 (PR #122272)

https://github.com/NagyDonat approved this pull request. https://github.com/llvm/llvm-project/pull/122272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Remove some orphaned images (PR #122249)

steakhal wrote: Now that I looked at that PR, it was merged without approval, while having open comments. https://github.com/llvm/llvm-project/pull/122249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

@@ -1550,6 +1550,8 @@ NamedDecl *Sema::ActOnNonTypeTemplateParameter(Scope *S, Declarator &D, IdResolver.AddDecl(Param); } + ProcessDeclAttributes(S, Param, D); AaronBallman wrote: I think that makes sense, thanks! https://github.com/llvm/llvm-projec

[clang] [NFC][analyzer][docs] Remove some orphaned images (PR #122249)

NagyDonat wrote: I assumed the correctness of the old commits, but now that I looked into it, it seems that the three `example_*.png` images were orphaned by PR https://github.com/llvm/llvm-project/pull/112831 which converted the FAQ from HTML to RST. @gamesh411 Why didn't you add these images

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

@@ -15978,6 +15988,24 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body, CheckCoroutineWrapper(FD); } + // Diagnose invalid SYCL kernel entry point function declarations. + if (FD && !FD->isInvalidDecl() && !FD->isTemplated() && + FD->hasAttr()) { +

[clang] [llvm] [llvm][NFC] Rework Timer.cpp globals to ensure valid lifetimes (PR #121663)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot4` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/7207 Here is the relevant pi

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

https://github.com/jeanPerier edited https://github.com/llvm/llvm-project/pull/122144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Add a flag to control zero initialization of global v… (PR #122144)

https://github.com/jeanPerier approved this pull request. Thanks Kiran! Regarding the name, I never have strong opinions about them. Maybe `fno-zero-init-globals` is enough (the description talks about the without-init part, and it is rather obvious I think that this will not affect/control use

[clang] [C++20] Destroying delete and deleted destructors (PR #118800)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/118800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] Destroying delete and deleted destructors (PR #118800)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/118800 >From 34d3d3000bc6096bbc9eb35ce85b6ceca50b91ca Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 5 Dec 2024 08:31:24 -0500 Subject: [PATCH 1/8] [C++20] Destroying delete and deleted destructors When

[clang] 5ff7f47 - [C++20] Destroying delete and deleted destructors (#118800)

Author: Aaron Ballman Date: 2025-01-09T08:29:19-05:00 New Revision: 5ff7f479a1f30d9c5393e4f94df6178a63cc2236 URL: https://github.com/llvm/llvm-project/commit/5ff7f479a1f30d9c5393e4f94df6178a63cc2236 DIFF: https://github.com/llvm/llvm-project/commit/5ff7f479a1f30d9c5393e4f94df6178a63cc2236.diff

[clang] [analyzer][NFC] Update stale test after #97265 (PR #122272)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes In my patch there, I left a test expectation stale. Tests with `REQUIRES: Z3` never run because no bots check such configurations. Here I'm adjusting the test expectations to meet reality. --- Full diff:

[clang] [analyzer][NFC] Update stale test after #97265 (PR #122272)

llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes In my patch there, I left a test expectation stale. Tests with `REQUIRES: Z3` never run because no bots check such configurations. Here I'm adjusting the test expectations to meet reality

[clang] [analyzer][NFC] Update stale test after #97265 (PR #122272)

https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/122272 In my patch there, I left a test expectation stale. Tests with `REQUIRES: Z3` never run because no bots check such configurations. Here I'm adjusting the test expectations to meet reality. >From 70d29e2ed8a98

  1   2   3   4   5   6   7   8   9   10   >