[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread Tom Stellard via cfe-commits
tstellar wrote: This looks fine. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Depot runners pgo (PR #120777)

2024-12-21 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/120777 >From cb87398ea7f654559799ff7f79f292842832c29c Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 20 Nov 2024 20:59:38 -0800 Subject: [PATCH 01/12] Workflows: Use new depot runners for x86 Linux release bu

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-19 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 01/10] [clang][cmake] Apply bolt optimizations as part of the cla

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-19 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 1/7] [clang][cmake] Apply bolt optimizations as part of the clang

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-19 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 1/6] [clang][cmake] Apply bolt optimizations as part of the clang

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 1/4] [clang][cmake] Apply bolt optimizations as part of the clang

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 1/3] [clang][cmake] Apply bolt optimizations as part of the clang

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119896 >From dd1f6807904691586c715d447fff54915a46c751 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 3 Dec 2024 22:32:46 + Subject: [PATCH 1/2] [clang][cmake] Apply bolt optimizations as part of the clang

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

2024-12-13 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/119896 This change removes the need to call the clang-bolt target in order to apply bolt optimizations to clang. Now running `ninja clang` will build a clang with bolt optimizations, and `ninja check-clang` and `nin

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-13 Thread Tom Stellard via cfe-commits
@@ -20,9 +21,13 @@ elif clang_bolt_mode == "perf": else: assert 0, "Unsupported CLANG_BOLT_MODE variable" -config.clang = perf_wrapper + os.path.realpath( +clang_nowrapper = os.path.realpath( lit.util.which(clang_binary, config.clang_tools_dir) ).replace("\\", "/") +

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/119117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-10 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119117 >From 5d13b69039fab7c5960288cead18dc76f5d01f4f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 5 Dec 2024 15:01:27 + Subject: [PATCH 1/5] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/119117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119117 >From 5d13b69039fab7c5960288cead18dc76f5d01f4f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 5 Dec 2024 15:01:27 + Subject: [PATCH 1/4] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119117 >From 5d13b69039fab7c5960288cead18dc76f5d01f4f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 5 Dec 2024 15:01:27 + Subject: [PATCH 1/3] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-09 Thread Tom Stellard via cfe-commits
tstellar wrote: @aaupov When we build llvm-support there is one perf.data file generate for each cpp file compiled, so we end up without about 150 files. Is there some way to merge those together before running perf2bolt? https://github.com/llvm/llvm-project/pull/119117 __

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119117 >From 5d13b69039fab7c5960288cead18dc76f5d01f4f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 5 Dec 2024 15:01:27 + Subject: [PATCH] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf This

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/119117 This fixes the llvm-support build that generates the profile data. However, I'm wondering if maybe we should disable llvm-suppot and only run hello-world with -DCLANG_BOLT=perf. The bolt optimizations with pe

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick 18af3fc1bf8855e1e166e64a9210ed07d610aa54 https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/118978 The first path argument was always being ignored, and since most calls to this command only passed one path, it wasn't actually doing anything in most cases. This bug was introduced by dd0356d741aefa25ece973d6

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-11-27 Thread Tom Stellard via cfe-commits
tstellar wrote: > Well, we're currently approaching this from the angle of "expose everything > and then the user can do whatever they want", but perhaps the discussion we > should be having is "what use cases do we explicitly want to support?" and > then we write plugins to demonstrate that w

[clang] [CMake] Add a cache file for building a highly-optimized LLVM toolchain (PR #117802)

2024-11-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/117802 >From 3bddb3c6d25efbfcc901a42a8367be85599d1f7e Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 23 Sep 2024 13:34:46 + Subject: [PATCH 1/2] [CMake] Add a cache file for building a highly-optimized LL

[clang] [CMake] Add a cache file for building a highly-optimized LLVM toolchain (PR #117802)

2024-11-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/117802 The goal of these cache files is to provide a toolchain that: 1. Relies on only LLVM components (as much as possible). 2. Is highly optimized. These cache files will produce a full toolchain (clang/compiler-rt

[clang] [llvm] Introduce symbol versioning for clang-cpp (PR #116556)

2024-11-19 Thread Tom Stellard via cfe-commits
tstellar wrote: @aaronpuchert That looks fine to me. https://github.com/llvm/llvm-project/pull/116556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Introduce symbol versioning for clang-cpp (PR #116556)

2024-11-18 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. This LGTM. I'm fine taking this version instead of my patch. https://github.com/llvm/llvm-project/pull/116556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[libclc] [libclc] Move sign to the CLC builtins library (PR #115699)

2024-11-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar commented: So is the sign function currently implemented in the OpenCL headers? https://github.com/llvm/llvm-project/pull/115699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-11-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/111625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-28 Thread Tom Stellard via cfe-commits
tstellar wrote: Is there any reason why the tool should be in the monorepo and not some other repository? Also, as for keeping the annotations up-to-date. My recommendation is to add a github action job that runs the ids tool and then submits a pull request for any necessary changes. We co

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-21 Thread Tom Stellard via cfe-commits
tstellar wrote: Any other comments on this one? If not, I think I'll merge it after the dev meeting. https://github.com/llvm/llvm-project/pull/111625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-09 Thread Tom Stellard via cfe-commits
@@ -0,0 +1,2 @@ +RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir -DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang -DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release tstellar wrote: The current bolt.lit.cfg substitutes `%clang_cpp` to `

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/111625 >From 40efbcf0fd348625c892453d915eb7601adda917 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 5 Oct 2024 17:17:33 + Subject: [PATCH 1/2] [Clang][perf-training] Do build of libLLVMSupport for perf t

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-09 Thread Tom Stellard via cfe-commits
tstellar wrote: > I'm assuming you used instrumented BOLT here? Also, do you have numbers on > how long the perf training took? Yes, it was instrumented BOLT. I've added the perf training times to the commit summary. https://github.com/llvm/llvm-project/pull/111625 _

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/111625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/111625 This adds a build of the libLLVMSupport to the lit suite that is used for generating profile data. This helps to improve both PGO and BOLT optimization of clang over the existing hello world training program.

[clang] [clang-shlib] Add symbol versioning to all symbols (PR #110758)

2024-10-01 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/110758 We do the same thing for libLLVM.so. This should help avoid issues when an applications loads two different versions of the library at the same time. >From 59673ed97d92df34d6f662da5a51f6e28806b5af Mon Sep 17

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-10-01 Thread Tom Stellard via cfe-commits
tstellar wrote: @keith Yes, this change needs to be in the release branch or it won't take effect. https://github.com/llvm/llvm-project/pull/109909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-30 Thread Tom Stellard via cfe-commits
@@ -109,3 +109,6 @@ set_final_stage_var(LLVM_ENABLE_PROJECTS "${LLVM_RELEASE_ENABLE_PROJECTS}" STRIN set_final_stage_var(CPACK_GENERATOR "TXZ" STRING) set_final_stage_var(CPACK_ARCHIVE_THREADS "0" STRING) +if(${CMAKE_HOST_SYSTEM_NAME} MATCHES "Darwin") + set_final_stage_var(

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-30 Thread Tom Stellard via cfe-commits
tstellar wrote: If you add these 3 options to the cmake invocation in release-binaries.yml, it should give us more verbose output and make the problem easier to debug: ``` -DCMAKE_VERBOSE_MAKEFILE=ON \ -DBOOTSTRAP_CMAKE_VERBOSE_MAKEFILE=ON \ -DBOOTSTRAP_BOOTSTRAP_CMAKE_V

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-30 Thread Tom Stellard via cfe-commits
tstellar wrote: You want to be downloading and testing this artifact: ![image](https://github.com/user-attachments/assets/d0e5963d-34a3-42fe-b1db-15b83750da3b) https://github.com/llvm/llvm-project/pull/109909 ___ cfe-commits mailing list cfe-commits@

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-28 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. This looks good to me. It looks like we need to add the Release.cmake file to the list of files that trigger the release-binaries-all test, but that can be done in another PR. https://github.com/llvm/llvm-project/pull/109909

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/108488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/108488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [perf-training] Fix dependencies when using -DCLANG_PGO_TRAINING_DATA_SOURCE_DIR (PR #108488)

2024-09-12 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/108488 The generate-profraw-external target needs to be built after clang, but this was not modeled correctly in the CMake dependencies. The new dependency ordering ensures that clang is built before generate-prof

[clang] [libclc] [llvm] [libclc] More cross compilation fixes (PR #97811)

2024-09-03 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/97811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-28 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick 8927576b8f6442bb6129bda597efee46176f8aec https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-28 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-28 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-14 Thread Tom Stellard via cfe-commits
tstellar wrote: I'm going to push this tomorrow so it has a chance to land before -rc3. https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-09 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/101344 >From a39c6d5e3decabab87ff9360851981123ff962d7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 31 Jul 2024 07:36:48 -0700 Subject: [PATCH 1/5] workflows/release-binaries: Enable flang builds on Windows

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-09 Thread Tom Stellard via cfe-commits
@@ -47,11 +47,17 @@ set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "") set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "") set(STAGE1_PROJECTS "clang") -set(STAGE1_RUNTIMES "") + +# Building Flang on Windows requires compiler-rt, so we need to build it in +# stage1. compiler-rt is al

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/101344 >From a39c6d5e3decabab87ff9360851981123ff962d7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 31 Jul 2024 07:36:48 -0700 Subject: [PATCH 1/4] workflows/release-binaries: Enable flang builds on Windows

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-08 Thread Tom Stellard via cfe-commits
tstellar wrote: It looks like this change also fixed some build failures on macOS too. https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/101344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Enable flang builds on Windows (PR #101344)

2024-08-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/101344 >From a39c6d5e3decabab87ff9360851981123ff962d7 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 31 Jul 2024 07:36:48 -0700 Subject: [PATCH 1/3] workflows/release-binaries: Enable flang builds on Windows

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/98431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-26 Thread Tom Stellard via cfe-commits
tstellar wrote: Only 2 (linux x86 and macOS AArch64) of the 4 configurations are passing currently, but I still think it makes sense to merge this so we can start building binaries for 19.1.0-rc1. I can work on fixing the other configurations in a follow up patch. https://github.com/llvm/ll

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-25 Thread Tom Stellard via cfe-commits
tstellar wrote: I think that the `GetResourcesPath` function is incorrect. There's no reason it should return a wrong value, since the CLANG_RESOURCE_DIR value is always known at compile time. https://github.com/llvm/llvm-project/pull/97197 ___ cfe-

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-25 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/98431 >From 5417784c025128eaffc09981ee72c7cc2ba487b3 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 22 May 2024 15:30:53 -0700 Subject: [PATCH 1/4] Build release binaries for multiple targets This adds releas

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-25 Thread Tom Stellard via cfe-commits
@@ -0,0 +1,55 @@ +name: Setup Stage + +inputs: + previous-artifact: +description: >- + A unique descriptor for the artifact from the previous stage. This will + be used to construct the final artifact pattern, which is: + $RUNNER_OS-$RUNNER_ARCH-$PREVIOUS_ARTI

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-12 Thread Tom Stellard via cfe-commits
tstellar wrote: Summary of the test failures: [AArch64 MacOS](https://github.com/llvm/llvm-project/actions/runs/9893093291/job/27346084277?pr=98431): ``` ld64.lld: error: undefined symbol: __divsc3 >>> referenced by lib/libFortranRuntime.a(complex-powi.cpp.o):(symbol float >>> complex tgpowi

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-11 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/98431 >From 5417784c025128eaffc09981ee72c7cc2ba487b3 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 22 May 2024 15:30:53 -0700 Subject: [PATCH 1/2] Build release binaries for multiple targets This adds releas

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-10 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/98431 This adds release binary builds for the 4 platforms currently supported by the free GitHub Action runners: * Linux x86_64 * Windows x86_64 * Mac x86_64 * Mac AArch64 The test stages for these are known to fail

[libclc] [libclc] Fix cross in-tree builds (PR #97392)

2024-07-02 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/97392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-06-10 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/92591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-06-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-06-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/90138 >From 0d0484ac99affdc8ccb9bc3a1eff827cf996c51c Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 24 Apr 2024 07:54:41 -0700 Subject: [PATCH 1/3] [CMake][Release] Use the TGZ cpack generator for binaries --

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-05-28 Thread Tom Stellard via cfe-commits
tstellar wrote: Ping. https://github.com/llvm/llvm-project/pull/92591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. This seems OK to me at first glance. You may want to have someone double-checkout those new libcxx jobs. I'm not really familiar with those. https://github.com/llvm/llvm-project/pull/93318 ___

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Tom Stellard via cfe-commits
@@ -178,6 +194,15 @@ function check-targets() { cross-project-tests) echo "check-cross-project" ;; +libcxx) + echo "check-cxx" +;; +libcxxabi) + echo "check-cxxabi" +;; +libunwind) + echo "check-unwind" tstellar

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Tom Stellard via cfe-commits
https://github.com/tstellar commented: Can we also delete https://github.com/llvm/llvm-project/blob/main/clang/utils/ci/buildkite-pipeline.yml https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Tom Stellard via cfe-commits
@@ -178,6 +194,15 @@ function check-targets() { cross-project-tests) echo "check-cross-project" ;; +libcxx) + echo "check-cxx" +;; +libcxxabi) + echo "check-cxxabi" +;; +libunwind) + echo "check-unwind" tstellar

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-05-24 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. LGTM. Thanks, this should help free up some builder resources. https://github.com/llvm/llvm-project/pull/93233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang][ci] Remove unnecessary BuildKite jobs for Clang (PR #93233)

2024-05-23 Thread Tom Stellard via cfe-commits
https://github.com/tstellar commented: If we aren't running the tests any more, can we build clang with `-DLLVM_TARGETS_TO_BUILD=Native` https://github.com/llvm/llvm-project/pull/93233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-05-22 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-05-22 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/92591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-05-20 Thread Tom Stellard via cfe-commits
tstellar wrote: > Did you consider the parallel setting as well? Forgot about that part, I will make that change too. https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] Disable compiling Flang and running its tests on Clang changes (PR #92740)

2024-05-20 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. LGTM, thank you. https://github.com/llvm/llvm-project/pull/92740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Disable compiling Flang and running its tests on Clang changes (PR #92740)

2024-05-20 Thread Tom Stellard via cfe-commits
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer { *sema.LateParsedTemplateMap.find(FD)->second; sema.LateTemplateParser(sema.OpaqueParser, LPT); llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() << "\"\n"; -} +

[clang] [llvm] Disable compiling Flang and running its tests on Clang changes (PR #92740)

2024-05-20 Thread Tom Stellard via cfe-commits
@@ -68,7 +68,7 @@ function compute-projects-to-test() { done ;; clang) - for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do + for p in clang-tools-extra compiler-rt lldb cross-project-tests; do tstellar wrote: Don

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-05-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-05-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar edited https://github.com/llvm/llvm-project/pull/92591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-05-17 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/92591 This fixes two problems with the 2-stage PGO builds. The first problem was that the stage2-instrumented and stage2 targets would not be built on the second ninja invocation. For example: # This would work a

[clang] [llvm] [X86][Driver] Do not add `-evex512` for `-march=native` when the target doesn't support AVX512 (PR #91694)

2024-05-13 Thread Tom Stellard via cfe-commits
tstellar wrote: @phoebewang Can you add a release note for this on the PR for the release branch and then add the release:note label. https://github.com/llvm/llvm-project/pull/91694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-05-11 Thread Tom Stellard via cfe-commits
tstellar wrote: This was merged in another PR: b7e2397c54b7cddac8fa188e68073f78e895a57a. https://github.com/llvm/llvm-project/pull/90139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread Tom Stellard via cfe-commits
tstellar wrote: Two questions: * Did you use a script to generate this patch? * Why do we need to make this change? https://github.com/llvm/llvm-project/pull/91856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-04-27 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick 53ff002c6f7ec64a75ab0990b1314cc6b4bb67cf https://github.com/llvm/llvm-project/pull/90139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-04-27 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/90139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-04-27 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/90139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-04-25 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/90139 Set this in the cache file directly instead of via the test-release.sh script so that the release builds can be reproduced with just the cache file. >From 67f3d1ede686758238bb37a2ea50790750f7693f Mon Sep 17 00:

[clang] [CMake][Release] Use the TGZ cpack generator for binaries (PR #90138)

2024-04-25 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/90138 None >From 0d0484ac99affdc8ccb9bc3a1eff827cf996c51c Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 24 Apr 2024 07:54:41 -0700 Subject: [PATCH] [CMake][Release] Use the TGZ cpack generator for binaries

[clang] [CMake][Release] Refactor cache file and use two stages for non-PGO builds (PR #89812)

2024-04-25 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/89812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Refactor cache file and use two stages for non-PGO builds (PR #89812)

2024-04-25 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/89812 >From 275979816a1de8b16a6c45b5ee2ef4e73c8828ba Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 23 Apr 2024 19:29:04 + Subject: [PATCH] [CMake][Release] Refactor cache file and use two stages for non-

[clang] [CMake][Release] Refactor cache file and use two stages for non-PGO builds (PR #89812)

2024-04-25 Thread Tom Stellard via cfe-commits
tstellar wrote: I've been testing this with #89521. https://github.com/llvm/llvm-project/pull/89812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Add stage2-package target (PR #89517)

2024-04-24 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/89517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Refactor cache file and use two stages for non-PGO builds (PR #89812)

2024-04-23 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/89812 Completely refactor the cache file to simplify it and remove unnecessary variables. The main functional change here is that the non-PGO builds now use two stages, so `ninja -C build stage2-package` can be used

  1   2   3   4   5   >