ffmpeg | branch: master | Scott Theisen | Sat Dec 14
16:49:16 2024 -0500| [8ad2d1919fdf8a33f72761799367293bbb379b55] | committer:
Marth64
libavcodec/mpeg12dec: append CC data to a53_buf_ref
In mpeg_decode_a53_cc() only the A/53 part 4 CC data ("GA94") is saved between
frames.
ffmpeg | branch: master | Scott Theisen | Wed Dec 18
16:59:53 2024 -0500| [9da1d2e66ab1ac9dcfaa290bbea78b2a4900ac0a] | committer:
Zhao Zhili
libavcodec/v4l2_buffers.c: set AVFrame interlaced flags
Originally from:
https://github.com/MythTV/mythtv/commit
Originally from:
https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749
---
v3:
remove unnecessary clearing of already 0 valued flags
use switch-case; I don't really think it is any simpler, but I do like the
format better.
---
libavcodec/v4l2_buffers.c | 19 ++
Originally from:
https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749
---
libavcodec/v4l2_buffers.c | 20
1 file changed, 20 insertions(+)
diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c
index 23474ee143..85dfb40093 100644
--- a/
On 12/17/24 11:10, Zhao Zhili wrote:
On Dec 17, 2024, at 06:48, Scott Theisen wrote:
On 12/15/24 22:15, Zhao Zhili wrote:
On Dec 15, 2024, at 12:14, Scott Theisen wrote:
Based on patches by Lukas Rusak from
https://github.com/lrusak/FFmpeg/commits/v4l2-drmprime-v4
libavcodec: v4l2m2m
On 12/15/24 22:15, Zhao Zhili wrote:
On Dec 15, 2024, at 12:14, Scott Theisen wrote:
Based on patches by Lukas Rusak from
https://github.com/lrusak/FFmpeg/commits/v4l2-drmprime-v4
libavcodec: v4l2m2m: output AVDRMFrameDescriptor
https://github.com/lrusak/FFmpeg/commit
On 12/16/24 15:25, James Almer wrote:
On 12/16/2024 5:05 PM, Scott Theisen wrote:
On 12/15/24 22:25, James Almer wrote:
On 12/15/2024 1:14 AM, Scott Theisen wrote:
Originally from:
https://github.com/MythTV/mythtv/
commit/669955c6cb29196b4b5120451b5b998d67a65749
---
libavcodec
On 12/15/24 22:25, James Almer wrote:
On 12/15/2024 1:14 AM, Scott Theisen wrote:
Originally from:
https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749
---
libavcodec/v4l2_buffers.c | 38 ++
1 file changed, 38 insertions
Based on patches by Lukas Rusak from
https://github.com/lrusak/FFmpeg/commits/v4l2-drmprime-v4
libavcodec: v4l2m2m: output AVDRMFrameDescriptor
https://github.com/lrusak/FFmpeg/commit/2cb8052ac65a56d8a3f347a1e6f12d4449a5a614
libavcodec: v4l2m2m: depends on libdrm
https://github.com/lrusak/FFmpeg/
Originally from:
https://github.com/MythTV/mythtv/commit/669955c6cb29196b4b5120451b5b998d67a65749
---
libavcodec/v4l2_buffers.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c
index 23474ee143..56a8f0
The packet starts 'IVT0' or 'ivt0'; for more details see
https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
'I' = 0x49, 'i' = 0x69
---
libavformat/mpeg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
inde
---
doc/APIchanges | 3 +++
libavcodec/codec_desc.c | 6 ++
libavcodec/codec_id.h | 1 +
libavcodec/version.c| 2 +-
4 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index b9af3de933..8fc55ad80b 100644
--- a/doc/APIchanges
+++ b/doc/
In mpeg_decode_a53_cc() only the A/53 part 4 CC data ("GA94") is saved between
frames. The other formats incorrectly created a larger buffer than they use
since a705bcd763e344fac191e157ffeddc285388b7fa because they did not append to
the previous data.
A/53 and SCTE-20 specify a maximum of one CC
t *cap`
when you are setting up the final payload.
This makes it more consistent with the other sections.
I had thought about consistency, but I really didn't like the name
`cap`. However, I suppose it is short for `captions`, so I will also
use `cap` for better consistency.
Regards,
Sc
On 12/14/24 04:12, Anton Khirnov wrote:
Quoting Scott Theisen (2024-12-14 04:06:45)
On 12/13/24 17:39, Marth64 wrote:
Hi Scott,
Thanks for sharing this. I had read your original email also
([RFC] libavcodec/mpeg12dec.c: CC data from skipped frames)
and was thinking about the statement. The
The packet starts 'IVT0' or 'ivt0'; for more details see
https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
'I' = 0x49, 'i' = 0x69
---
libavformat/mpeg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
inde
---
libavcodec/codec_desc.c | 6 ++
libavcodec/codec_id.h | 1 +
libavcodec/version.c| 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
index bc9163bf98..38aed994d9 100644
--- a/libavcodec/codec_desc.c
+++ b/libavcodec/
d
AV_CHANNEL_ORDER_CUSTOM for dual mono).
Regards,
Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
open GOP), it seemed easiest to
concatenate
the CC data like the A/53 code does.
Regards,
Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmp
In mpeg_decode_a53_cc() only the A/53 part 4 CC data ("GA94") is saved between
frames. The other formats incorrectly created a larger buffer than they use
since a705bcd763e344fac191e157ffeddc285388b7fa because they did not append to
the previous data.
A/53 and SCTE-20 specify a maximum of one CC
From: ulmus-scott
Defined in ISO/IEC 11172-3 and ISO/IEC 13818-3 as:
dual channel mode [audio]: A mode, where two audio channels with independent
programme contents (e.g. bilingual) are encoded within one bitstream. The
coding process is the same as for the stereo mode.
There is currently no way
On 12/12/24 01:41, Anton Khirnov wrote:
Quoting Scott Theisen (2024-12-10 21:42:06)
On 12/9/24 02:31, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-30 08:38:54)
On 11/25/24 00:42, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-14 05:37:49)
@@ -85,7 +85,13 @@ static int
On 12/10/24 19:16, James Almer wrote:
On 12/10/2024 9:06 PM, Scott Theisen wrote:
On 12/9/24 02:30, Anton Khirnov wrote:
Quoting James Almer (2024-11-30 14:41:20)
On 11/14/2024 1:37 AM, Scott Theisen wrote:
When attempting to upstream this MythTV change in September 2022,
it was recommended
On 12/9/24 02:30, Anton Khirnov wrote:
Quoting James Almer (2024-11-30 14:41:20)
On 11/14/2024 1:37 AM, Scott Theisen wrote:
When attempting to upstream this MythTV change in September 2022, it was
recommended to
use AV_CHANNEL_ORDER_CUSTOM with two AV_CHAN_FRONT_CENTER channels. See
https
On 12/8/24 17:04, Marton Balint wrote:
On Sun, 8 Dec 2024, Scott Theisen wrote:
On 12/3/24 17:23, Marton Balint wrote:
On Tue, 3 Dec 2024, Marton Balint wrote:
On Sat, 30 Nov 2024, Scott Theisen wrote:
DVB VBI data is defined in ETSI EN 301 775 and can include EBU
teletext
data
as
make: *** [Makefile:142: ffplay_g] Error 1
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:142: ffmpeg_g] Error 1
thx
ff_* symbols are not exported and are internal to each library. Some of
the o
On 12/9/24 02:31, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-30 08:38:54)
On 11/25/24 00:42, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-14 05:37:49)
@@ -85,7 +85,13 @@ static int mpegaudio_parse(AVCodecParserContext *s1,
if (s->header_co
On 12/3/24 17:23, Marton Balint wrote:
On Tue, 3 Dec 2024, Marton Balint wrote:
On Sat, 30 Nov 2024, Scott Theisen wrote:
DVB VBI data is defined in ETSI EN 301 775 and can include EBU
teletext
data
as defined in ETSI EN 300 472.
ETSI EN 300 468 defines teletext_descriptor
ffmpeg | branch: master | Scott Theisen | Sun Dec 1
00:14:13 2024 -0500| [1259760825acd89a3dabef5ef6b30e13f2252f14] | committer:
Marton Balint
avformat/mpegts*: reduce use of magic numbers
Note ISO/IEC 13818-1 defines an Extension_descriptor with descriptor_tag value
0x3f (63), so I kept the
ffmpeg | branch: master | Scott Theisen | Sun Dec 1
00:14:14 2024 -0500| [5ba63f0ef1ea756400283ffc6d34d360c636ba7a] | committer:
Marton Balint
avformat/mpegts: is_pes_stream() use switch case
also add STREAM_TYPE_PRIVATE_SECTION since a private_section() is not a
PES_packet().
Signed-off-by
the slices are skipped? (If so, the CC data
should be added to that frame.)
Should the CC data be preserved between the frames for all formats?
Thanks,
Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailma
also add STREAM_TYPE_PRIVATE_SECTION since a private_section() is not a
PES_packet().
---
libavformat/mpegts.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index b4bf70bcbf..e470f12d22 100644
--- a/libavformat/mpegt
Note ISO/IEC 13818-1 defines an Extension_descriptor with descriptor_tag value
0x3f (63), so I kept the DVB comment.
I don't know what defines stream_type value 0x8a as DTS.
I don't have any Blu-ray standards so I don't know where those stream_type
values are defined.
---
libavformat/mpegts.c
DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext data
as defined in ETSI EN 300 472.
ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and
VBI_teletext_descriptor, which has the same definition as, but different use
from, teletext_descriptor.
---
libavcodec/
On 11/25/24 00:42, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-14 05:37:49)
@@ -85,7 +85,13 @@ static int mpegaudio_parse(AVCodecParserContext *s1,
if (s->header_count > header_threshold) {
avctx->sample
On 11/24/24 13:17, Marton Balint wrote:
On Fri, 22 Nov 2024, Scott Theisen wrote:
On 11/22/24 16:12, Marton Balint wrote:
On Fri, 15 Nov 2024, Scott Theisen wrote:
From: ulmus-scott
DVB VBI data is defined in ETSI EN 301 775 and can include EBU
teletext
data
as defined in ETSI
On 11/28/24 10:07, Anton Khirnov wrote:
Quoting Scott Theisen (2024-11-14 06:52:05)
I don't know if any of these are still necessary since I have reduced MythTV's
modifications to FFmpeg and replaced all uses of internal functions.
All of these look quite suspicious to me - the f
ffmpeg | branch: master | Scott Theisen | Thu Nov 21
02:54:08 2024 -0500| [78c4d6c136e10222a0b0ddff639c836f295a9029] | committer:
Marth64
libavcodec/mpeg12dec.c: support DVB CC format 0x0502 in user_data
Reviewed-by: Marth64
Signed-off-by: Marth64
> http://git.videolan.org/gitweb.
On 11/22/24 16:12, Marton Balint wrote:
On Fri, 15 Nov 2024, Scott Theisen wrote:
From: ulmus-scott
DVB VBI data is defined in ETSI EN 301 775 and can include EBU
teletext data
as defined in ETSI EN 300 472.
ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and
ffmpeg | branch: master | Scott Theisen | Fri Nov 15
00:48:22 2024 -0500| [0dceced45c52acc773e690a7aa7ff2e3fb8c560b] | committer:
Marton Balint
avformat/mpegts: add DVB descriptor_tag values already in use
Signed-off-by: Marton Balint
> http://git.videolan.org/gitweb.cgi/ffmpeg.git
On 11/21/24 02:49, Scott Theisen wrote:
On 11/21/24 01:52, Marth64 wrote:
Can the naming/comment in the code be changed to “DVB 0502”, DVB_0502,
etc.? In this way it is not referencing a particular provider and in the
future other if other custom DVB EIA608 techniques are supported (it is
Originally from:
Fixes #2481, by applying patch from kenny at the-b org. This adds dec…
https://github.com/MythTV/mythtv/commit/49d3294c9a4ef20a699c2bb2da08f33b294c86b3
Referencing:
Trac #2481 (Closed Captioning contained in MPEG user data fields) – MythTV
https://code.mythtv.org/trac/ticket/2481
On 11/21/24 01:52, Marth64 wrote:
Can the naming/comment in the code be changed to “DVB 0502”, DVB_0502,
etc.? In this way it is not referencing a particular provider and in the
future other if other custom DVB EIA608 techniques are supported (it is
possible there is more), they can be named simi
Originally from:
Fixes #2481, by applying patch from kenny at the-b org. This adds dec…
https://github.com/MythTV/mythtv/commit/49d3294c9a4ef20a699c2bb2da08f33b294c86b3
Referencing:
Trac #2481 (Closed Captioning contained in MPEG user data fields) – MythTV
https://code.mythtv.org/trac/ticket/2481
ffmpeg | branch: master | Scott Theisen | Thu Nov 14
14:57:01 2024 -0500| [be784e95ac5cd720fb0da0f13841b0fdf4f90391] | committer:
Marton Balint
avformat/mpegts: add support for ATSC E-AC-3 streams
ATSC A/52:2018 Digital Audio Compression (AC-3, E-AC-3), Annex G
defines stream_type 0x87 for E
On 11/16/24 01:56, Rémi Denis-Courmont wrote:
Le perjantaina 15. marraskuuta 2024, 22.09.25 EET Scott Theisen a écrit :
On 11/15/24 08:47, Rémi Denis-Courmont wrote:
Le 15 novembre 2024 12:56:23 GMT+02:00, Zhao Zhili
a écrit :
From: Zhao Zhili
_Alignas is portable than compiler's spe
On 11/15/24 08:47, Rémi Denis-Courmont wrote:
Le 15 novembre 2024 12:56:23 GMT+02:00, Zhao Zhili a
écrit :
From: Zhao Zhili
_Alignas is portable than compiler's specific __attribute__. It do
have a limitation, that _Alignas don't support specify aligment on
the declarations of struct (it wo
From: ulmus-scott
DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext data
as defined in ETSI EN 300 472.
ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and
VBI_teletext_descriptor, which has the same definition as, but different use
from, teletext_descript
These changes are originally from MythTV.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
---
libavformat/mpegts.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h
index 14ae312c50..729c8b07b9 100644
--- a/libavformat/mpegts.h
+++ b/libavformat/mpegts.h
@@ -165,6 +165,17 @@
#define METADATA_DESCRIPTOR 0x26
#define M
originally from:
https://github.com/MythTV/mythtv/commit/a1d4d112c3f962a85ddd6248592421171fc8331c
referencing:
https://code.mythtv.org/trac/ticket/1887
ISO/IEC 13818-1:2021 specifies a valid range of [0x0010, 0x1FFE] in
§ 2.4.4.6 Semantic definition of fields in program association section
and Tab
ATSC A/52:2018 Digital Audio Compression (AC-3, E-AC-3), Annex G
defines stream_type 0x87 for E-AC-3 bit streams.
---
libavformat/mpegts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 78ab7f7efe..177e610e53 100644
--- a/libavformat/mpegts.c
These changes are from MythTV.
I don't know if the change to AVSubtitleRect breaks the API.
Regards,
Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit
From: Isaac Richards
from:
If a dvbsub palette is transparent, force it to be black. Fixes color creep on
the one DVB sample I have.
https://github.com/MythTV/mythtv/commit/e7fdb7a3a7f1bcf2fb54a1fc186243ee07db509b
---
libavcodec/dvbsubdec.c | 5 +++
tests/ref/fate/sub-dvb | 72
From: Mark Kendall
from
https://github.com/MythTV/mythtv/commit/14bea9593c44a8cd4c7c60bb6c0e1c85147ceb07
references https://code.mythtv.org/trac/ticket/8061
---
libavcodec/avcodec.h | 4
libavcodec/dvbsubdec.c | 20
2 files changed, 16 insertions(+), 8 deletions(-)
I don't know if any of these are still necessary since I have reduced MythTV's
modifications to FFmpeg and replaced all uses of internal functions.
Regards,
Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://
originally from
https://github.com/MythTV/mythtv/commit/1a9ae8fa0665b1c8928974f9a2176eb3aa27a7e5
---
libavformat/demux.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/demux.c b/libavformat/demux.c
index de792ceb3f..cbb8e37d45 100644
--- a/libavformat/demux.c
+++ b/libavformat
originally from:
https://github.com/MythTV/mythtv/commit/c94d503eaef122566e88af200d5079353faf856b
https://github.com/MythTV/mythtv/commit/3702a35152fc1e63c04fbc514b96dff21f8b3468
---
libavformat/demux.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/demux.c b/libavformat/demux.
from
https://github.com/MythTV/mythtv/commit/28d2b3e87763c6102d20cfe959547b1a5f5cd609
---
libavformat/demux.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/demux.c b/libavformat/demux.c
index cba1f2e4df..b4fa7f912d 100644
--- a/libavformat/demux.c
+++ b/libavformat/demux.c
@
Originally from:
Fixes #2481, by applying patch from kenny at the-b org. This adds dec…
https://github.com/MythTV/mythtv/commit/49d3294c9a4ef20a699c2bb2da08f33b294c86b3
Referencing:
Trac #2481 (Closed Captioning contained in MPEG user data fields) – MythTV
https://code.mythtv.org/trac/ticket/2481
ISO/IEC 13818-1:2021 Table 2-34 – Stream type assignments
defines 0x11 as ISO/IEC 14496-3 Audio with the LATM transport syntax as defined
in ISO/IEC 14496-3. This table applies to both Transport Streams and Program
Streams.
---
libavformat/mpeg.c | 3 +++
libavformat/mpeg.h | 1 +
2 files changed
From: Peter Bennett
With 1080i MPEG2 video, amazon fire stick uses a different stride from what
is returned.
---
libavcodec/mediacodecdec_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/mediacodecdec_common.c
b/libavcodec/mediacodecdec_common.c
index 84c34ac270..b739a4
From: Janne Grunau
this silences the "number of reference frames exceeds max
(probably corrupt input), discarding one" message
in the uninteresting cases, i.e. after seeking, playback start
originally from:
https://github.com/MythTV/mythtv/commit/53257097eb6c1fd4259d20bc92f8820a023ec953
referen
When attempting to upstream this MythTV change in September 2022, it was
recommended to
use AV_CHANNEL_ORDER_CUSTOM with two AV_CHAN_FRONT_CENTER channels. See
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220921192611.3241-1-scott.the@gmail.com/
---
libavcodec/audiotoolboxdec.c| 4
Ping for review.
Thanks in advance,
Scott Theisen
On 11/13/22 18:19, Scott Theisen wrote:
Ping for review.
On 9/17/22 13:08, Scott Theisen wrote:
These changes are from MythTV.
---
The `AV_CODEC_ID`s are probably in the wrong place since these are
data codecs, but that is where they are In
Ping for review.
On 9/17/22 13:08, Scott Theisen wrote:
These changes are from MythTV.
---
The `AV_CODEC_ID`s are probably in the wrong place since these are
data codecs, but that is where they are In MythTV.
There was also a related change to libavformat/demux.c's
avformat_find_stream
On 9/22/22 08:43, Anton Khirnov wrote:
Quoting Scott Theisen (2022-09-22 03:04:16)
On 9/21/22 15:51, James Almer wrote:
On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote:
Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a
écrit :
diff --git a/libavcodec/avcodec.h b/libavcodec
On 9/22/22 10:59, Anton Khirnov wrote:
Quoting Scott Theisen (2022-09-16 19:41:43)
Ping; it still applies cleanly.
Missing motivation for this change. Is it faster, or why is the new code
better?
To make it easier to read. `buf_end` is shorter than `frag->data +
frag->dat
On 9/21/22 15:51, James Almer wrote:
On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote:
Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a
écrit :
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 7db5d1b1c5..bcf3a845a8 100644
--- a/libavcodec/avcodec.h
+++ b
From: ulmus-scott
The flag identifies two independant mono channels recorded as stereo.
This change has been kicking around in the MythTV modifications since 2006.
See
https://github.com/MythTV/mythtv/commit/435540c9e8ac245ceca968791c67431f37c8d617
I have changed the names and comment. For the
On 9/19/22 16:58, Hendrik Leppkes wrote:
On Mon, Sep 19, 2022 at 10:53 PM Andreas Rheinhardt
wrote:
Scott Theisen:
This is from the following MythTV commits:
libavcodec: add support for detecting forced subtitle segments.
https://github.com/MythTV/mythtv/commit
This is from the following MythTV commits:
libavcodec: add support for detecting forced subtitle segments.
https://github.com/MythTV/mythtv/commit/5099f1a5777966fba482b623e581c1eef5c8fc09
This adds forced subtitle segment detection to the PGS subtitle decoder and
copies the result to AVSubtitle.
These changes are from MythTV.
---
The `AV_CODEC_ID`s are probably in the wrong place since these are
data codecs, but that is where they are In MythTV.
There was also a related change to libavformat/demux.c's
avformat_find_stream_info() trying to optimize it for MHEG streams,
but it is unnecessa
Ping. Still applies cleanly.
On 5/15/22 16:18, Scott Theisen wrote:
switch-case over es_type and then perform a linear search over
startcode.
---
This version doesn't use stdbool.h but is otherwise identical.
libavformat/mpeg.c | 213 +++--
1
On 9/16/22 14:19, Scott Theisen wrote:
My modified versions of avpriv_find_start_code were accepted into MythTV,
which caused clang-tidy to raise a bugprone-branch-clone warning. The
for loop's if statement has therefore been modified to not duplicate
This should say while loop.
the b
The input/output functionality was used by only
(ff_)mpeg1_find_frame_end().
If the state/start_code input is a local variable and only one buffer is used,
then no history is needed.
In loops and inline functions: if ignoring history, don't initialize start_code,
so it isn't reset twice each time
Have the compiler enforce not changing the addresses these parameters point to.
No functional change.
---
libavcodec/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 63bf4b8cb7..0635c5dcaa 100644
--- a/libavcodec/utils.c
---
libavcodec/mpeg12dec.c | 2 +-
libavformat/rtpenc_mpv.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index b857353ab8..6a7af91fad 100644
--- a/libavcodec/mpeg12dec.c
+++ b/libavcodec/mpeg12dec.c
@@ -1746,7 +1746,7 @@
---
libavcodec/startcode.h | 26 +-
libavcodec/utils.c | 10 +-
2 files changed, 30 insertions(+), 6 deletions(-)
diff --git a/libavcodec/startcode.h b/libavcodec/startcode.h
index 833754af09..69389c729c 100644
--- a/libavcodec/startcode.h
+++ b/libavcodec/star
---
libavcodec/utils.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index fc8cd87366..83f7d8a01a 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -983,18 +983,20 @@ const uint8_t *avpriv_find_start_code(const
The expected number of iterations may increase by one for an input
of alternating 0 and 1 bytes. Instead of incrementing by 2 everytime,
it now alternates between incrementing by 1 and by 3.
For the check p[-2] != 0:
This slightly reduces the number of iterations by starting with three
new bytes
No functional change.
---
libavcodec/utils.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 2f57418ff7..d6ab21b1a0 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1006,10 +1006,11 @@ const uint8_t *avpriv_find
This slightly changes what is considered valid in the following cases:
cavsdec.c: 0x00XX is now considered invalid.
mpeg12dec.c: 0x00XX is now considered invalid.
(where X is any value)
IS_MARKER is equivalent since VC1_CODE_RES0 = 0x0100
---
libavcodec/cavsdec.c | 2
My modified versions of avpriv_find_start_code were accepted into MythTV,
which caused clang-tidy to raise a bugprone-branch-clone warning. The
for loop's if statement has therefore been modified to not duplicate
the branch payload.
There are no other changes from v3.
Regards,
Scott Th
Ping; it still applies cleanly.
-Scott Theisen
On 5/15/22 14:50, Scott Theisen wrote:
Ping; it still applies cleanly.
-Scott Theisen
On 2/8/22 15:32, Scott Theisen wrote:
Also add a few clarifying comments.
---
libavcodec/cbs_mpeg2.c | 16
1 file changed, 8 insertions
printf %s with a NULL pointer is undefined behavior. Not returning
a NULL pointer makes for a nicer function for API users, including
in FFmpeg, since then you don't have to check it, instead you can
just print it. 32/44 uses in FFmpeg did not check for NULL.
This also matches behavior with avco
printf %s with a NULL pointer is undefined behavior. Not returning
a NULL pointer makes for a nicer function for API users, including
in FFmpeg, since then you don't have to check it, instead you can
just print it. 32/44 uses in FFmpeg did not check for NULL.
This also matches behavior with avco
switch-case over es_type and then perform a linear search over
startcode.
---
This version doesn't use stdbool.h but is otherwise identical.
libavformat/mpeg.c | 213 +++--
1 file changed, 130 insertions(+), 83 deletions(-)
diff --git a/libavformat/mpeg.c
printf %s with a null pointer is undefined behavior.
---
doc/examples/demuxing_decoding.c | 10 +-
doc/examples/extract_mvs.c | 4 ++--
fftools/ffmpeg.c | 12 ++--
fftools/ffmpeg_mux.c | 2 +-
fftools/ffmpeg_opt.c | 2 +-
fftools/ffp
This deprecates av_get_media_type_string() which does return NULL.
printf %s with a null pointer is undefined behavior
This also matches behavior with avcodec_get_name() which never returns NULL,
instead it returns "unknown_codec".
---
doc/APIchanges | 3 +++
libavutil/avutil.h | 10 +++
printf %s with NULL is undefined behavior.
This version adds #include "attributes.h" for -Wdeprecated-declarations.
-Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To u
Ping; it still applies cleanly.
-Scott Theisen
On 2/8/22 15:32, Scott Theisen wrote:
Also add a few clarifying comments.
---
libavcodec/cbs_mpeg2.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c
index
On 2/8/22 22:28, Scott Theisen wrote:
I have removed most of my added comments.
Rebased to account for Andreas Rheinhardt moving the prototype to
startcode.h.
Per his suggestion, the function signature is now unmodified.
(ff_)mpeg1_find_frame_end() now has a wrapper function preserving
the
s the AVCodecID of a stream
if it can't identify the codec. This is probably true of all demuxers.
-Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above
switch-case over es_type and then perform a linear search over
startcode.
---
libavformat/mpeg.c | 215 -
1 file changed, 132 insertions(+), 83 deletions(-)
diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
index ca15d9f241..c1b1c7e7de 100644
--- a/l
printf %s with a null pointer is undefined behavior.
---
doc/examples/demuxing_decoding.c | 10 +-
doc/examples/extract_mvs.c | 4 ++--
fftools/cmdutils.c | 7 +++
fftools/cmdutils.h | 2 --
fftools/ffmpeg.c | 14 +++---
ffto
This deprecates av_get_media_type_string() which does return NULL.
printf %s with a null pointer is undefined behavior
This also matches behavior with avcodec_get_name() which never returns NULL,
instead it returns "unknown_codec".
---
doc/APIchanges | 3 +++
libavutil/avutil.h | 7 +++
Identical to v2, but I reworded the second commit's message to add a context.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.
The input/output functionality was used by only
(ff_)mpeg1_find_frame_end().
If the state/start_code input is a local variable and only one buffer is used,
then no history is needed.
In loops and inline functions: if ignoring history, don't initialize start_code,
so it isn't reset twice each time
Have the compiler enforce not changing the addresses these parameters point to.
No functional change.
---
libavcodec/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 68d126acd8..d11d92d21e 100644
--- a/libavcodec/utils.c
1 - 100 of 152 matches
Mail list logo
