Re: [lldb-dev] [cfe-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator

Code review guidelines patch is available for review: https://reviews.llvm.org/D103811. -- Krzysztof Parzyszek kparz...@quicinc.com AI tools development From: David Blaikie Sent: Tuesday, May 18, 2021 3:01 PM To: Krzysztof Parzyszek Cc: llvm-dev ; clangd-...@l

Re: [lldb-dev] [cfe-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator

Post-commit reviews are conducted, in order of preference, on Phabricator, This still seems like a change in practice that I'm not in favor of, personally - due to the current divergence between email and phab review feedback. Yes, this would be one way to unify it - but I'm not sure it's necessa

[lldb-dev] [RFC] Deprecate pre-commit email code reviews in favor of Phabricator

This is a revision of the previous RFC[1]. This RFC limits the scope to pre-commit reviews only. Statement: Our current code review policy states[2]: "Code reviews are conducted, in order of preference, on our web-based code-review tool (see Code Reviews with Phabricator), by email on the r

Re: [lldb-dev] [cfe-dev] [RFC] Deprecate email code reviews in favor of Phabricator

You're right that doing post-commit reviews on Phabricator is not seamless---the rG link is not included anywhere. Hopefully that could be fixed with some Phabricator configuration tweaks, like sending the commit email to the -commits list. I'm not sure if there is a general fix for the spam i

Re: [lldb-dev] [llvm-dev] [RFC] Deprecate email code reviews in favor of Phabricator

I'm opposed to separating the pre- and post-commit reviews. One of the goals of this proposal is to have the entire review history in one place, and using a combination of email and Phabricator would prevent that. If I want to find out why a commit has been reverted, I have to search the post-

Re: [lldb-dev] [cfe-dev] [llvm-dev] [RFC] Deprecate email code reviews in favor of Phabricator

I'll defer to Christian the discussion about this section. +Christian -- Krzysztof Parzyszek  kparz...@quicinc.com   AI tools development -Original Message- From: cfe-dev On Behalf Of Kevin P. Neal via cfe-dev Sent: Monday, May 3, 2021 1:57 PM To: Krzysztof Parzyszek via llvm-dev Cc:

[lldb-dev] [RFC] Deprecate email code reviews in favor of Phabricator

Statement: Our current code review policy states[1]: "Code reviews are conducted, in order of preference, on our web-based code-review tool (see Code Reviews with Phabricator), by email on the relevant project's commit mailing list, on the project's development list, or on the bug tracker."