Author: Jonathan Roelofs
Date: 2020-03-12T09:59:28-06:00
New Revision: 2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5
URL:
https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5
DIFF:
https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5.di
Author: Jonathan Roelofs
Date: 2020-03-09T16:51:41-06:00
New Revision: 52bbdad7d63fd060d102b3591b433d116a982255
URL:
https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255
DIFF:
https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255.di
Author: Jonathan Roelofs
Date: 2020-03-09T16:27:35-06:00
New Revision: 2e9d33bccd587763fc284098b5cc60cfb9c25251
URL:
https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251
DIFF:
https://github.com/llvm/llvm-project/commit/2e9d33bccd587763fc284098b5cc60cfb9c25251.di
Author: Jonathan Roelofs
Date: 2020-03-09T16:11:35-06:00
New Revision: 698a12712920c214e39bb215fe26fad2e099425b
URL:
https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b
DIFF:
https://github.com/llvm/llvm-project/commit/698a12712920c214e39bb215fe26fad2e099425b.di
Author: Jonathan Roelofs
Date: 2020-03-09T15:54:32-06:00
New Revision: 1e0669bfe05f0f48ee88152c4a1d581f484f8d67
URL:
https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67
DIFF:
https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67.di
Author: Jonathan Roelofs
Date: 2020-03-09T12:14:22-06:00
New Revision: c71ef7a85d2447903ff9240aff649a57d70b050d
URL:
https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d
DIFF:
https://github.com/llvm/llvm-project/commit/c71ef7a85d2447903ff9240aff649a57d70b050d.di
Author: Jonathan Roelofs
Date: 2020-03-09T11:32:44-06:00
New Revision: 47caa69120e582bf1b795ec646f069c83b0e9456
URL:
https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456
DIFF:
https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456.di
Author: Jonathan Roelofs
Date: 2020-03-09T11:32:44-06:00
New Revision: 3486cc014b208df3897cf5656db0d0fdeae26d6b
URL:
https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b
DIFF:
https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b.di
Author: Jonathan Roelofs
Date: 2020-01-28T08:47:37-07:00
New Revision: 39fe44024689cf6d10b249db8694efbdcc6afc14
URL:
https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14
DIFF:
https://github.com/llvm/llvm-project/commit/39fe44024689cf6d10b249db8694efbdcc6afc14.di
Author: jroelofs
Date: Wed Jan 31 04:06:15 2018
New Revision: 323864
URL: http://llvm.org/viewvc/llvm-project?rev=323864&view=rev
Log:
Fix typo. NFC
Modified:
cfe/trunk/www/analyzer/scan-build.html
Modified: cfe/trunk/www/analyzer/scan-build.html
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: jroelofs
Date: Mon Jan 29 08:49:34 2018
New Revision: 323665
URL: http://llvm.org/viewvc/llvm-project?rev=323665&view=rev
Log:
[scan-build] Add an option to skip overriding CC and CXX make vars
Autoconf and some other systems tend to add essential compilation
options to CC (e.g. -std=gnu9
Author: jroelofs
Date: Mon Jan 29 08:37:53 2018
New Revision: 323664
URL: http://llvm.org/viewvc/llvm-project?rev=323664&view=rev
Log:
[analyzer] Fix -x language argument for C preprocessed sources
clang's -x option doesn't accept c-cpp-output as a language (even though
463eb6ab was merged, the d
LGTM. Would you like me to commit it for you?
Jon
On 1/14/18 9:22 AM, Paul Fertser wrote:
Autoconf and some other systems tend to add essential compilation
options to CC (e.g. -std=gnu99). When running such an auto-generated
makefile, scan-build does not need to change CC and CXX as they are
LGTM. Would you like me to commit it for you?
Jon
On 1/14/18 3:50 AM, Paul Fertser wrote:
clang's -x option doesn't accept c-cpp-output as a language (even though
463eb6ab was merged, the driver still doesn't handle that).
This bug prevents testing C language projects when ccache is used.
F
Author: jroelofs
Date: Fri Dec 29 11:26:53 2017
New Revision: 321570
URL: http://llvm.org/viewvc/llvm-project?rev=321570&view=rev
Log:
Try again, this time with the correct address
Modified:
libcxx/trunk/CREDITS.TXT
Modified: libcxx/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-project
Author: jroelofs
Date: Fri Dec 29 11:26:28 2017
New Revision: 321569
URL: http://llvm.org/viewvc/llvm-project?rev=321569&view=rev
Log:
Try again, this time with the correct address
Modified:
libcxxabi/trunk/CREDITS.TXT
Modified: libcxxabi/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-p
Author: jroelofs
Date: Fri Dec 29 11:16:12 2017
New Revision: 321564
URL: http://llvm.org/viewvc/llvm-project?rev=321564&view=rev
Log:
Update CREDITS.txt with personal email address
Modified:
libcxxabi/trunk/CREDITS.TXT
Modified: libcxxabi/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-
Author: jroelofs
Date: Fri Dec 29 11:15:20 2017
New Revision: 321563
URL: http://llvm.org/viewvc/llvm-project?rev=321563&view=rev
Log:
Update CREDITS.txt with personal email
Modified:
libcxx/trunk/CREDITS.TXT
Modified: libcxx/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx
+silvas
On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote:
Hi,
Please find attached a diff to fix the issue 12176.
Link for the lazy: llvm.org/PR12176
Let me know if there
is anything any improvements you can think of.
Best regards,
Oscar
Extract-getDepthAndIndex-issue-1
Author: jroelofs
Date: Thu Sep 7 15:01:25 2017
New Revision: 312748
URL: http://llvm.org/viewvc/llvm-project?rev=312748&view=rev
Log:
Fix validation of the -mthread-model flag in the Clang driver
The ToolChain class validates the -mthread-model flag in the constructor which
doesn't work correctl
Author: jroelofs
Date: Wed Sep 6 10:09:25 2017
New Revision: 312651
URL: http://llvm.org/viewvc/llvm-project?rev=312651&view=rev
Log:
Fix ARM bare metal driver to support atomics
The new bare metal support only supports the single thread model. This causes
the builtin atomic functions (e.g.: __a
Author: jroelofs
Date: Wed Jul 26 11:13:57 2017
New Revision: 309147
URL: http://llvm.org/viewvc/llvm-project?rev=309147&view=rev
Log:
Partial fix for PR33858
https://reviews.llvm.org/D35848
Modified:
libunwind/trunk/test/CMakeLists.txt
libunwind/trunk/test/lit.site.cfg.in
Modified: lib
Author: jroelofs
Date: Thu Jul 6 08:20:12 2017
New Revision: 307266
URL: http://llvm.org/viewvc/llvm-project?rev=307266&view=rev
Log:
Add a test harness
Mostly cargo-culted from libcxxabi, since the unwinder was forked from there in
the first place. There may still be cruft that's only applicabl
On 5/25/17 2:41 PM, Hans Wennborg wrote:
The test was failing on Windows; r303910 for that.
Oh yuk.. thanks for fixing that.
Jon
On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits
wrote:
On 5/25/17 11:39 AM, Galina Kistanova wrote:
Hello Jonathan,
This commit broke
Thanks
Galina
On Thu, May 25, 2017 at 8:42 AM, Jonathan Roelofs via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: jroelofs
Date: Thu May 25 10:42:13 2017
New Revision: 303873
URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev
<ht
Author: jroelofs
Date: Thu May 25 13:55:22 2017
New Revision: 303898
URL: http://llvm.org/viewvc/llvm-project?rev=303898&view=rev
Log:
Appease more buildbots about r303873
Modified:
cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
URL:
ht
Author: jroelofs
Date: Thu May 25 11:20:51 2017
New Revision: 303880
URL: http://llvm.org/viewvc/llvm-project?rev=303880&view=rev
Log:
Relax testcase to appease buildbots
When lld isn't built, the tests as they were previously, were too picky about
the path to the linker.
Modified:
cfe/trunk
Author: jroelofs
Date: Thu May 25 10:42:13 2017
New Revision: 303873
URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev
Log:
Don't defer to the GCC driver for linking arm-baremetal
Also comes with a cmake cache for building the runtime bits:
$ cmake \
-DBAREMETAL_ARMV6M_SYSROOT=/p
Author: jroelofs
Date: Mon May 8 12:06:17 2017
New Revision: 302443
URL: http://llvm.org/viewvc/llvm-project?rev=302443&view=rev
Log:
Fix grammar in comment. NFC
Modified:
cfe/trunk/test/Misc/warning-flags.c
Modified: cfe/trunk/test/Misc/warning-flags.c
URL:
http://llvm.org/viewvc/llvm-pro
Author: jroelofs
Date: Fri May 5 16:30:13 2017
New Revision: 302296
URL: http://llvm.org/viewvc/llvm-project?rev=302296&view=rev
Log:
Multilib: add dump methods
Modified:
cfe/trunk/include/clang/Driver/Multilib.h
cfe/trunk/lib/Driver/Multilib.cpp
Modified: cfe/trunk/include/clang/Driver
Author: jroelofs
Date: Thu May 4 19:18:27 2017
New Revision: 302207
URL: http://llvm.org/viewvc/llvm-project?rev=302207&view=rev
Log:
Document that Multilib flags must be actual flags
This is because -print-multi-lib depends on them being flags for correctness.
Fixes a case of this in the arm-a
Author: jroelofs
Date: Mon Apr 3 14:23:11 2017
New Revision: 299381
URL: http://llvm.org/viewvc/llvm-project?rev=299381&view=rev
Log:
Try to trigger the new docs builder. NFC
Modified:
libunwind/trunk/docs/index.rst
Modified: libunwind/trunk/docs/index.rst
URL:
http://llvm.org/viewvc/llvm-
Author: jroelofs
Date: Tue Mar 28 10:21:43 2017
New Revision: 298922
URL: http://llvm.org/viewvc/llvm-project?rev=298922&view=rev
Log:
[libunwind] Add sphinx docs
https://reviews.llvm.org/D31375
Added:
libunwind/trunk/docs/
libunwind/trunk/docs/BuildingLibunwind.rst
libunwind/trunk/d
On 3/26/17 10:13 AM, Jonathan Schleifer via cfe-commits wrote:
Use the correct EH personality for ObjC++ code.
Previously, it would just always use the ObjC DWARF personality, even with SjLj
or SEH exceptions.
diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp
index 228ef
Author: jroelofs
Date: Wed Mar 22 16:13:49 2017
New Revision: 298549
URL: http://llvm.org/viewvc/llvm-project?rev=298549&view=rev
Log:
Actually install scan-build / ccc-analyzer / c++-analyzer on windows
Before, we were only installing the wrappers... oops.
Modified:
cfe/trunk/tools/scan-bui
On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote:
chrib added a comment.
In https://reviews.llvm.org/D31140#706411, @jroelofs wrote:
Can you clarify the logic here? It's my understanding that:
`-fno-exceptions` does *not* imply `-fno-unwind-tables`
however:
`-fno-unwind-tables` *
Author: jroelofs
Date: Mon Mar 20 12:07:49 2017
New Revision: 298275
URL: http://llvm.org/viewvc/llvm-project?rev=298275&view=rev
Log:
Fix some sphinx -Werror's
... mostly having to do with code blocks which the syntax highlighter chokes on
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rs
Author: jroelofs
Date: Tue Mar 14 12:29:33 2017
New Revision: 297756
URL: http://llvm.org/viewvc/llvm-project?rev=297756&view=rev
Log:
Fix misspelled enum
https://reviews.llvm.org/D30945
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseOpenMP.cpp
cfe/trunk/li
On 3/3/17 7:45 PM, Eric Fiselier wrote:
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
Ah, cool.
Jon
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 3/3/17 6:26 PM, Eri
On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk
On 2/24/17 1:48 PM, Eric Fiselier wrote:
Inserting arbitrary feature macros into CMake should not be a
supported scenario because it results is macros, such as this one,
which are seemingly dead.
Good point.
Jon
/Eric
On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs
mailto:jonat...@c
On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote:
EricWF added a comment.
In https://reviews.llvm.org/D30339#685921, @jroelofs wrote:
In https://reviews.llvm.org/D30339#685919, @rmaprath wrote:
Perhaps change `config.h` and remove the definition there and adjust other
places accord
On 2/7/17 7:30 PM, Saleem Abdulrasool wrote:
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since
you use t
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since you use the
value later, it is probably better to write this as:
if (const auto *RD = cast(CurContext))
CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD
On 1/18/17 11:26 AM, Richard Smith via cfe-commits wrote:
On 18 January 2017 at 10:12, Jonathan Roelofs via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: jroelofs
Date: Wed Jan 18 12:12:39 2017
New Revision: 292418
URL: http://llvm.org/viewvc/llvm-proje
Author: jroelofs
Date: Wed Jan 18 12:12:39 2017
New Revision: 292418
URL: http://llvm.org/viewvc/llvm-project?rev=292418&view=rev
Log:
Revert r286788
The Itanium ABI [1] specifies that __cxa_demangle accept either:
1) symbol names, which start with "_Z"
2) type manglings, which do not star
Author: jroelofs
Date: Wed Jan 18 09:31:11 2017
New Revision: 292375
URL: http://llvm.org/viewvc/llvm-project?rev=292375&view=rev
Log:
Warn when calling a non interrupt function from an interrupt on ARM
The idea for this originated from a really tricky bug: ISRs on ARM don't
automatically save of
On 1/4/17 2:52 AM, Dylan McKay wrote:
I've just raised a bug here
https://llvm.org/bugs/show_bug.cgi?id=31530
> What's necessary for sign-off? Should I ping the reviewer (Richard
Smith) again?
I think so long as Richard or someone else who actively works on Clang
signs off. Perhaps somebo
Author: jroelofs
Date: Thu Dec 22 17:48:23 2016
New Revision: 290390
URL: http://llvm.org/viewvc/llvm-project?rev=290390&view=rev
Log:
Fix example: byref struct's init was incorrect, and the block literal's holder
should point to it.
Modified:
cfe/trunk/docs/Block-ABI-Apple.rst
Modified: cf
Author: jroelofs
Date: Tue Dec 6 09:45:41 2016
New Revision: 288818
URL: http://llvm.org/viewvc/llvm-project?rev=288818&view=rev
Log:
Fix doc string typo: s/@__yes/@__objc_yes/
Modified:
cfe/trunk/include/clang/AST/ExprObjC.h
Modified: cfe/trunk/include/clang/AST/ExprObjC.h
URL:
http://llv
Author: jroelofs
Date: Thu Dec 1 18:51:58 2016
New Revision: 288444
URL: http://llvm.org/viewvc/llvm-project?rev=288444&view=rev
Log:
Delete tautological assertion.
After r256463, both the LHS and RHS now refer to the same variable. Before,
they referred to the member, the parameter respectively
jroelofs added a comment.
In https://reviews.llvm.org/D27005#603979, @EricWF wrote:
> In https://reviews.llvm.org/D27005#603692, @jroelofs wrote:
>
> > Should probably add a testcase in lit/tests that exercises the new CUSTOM
> > parser stuff, so people working on LIT don't have to build/test li
jroelofs added a comment.
Should probably add a testcase in lit/tests that exercises the new CUSTOM
parser stuff, so people working on LIT don't have to build/test libc++ in order
to know whether they've broken its testsuite.
https://reviews.llvm.org/D27005
_
jroelofs added inline comments.
Comment at: test/Driver/print-libgcc-file-name-clangrt.c:11
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I686 %s
-// CHECK-CLANGRT-I686: libclang_rt.builtins-i686.a
+// CHECK-CLANGRT-I686: libclang_rt.builtins-i386.a
This CH
jroelofs added a comment.
Testcase?
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a subscriber: jroelofs.
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24770
___
cfe-commits mailing list
Author: jroelofs
Date: Mon Sep 12 11:14:52 2016
New Revision: 281227
URL: http://llvm.org/viewvc/llvm-project?rev=281227&view=rev
Log:
Trivial documentation fix regarding Obj-C ARC
objc_arc_weak_reference_unavailable
Fixed incorrect docs that referred to:
objc_arc_weak_unavailable
when it shou
On 9/2/16 9:26 AM, Sean McBride via cfe-commits wrote:
Friendly ping... this is a very trivial documentation patch...
LGTM
On Wed, 10 Aug 2016 13:57:07 -0400, Sean McBride via cfe-commits said:
Fixed incorrect docs that referred to:
objc_arc_weak_unavailable
when it should be:
objc_arc_
jroelofs added a comment.
In https://reviews.llvm.org/D21803#532382, @EricWF wrote:
> In https://reviews.llvm.org/D21803#532347, @jroelofs wrote:
>
> > In https://reviews.llvm.org/D21803#532309, @EricWF wrote:
> >
> > > `__thread`
> > >
> > > What do you think of this idea?
> >
> >
> > You'll hav
jroelofs added a comment.
In https://reviews.llvm.org/D21803#532309, @EricWF wrote:
> `__thread`
>
> What do you think of this idea?
You'll have to guard it against all the platforms that don't support TLS.
Darwin 10.6 is one of them.
https://reviews.llvm.org/D21803
__
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
jroelofs added a comment.
I'm not sure that's guaranteed behavior either. That being said, I don't see a
more robust way to write this test.
https://reviews.llvm.org/D23524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
jroelofs added a comment.
In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
> Yes, although in pratice for shared libraries this is not an issue (at least
> on Linux with current linker strategies). And I open for suggestion on how to
> proceed in this case since we have some other opt
jroelofs added a comment.
This breaks the ODR... the behavior under those circumstances is undefined.
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
Doesn't libgcc_s contain bits of gcc's unwinder?
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
I don't think I have any more comments, but I'll let one of the other reviewers
give the final go/no-go.
Comment at: docs/LanguageExtensions.rst:1047
@@ +1046,3 @@
+ Determines whether `expr` names
+ a object that will be initialized during
+ `const
jroelofs added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807
@@ +6806,3 @@
+
+def err_has_constant_init_expression_trait_invalid_arg : Error<
+ "expression does not reference a named variable">;
EricWF wrote:
> Help improving this w
jroelofs added a comment.
One more thing: need to add docs to `clang/docs/LanguageExtensions.rst`.
https://reviews.llvm.org/D23385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a subscriber: jroelofs.
Comment at: lib/AST/Expr.cpp:2656
@@ +2655,3 @@
+AllowNonLiteral)) {
+if (!CE->getNumArgs()) return true;
+unsigned numArgs = CE->getNumArgs();
no need for this `if`.
Also, I think the `for` shoul
jroelofs added a comment.
In https://reviews.llvm.org/D21134#509522, @danielmarjamaki wrote:
> In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
>
> > I think the replacement is wrong for something like:
> >
> > int *arr; int offs1, offs2;
> > offs1[arr + offs2] = 42;
> >
> >
> > wh
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I think the replacement is wrong for something like:
int *arr; int offs1, offs2;
offs1[arr + offs2] = 42;
which I think would give:
int *arr; int offs1, offs2;
arr + offs2[offs1] = 42;
If the precedence of the "indexing"
On 7/19/16 8:55 AM, Robinson, Paul wrote:
I think we could emulate any pre-commit hook we like via GitHub
WebHooks by having two repositories: llvm and llvm-staging (say).
People push to llvm-staging, which notifies some LLVM server we own.
That does basic sanity checks and pushes to llvm prop
jroelofs added a subscriber: jroelofs.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can s
jroelofs added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM. Do you want me to commit it for you?
http://reviews.llvm.org/D14727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote:
Author: asiri
Date: Tue Jun 14 10:51:01 2016
New Revision: 272680
URL: http://llvm.org/viewvc/llvm-project?rev=272680&view=rev
Log:
[libunwind] Improve unwinder stack usage - III
Implement the same optimization committed under r27100
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
Probably worth doing the same thing for the non-EHABI non-SJLJ implementation,
too (that can of course go in a separate commit).
LGTM
http://reviews.llvm.org/D20320
__
jroelofs added a comment.
In http://reviews.llvm.org/D14727#441758, @bryanpkc wrote:
> Fixed the code to set GoodVersion.MajorStr before returning, and removed an
> unnecessary file
> (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o).
That file is not unnec
On 5/26/16 3:45 PM, Asiri Rathnayake via cfe-commits wrote:
struct blk_count {
-static const uint32_t count =
+static const uint64_t count =
(sizeof(T) + sizeof(uint64_t) -
Should that be 'size_t' instead?
Jon
--
Jon Roelofs
jonat...@codesourcery.com
CodeSourcery / Ment
jroelofs added a comment.
In http://reviews.llvm.org/D20119#441516, @rmaprath wrote:
> Please shout!
Just add some parens:
static_assert((check_fit::does_fit),
"or1k registers do not fit into unw_context_t");
http://reviews.llvm.org/D20119
___
jroelofs added a comment.
This is the canonical reference for the Itanium ABI:
https://mentorembedded.github.io/cxx-abi/abi.html
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
jroelofs added a comment.
In http://reviews.llvm.org/D20119#437191, @rmaprath wrote:
> In http://reviews.llvm.org/D20119#436849, @jroelofs wrote:
>
> > In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> >
> > > Addressing review comments from @jroelofs:
> > >
> > > - Moved the assertion
jroelofs added a comment.
In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> Addressing review comments from @jroelofs:
>
> - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it
> really belogs.
>
> @jroelofs: I just realized that, with this new native-only bui
jroelofs added a comment.
Just one question, otherwise LGTM:
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
_isSignalFrame(false) {
- static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t),
-"UnwindCursor<> does not fit in unw_cursor_t");
---
jroelofs added a comment.
In http://reviews.llvm.org/D19871#429153, @etienneb wrote:
> In http://reviews.llvm.org/D19871#428997, @jroelofs wrote:
>
> > Drive-by thought: I think it would be useful to be able to match implicit
> > casts separately from explicit casts when using this new matcher.
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Drive-by thought: I think it would be useful to be able to match implicit casts
separately from explicit casts when using this new matcher.
http://reviews.llvm.org/D19871
___
cfe-comm
jroelofs added a comment.
In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
> In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
>
> > Wouldn't this break cross unwinding?
>
>
> I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks
> for the pointer.
>
> Wo
jroelofs added a comment.
Wouldn't this break cross unwinding?
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
> Alternatively `static_assert(std::is_same bool>::value);` :-P
>
> Testing the return type isn't the problem. The problem is telling LIT *when*
> we expect the test to fail using the `XFAIL` directive.
O. I see.
http://reviews.llvm.org/D19835
___
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I think you could lean on the linker to cause the test to fail when the type is
wrong:
bool isinf(double);
typedef int (*expected_signature)(double);
void assert_via_linker(decltype(isinf) blah);
void assert_via_linke
On 3/10/16 9:38 AM, Wes Witt via cfe-commits wrote:
I would like to submit the attached changes for your approval.
Gentle etiquette suggestion: please title your emails with something
more descriptive. In this case, something like: "[PATCH] Windows support
for ObjC codegen". And then in the
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Testcases?
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In http://reviews.llvm.org/D17456#357245, @bcraig wrote:
> In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
>
> > > The private redirector symbol names are all prefixed with _CXX_* so that
> > > they won't conflict with user symbols,
> >
> >
> > This is more @
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
> The private redirector symbol names are all prefixed with _CXX_* so that they
> won't conflict with user symbols,
This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
would be safer (so that there's no chanc
jroelofs added a subscriber: jroelofs.
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17380
___
cfe-commits mailing list
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
On 2/11/16 7:24 PM, Hans Wennborg wrote:
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits
wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | F
1 - 100 of 262 matches
Mail list logo
