tion.
Clean this up.
Signed-off-by: Douglas Anderson
---
.../gpu/drm/msm/disp/msm_disp_snapshot_util.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.
ixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snaps
@quicinc.com/
Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util
@quicinc.com/
Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util
ixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snaps
tion.
Clean this up.
Signed-off-by: Douglas Anderson
---
.../gpu/drm/msm/disp/msm_disp_snapshot_util.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.
Neil Armstrong
Signed-off-by: Douglas Anderson
---
include/linux/regulator/consumer.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/linux/regulator/consumer.h
b/include/linux/regulator/consumer.h
index d986ec13092e..b9ce521910a0 100644
--- a/include/linux/regulator/consumer.h
we'll print
the CPUs that we failed to stop instead of printing all _but_ the
current running CPU.
* In crash_smp_send_stop(), we will now only print "SMP: stopping
secondary CPUs" if (system_state <= SYSTEM_RUNNING).
Fixes: d7402513c935 ("arm64: smp: IPI_CPU_STOP and IPI_CPU_CRAS
: expected 12 but found 10 (indentation)
Fix them.
Reported-by: Rob Herring
Closes:
https://lore.kernel.org/r/cal_jsqlrtgqrpcfxy4g9hlohmd-uax4_c90bv_ozn4mk+-8...@mail.gmail.com
Fixes: 1c4a057d01f4 ("dt-bindings: display: panel: samsung,atna45dc02: Document
ATNA45DC02")
Signed-off-b
01: Don't call disable at
shutdown/remove")
Cc: Thierry Reding
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Closes: https://lore.kernel.org/r/202406261525.skhtm3zv-...@intel.com/
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 2 +
we'll print
the CPUs that we failed to stop instead of printing all _but_ the
current running CPU.
* In crash_smp_send_stop(), we will now only print "SMP: stopping
secondary CPUs" if (system_state <= SYSTEM_RUNNING).
Fixes: d7402513c935 ("arm64: smp: IPI_CPU_STOP and IPI_CPU_CRAS
won't be too
confused by what's going on here.
Suggested-by: Daniel Vetter
Signed-off-by: Douglas Anderson
---
This patch came out of discussion on dri-devel on 2024-06-21
[1]. NOTE: I have put all changes into one patch since it didn't seem
to add anything to break up the updatin
; sony tulip truly nt35521 panel.
>
>
Applied, thanks!
[1/1] drm/panel: truly-nt35521: transition to mipi_dsi wrapped functions
commit: c62b4fc4b9b86ab35e5c4236f2053ce21ee81ebc
Best regards,
--
Douglas Anderson
uot; functions to use "bool".
While touching this, we touch a line next to a comment using a style
that's nonstandard for the kdb codebase. Update it in passing.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 36 +---
1 file cha
When specifying a physical address allow specifying the word side and
the number of words.
NOTE: we don't do this for the "mds" command since it's pretty much a
different beast.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 16 ++--
We'd like to use the "WcN" parsing for some other "md"
variants. Abstract it out.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 55 +++--
1 file changed, 46 insertions(+), 9 deletions(-)
diff --git a/kernel/debu
Several of the integers in kdb_md() should be marked unsigned. Mark
them as such. When doing this, we need to add an explicit cast to the
address masking or it ends up getting truncated down to "int" size.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 10 +---
and "mdWcN"
handling. This breaks the above case where the user tweaked "argv[0]"
and then tried to somehow leverage the "repeat" code to do something
smart, but that feels like it was a misfeature anyway.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/k
Though the "mdr" has a similar purpose to the other "md" commands in
that they all display memory, the actual code to implement it has
almost nothing in common with the rest of the commands. Separate
things out.
Signed-off-by: Douglas Anderson
---
kernel/debug
n't really unique (it could be
the prefix for "mm" also) and it's only saving one letter. Remove the
setting of "minlen" to 1 for "md".
Signed-off-by: Douglas Anderson
---
While digging into this, I found that "minlen" doesn't seem to mean
00 ...
This doesn't seem like particularly useful behavior and adds a bunch
of complexity to the arg parsing. Remove it.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb
Add commands that are like the other "md" commands but that allow you
to read memory that's in the IO space.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c| 38 +++
kernel/debug/kdb/kdb_private.h | 1 +
kernel/debug/kdb/kdb
re obvious.
As part of this, add "bogus" commands to the table for "mdW" and
"mdWcN" so we don't have to obscurely reference them in the normal
"md" help. These bogus commands don't really hurt since kdb_md()
validate
logic more obvious by initializing `repeat` to 0
and then setting it to non-zero when it should override. Then we can
do all the math at once.
While changing this, use the proper DIV_ROUND_UP() macro and introcue
a constant for KDB_MD_BYTES_PER_LINE. We'll also make and "if else"
more obv
The docs say you should use kstrtouint() instead of simple_strtoul(),
so do so. This nicely simplfies the code a little.
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_main.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/debug/kdb/kdb_main.c b
the weird corners. I have a hard time believing anyone was relying
on these, but if you think someone is then please yell.
Also note that it would probably be good to add iomapped memory writes,
but this series is already pretty long so maybe that can be done later.
Douglas Anderson (13):
kdb
Every caller to kdbgetaddrarg() didn't care about the "offset" and
"name" returned by the function. Some passed NULL and some passed the
address of a bogus local variable that was never looked at. Drop the
arguments.
Signed-off-by: Douglas Anderson
---
kernel/deb
call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Signed-off-by: Douglas Anderson
---
This commit is only comp
call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Signed-off-by: Douglas Anderson
---
This commit is only comp
n with the equivalent
new calls.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Signed-off-by: Douglas Anderson
---
I honestly have no idea if I got this patch right. The shutdown()
function already had some special case logic for PPC
n with the equivalent
new calls.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Cc: Alex Deucher
Cc: Christian König
Cc: Xinhui Pan
Signed-off-by: Douglas Anderson
---
I honestly have no idea if I got this patch right. The shutdown()
function already had some special case logic for PPC
case the non-atomic equivalent drm_helper_force_disable_all(), in the
case of OS shutdown/restart comes straight out of the kernel doc
"driver instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
This commit is only co
call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
This commit is only compile-time tested.
(no c
call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
This commit is only compile-time tested.
(no c
r
instance overview" in drm_drv.c.
While at it, let's also fix it so that if the driver's bind fails or
if a driver gets unbound that the drvdata gets set to NULL. This will
make sure we can't get confused during a later shutdown().
Suggested-by: Maxime Ripard
Reviewed-by: Maxime
ff at system shutdown time.
The fact that we should call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
ff at system shutdown time.
The fact that we should call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
This commit is only compile-time tested.
(no c
iand...@chromium.org
[2]
https://lore.kernel.org/r/20230804140605.RFC.4.I930069a32baab6faf46d6b234f89613b5cec0f14@changeid
[3] https://lore.kernel.org/r/Zmm6_27GikpmT3HQ@phenom.ffwll.local
Changes in v2:
- Gathered whatever hadn't landed, rebased, and reposted.
Douglas Anderson (8):
drm/kmb:
iand...@chromium.org
[2]
https://lore.kernel.org/r/20230804140605.RFC.4.I930069a32baab6faf46d6b234f89613b5cec0f14@changeid
[3] https://lore.kernel.org/r/Zmm6_27GikpmT3HQ@phenom.ffwll.local
Changes in v2:
- Gathered whatever hadn't landed, rebased, and reposted.
Douglas Anderson (8):
drm/kmb:
iand...@chromium.org
[2]
https://lore.kernel.org/r/20230804140605.RFC.4.I930069a32baab6faf46d6b234f89613b5cec0f14@changeid
[3] https://lore.kernel.org/r/Zmm6_27GikpmT3HQ@phenom.ffwll.local
Changes in v2:
- Gathered whatever hadn't landed, rebased, and reposted.
Douglas Anderson (8):
drm/kmb:
own() is called and as of commit 2a073968289d
("drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a
noop") we don't need to confirm that "drm" is non-NULL.
Suggested-by: Maxime Ripard
Reviewed-by: Maxime Ripard
Reviewed-by: Fei Shao
Tested-by: Fei Shao
Signed-
g enough that
people should push to make this happen.
Implement this all in a shared "header" file included by the two panel
drivers that need it. This avoids us adding an new exports while still
allowing the panel drivers to be modules. The code waste should be
small and, as per above, t
iver tracking "prepared" but removed its
tracking of "enabled".
NOTE: as part of this, transition the panel's direct calls to its
disable/unprepare functions in shutdown to call through DRM panel.
Cc: Robert Chiras
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-of
Now that most panels have been updated not to track/double-check their
prepared/enabled state update the TODO with next steps.
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v1)
Documentation/gpu/todo.rst | 47
ned-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-raydium-rm67191.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-raydium-rm67191.c
b/drive
g enough that
people should push to make this happen.
Implement this all in a shared "header" file included by the two panel
drivers that need it. This avoids us adding an new exports while still
allowing the panel drivers to be modules. The code waste should be
small and, as per above, t
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 12
1 file changed, 12 deletion
e-check is now in the core and not
needed in individual drivers.
Cc: Werner Johansson
Cc: Dmitry Baryshkov
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/en
e-check is now in the core and not
needed in individual drivers.
Cc: Thierry Reding
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remov
ned-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
.../gpu/drm/panel/panel-sharp-lq101r1sx01.c | 24 ++-
1 file changed, 2 insertions(+), 22 deletions(-)
di
e-check is now in the core and not
needed in individual drivers.
Cc: Werner Johansson
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling
engutronix Kernel Team
Cc: i...@lists.linux.dev
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/p
@chromium.org
Cc: Werner Johansson
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-pana
by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 12
1 file changed, 12 deletions(-)
di
e-check is now in the core and not
needed in individual drivers.
Cc: Marco Franchi
Cc: Fabio Estevam
Cc: Laurentiu Palcu
Cc: Pengutronix Kernel Team
Cc: i...@lists.linux.dev
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in
e-check is now in the core and not
needed in individual drivers.
Cc: Neil Armstrong
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remov
e-check is now in the core and not
needed in individual drivers.
NOTE: as part of this, transition the panel's direct calls to its
disable function in shutdown/remove to call through DRM panel.
Cc: Vinay Simha BN
Cc: Sumit Semwal
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-
ned-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drive
..@chromium.org
Cc: Neil Armstrong
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/pa
e-check is now in the core and not
needed in individual drivers.
Cc: Peter Ujfalusi
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remov
..@chromium.org
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c |
e-check is now in the core and not
needed in individual drivers.
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
...
e-check is now in the core and not
needed in individual drivers.
Cc: Jacobe Zang
Cc: Nicolas Belin
Cc: Neil Armstrong
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal o
@chromium.org
Cc: Jacobe Zang
Cc: Nicolas Belin
Cc: Neil Armstrong
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown
.@chromium.org
Cc: Jerry Han
Cc: Jitao Shi
Cc: Rock Wang
Acked-by: Linus Walleij
Acked-by: Maxime Ripard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
driver
ard
Signed-off-by: Douglas Anderson
---
(no changes since v2)
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
drivers/gpu/drm/panel/panel-boe-himax8279d.c | 31 +++-
1 file changed, 4 insertions(+), 27 del
p at shutdown
Changes in v2:
- Only handle 1 panel per patch.
- Split removal of prepared/enabled from handling of remove/shutdown.
Douglas Anderson (24):
drm/panel: boe-himax8279d: Stop tracking prepared/enabled
drm/panel: boe-himax8279d: Don't call unprepare+disable at
shutdown/remo
n, so list as "Unknown" in this patch.
>
> [...]
Applied, thanks!
[2/2] drm/panel-edp: Add more panels with conservative timings
commit: 336dca397dcefc5d7436be1fee3c814ed6512996
Best regards,
--
Douglas Anderson
40bb9e17924b
Best regards,
--
Douglas Anderson
ion. This patch is expected to functionally be a
no-op.
Fixes: 09b35989421d ("kdb: Use format-strings rather than '\0' injection in
kdb_read()")
Signed-off-by: Douglas Anderson
---
kernel/debug/kdb/kdb_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ker
rm_dp_as_sdp'
>
> [...]
Applied, thanks!
[1/1] drm/dp: Fix documentation warning
commit: c7ce956bb6d0f32ab921b6ffba1a6a834df96f21
Best regards,
--
Douglas Anderson
pplied, thanks!
[1/1] drm/panel-edp: Add CMN N116BCJ-EAK
commit: 7acacca1b157fcb258cfd781603425f73bc7370b
Best regards,
--
Douglas Anderson
e builtin) and it absolutely requires an
"enable" GPIO.
- We'll un-fork the "sharp,ld-d5116z01b.yaml" and put it in
"panel-edp-legacy.yaml" since there doesn't appear to be any reason
for it to be separate.
Suggested-by: Dmitry Baryshkov
Signed-off-by: Dougl
The enable GPIO should clearly be set low before turning off
regulators. That matches both the inverse order that things were
enabled and also the order in unprepare().
Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver")
Signed-off-by: Douglas Anderson
---
ax-hx83102: Break out as separate driver")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c
b/drivers/gpu/drm/panel/panel-himax-hx83102.c
ind
the
"accum_err" variable for error returns, though that's definitely a
style decision with pros and cons.
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-himax-hx83102.c | 92 +++--
1 file changed, 28 insertions(+), 64 deletions(-)
diff --git a/driv
panel: boe-tv101wum-nl6: Fine tune the panel power
sequence")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
b/drivers/gpu/drm/panel/panel-boe
: ili9882t: Break out as separate driver")
Signed-off-by: Douglas Anderson
---
drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c
ind
The enable GPIO should clearly be set low before turning off
regulators. That matches both the inverse order that things were
enabled and also the order in unprepare().
Fixes: e2450d32e5fb ("drm/panel: ili9882t: Break out as separate driver")
Signed-off-by: Douglas Anderson
---
drive
The enable GPIO should clearly be set low before turning off
regulators. That matches both the inverse order that things were
enabled and also the order in unprepare().
Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video
mode panel")
Signed-off-by: Dougla
lly
worked then we're return 0 (no error) from hx8394_enable() even though
the panel wasn't enabled.
Fix this by not blowing away "ret".
Found by code inspection.
Fixes: 65dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver")
Signed-off-by: Douglas An
f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling"). His
series handled the panel driver that himax-hx83102 forked from but not
himax-hx83102.
Douglas Anderson (8):
drm/panel: himax-hx8394: Handle errors from
mipi_dsi_dcs_set_display_on() better
drm/
re touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
(no changes since v3)
Changes in v3:
- Fix spacing of init function.
- Remove an unneeded error print.
- Squash boe-tv101wum
ite code that is "inspired" by the new macros.
Since we're touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
(no changes since v4)
Changes in v4:
- Test to see i
-681
starry_ili9882t_init_cmd7320 - -7320
Total: Before=11928, After=10585, chg -11.26%
Let's do the conversion.
Since we're touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-
: Dmitry Baryshkov
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
This change is only compile tested. I don't use this panel myself but
arbitrarily picked it as an example to look at when working on the
MIPI DSI macros.
(no changes since v3)
Changes in v3:
- Fix spacing of
ed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
Right now this patch introduces two new functions in drm_mipi_dsi.c.
Alternatively we could have changed the prototype of the "chatty"
functions and made the deprecated macros adapt to the new prototype.
While this sounds nice, it blo
31815, After=15055, chg -52.68%
Reviewed-by: Neil Armstrong
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
(no changes since v3)
Changes in v3:
- ("mipi_dsi_*_write functions don't need to ratelimit...") moved earlier.
Changes in v2:
- New
include/drm
hat the current consensus of DRM folks is that the
mipi_dsi_*_write_seq() should be deprecated due to the non-intuitive
return behavior. A future patch will formally mark them as deprecated
and provide an alternative.
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Neil Armstrong
Reviewed-by: Linus Walleij
d in a 16-bit int would look negative.
Though there are no callsites where we'd actually hit this (even if
"int" was only 16-bit), it's cleaner to make the types match so let's
fix it.
Fixes: a9015ce59320 ("drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro"
d in a 16-bit int would look negative.
Though there are no callsites where we'd actually hit this (even if
"int" was only 16-bit), it's cleaner to make the types match so let's
fix it.
Fixes: 2a9e9daf7523 ("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro"
e a table for initting commands
- drm/panel: novatek-nt36672e: Switch to mipi_dsi_dcs_write_seq_multi()
Douglas Anderson (9):
drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()
drm/mipi-dsi: Fix theoretical int overflow in
mipi_dsi_generic_write_seq()
drm/mipi-ds
-681
starry_ili9882t_init_cmd7320 - -7320
Total: Before=11928, After=10585, chg -11.26%
Let's do the conversion.
Since we're touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-
ite code that is "inspired" by the new macros.
Since we're touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
Changes in v4:
- Test to see if init is non-NULL before
re touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
(no changes since v3)
Changes in v3:
- Fix spacing of init function.
- Remove an unneeded error print.
- Squash boe-tv101wum
: Douglas Anderson
---
This change is only compile tested. I don't use this panel myself but
arbitrarily picked it as an example to look at when working on the
MIPI DSI macros.
NOTE: as of the posting of v4 this change still has no tags. Without
any tags (Reviewed-by/Tested-by/Acked-by) I
ed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
Right now this patch introduces two new functions in drm_mipi_dsi.c.
Alternatively we could have changed the prototype of the "chatty"
functions and made the deprecated macros adapt to the new prototype.
While this sounds nice, it blo
hat the current consensus of DRM folks is that the
mipi_dsi_*_write_seq() should be deprecated due to the non-intuitive
return behavior. A future patch will formally mark them as deprecated
and provide an alternative.
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Neil Armstrong
Reviewed-by: Linus Walleij
S
31815, After=15055, chg -52.68%
Reviewed-by: Neil Armstrong
Reviewed-by: Linus Walleij
Signed-off-by: Douglas Anderson
---
(no changes since v3)
Changes in v3:
- ("mipi_dsi_*_write functions don't need to ratelimit...") moved earlier.
Changes in v2:
- New
include/drm
1 - 100 of 1026 matches
Mail list logo
