Re: [FFmpeg-devel] [PATCH] lavc/avcodec: fix global/private option precendence

2024-10-14 Thread Dale Curtis
Thanks for the fix! Sorry for the breakage. - dale On Sun, Oct 13, 2024 at 3:01 PM Cameron Gutman wrote: > On Sun, Oct 13, 2024 at 8:29 AM Anton Khirnov wrote: > > > > Broken after 7753a9d62725d5bd8313e2d249acbe1c8af79ab1. Apply only the > > whitelist early, and the rest with a single call to

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-10-14 Thread Dale Curtis
Any issues remaining with this patch? Thanks in advance for applying. - dale On Sun, Sep 22, 2024 at 4:30 PM Michael Niedermayer wrote: > On Wed, Aug 14, 2024 at 08:29:37AM +0200, Christophe Gisquet wrote: > > Hi, > > > > Le mar. 13 août 2024 à 23:39, Dale Curtis a >

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-09-20 Thread Dale Curtis
Were there any more comments for this patch? - dale On Tue, Aug 13, 2024 at 11:30 PM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Hi, > > Le mar. 13 août 2024 à 23:39, Dale Curtis a > écrit : > > > > On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-09-06 Thread Dale Curtis
Were there any more comments on this patch? Thanks! - dale On Mon, Aug 19, 2024 at 12:19 PM Dale Curtis wrote: > On Sat, Aug 17, 2024 at 12:25 PM James Almer wrote: > >> On 8/17/2024 3:04 PM, Michael Niedermayer wrote: >> > >> > >>

[FFmpeg-cvslog] lavc: Check codec_whitelist early in avcodec_open2()

2024-09-01 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Tue Jul 30 23:12:21 2024 +| [7753a9d62725d5bd8313e2d249acbe1c8af79ab1] | committer: Anton Khirnov lavc: Check codec_whitelist early in avcodec_open2() This ensures that if a codec isn't on codec_whitelist, trying to open it will not tr

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-08-19 Thread Dale Curtis
On Sat, Aug 17, 2024 at 1:42 AM Anton Khirnov wrote: > I don't follow, why would any code outside of libavcodec care about > anything in private data? > Sorry I was imprecise. The issue is that ff_codec_close() is called during "free_and_end", which releases a bunch of fields on the AVCodecConte

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-19 Thread Dale Curtis
On Sat, Aug 17, 2024 at 12:25 PM James Almer wrote: > On 8/17/2024 3:04 PM, Michael Niedermayer wrote: > > > > > 20978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5746381832847360 > sent privately > Thanks for the sample Michael. I've confirmed it does not reproduce with my cha

[FFmpeg-cvslog] avformat/mov: Fix nullptr dereference with invalid encryption metadata.

2024-08-18 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Fri Aug 2 22:04:46 2024 +| [4230379835780c855818d7141082d9558e3842dc] | committer: Michael Niedermayer avformat/mov: Fix nullptr dereference with invalid encryption metadata. Found by fuzzer. Bug: https://crbug.com/356720789 Signed-off-by: Dale

[FFmpeg-cvslog] lavf/demux: don't reallocate a AVCodecContext when closing a non-open codec.

2024-08-17 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Fri Aug 2 16:44:21 2024 +| [a31106d84976bd28e56de35ee8085eebfc6c5e4d] | committer: Anton Khirnov lavf/demux: don't reallocate a AVCodecContext when closing a non-open codec. This results in an unnecessary ~800k allocation with H.264. A n

[FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-14 Thread Dale Curtis
but please yell if I've done something silly. Signed-off-by: Dale Curtis no_padding.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] Fix nullptr dereference with invalid encryption metadata.

2024-08-14 Thread Dale Curtis
Bump for this one. Thanks! - dale On Fri, Aug 2, 2024 at 3:08 PM Dale Curtis wrote: > Found by fuzzer. > > Bug: https://crbug.com/356720789 > Signed-off-by: Dale Curtis > --- > libavformat/mov.c | 8 ++-- > 1 file changed, 6 inser

Re: [FFmpeg-devel] [PATCH] Don't reallocate a AVCodecContext when closing a non-open codec.

2024-08-14 Thread Dale Curtis
Bump for this one. Thanks! - dale On Fri, Aug 2, 2024 at 9:54 AM Dale Curtis wrote: > This results in an unnecessary ~800k allocation with H.264. A > nearby callsite uses avcodec_is_open() to avoid this, so do the > same when exiting avformat_find_stream_info(). > > Signed-off-

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-08-14 Thread Dale Curtis
Bump for this one. Thanks! - dale On Wed, Jul 31, 2024 at 4:18 PM Dale Curtis wrote: > On Wed, Jul 31, 2024 at 2:29 PM Dale Curtis > wrote: > >> On Wed, Jul 31, 2024 at 2:10 PM Dale Curtis >> wrote: >> >>> On Wed, Jul 31, 2024 at 4:32 AM Anton Khirnov

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-08-13 Thread Dale Curtis
On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes wrote: > Disabling random codec features seems like an anti-feature to me, in > the future it'll make every feature be questioned and compile-time > conditional, and make everything terrible. > If the context size is the major concern, maybe large s

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-08-13 Thread Dale Curtis
Thanks, disable-h274-film-grain and applying it to hevc too sgtm. I'll wait to see what Niklas says before updating though. - dale On Tue, Aug 13, 2024 at 12:47 PM James Almer wrote: > On 8/13/2024 4:31 PM, Dale Curtis wrote: > > Film grain support adds a huge amount of o

[FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-08-13 Thread Dale Curtis
the H264Context size from 851808 bytes to 53444 bytes. Bug: https://crbug.com/359358875 Signed-off-by: Dale Curtis Note: I'm not sure this is the right way to go about making this optional, please let me know if there's a better way. - dale optional_film_grain_v1.patch Description: B

[FFmpeg-devel] [PATCH] Fix nullptr dereference with invalid encryption metadata.

2024-08-02 Thread Dale Curtis
Found by fuzzer. Bug: https://crbug.com/356720789 Signed-off-by: Dale Curtis --- libavformat/mov.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) mov_fuzz_fix_v1.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] [PATCH] Don't reallocate a AVCodecContext when closing a non-open codec.

2024-08-02 Thread Dale Curtis
This results in an unnecessary ~800k allocation with H.264. A nearby callsite uses avcodec_is_open() to avoid this, so do the same when exiting avformat_find_stream_info(). Signed-off-by: Dale Curtis --- libavformat/demux.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-07-31 Thread Dale Curtis
On Wed, Jul 31, 2024 at 2:29 PM Dale Curtis wrote: > On Wed, Jul 31, 2024 at 2:10 PM Dale Curtis > wrote: > >> On Wed, Jul 31, 2024 at 4:32 AM Anton Khirnov wrote: >> >>> Quoting Dale Curtis (2024-07-31 01:14:13) >>> > I realized there are a couple

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-07-31 Thread Dale Curtis
On Wed, Jul 31, 2024 at 2:10 PM Dale Curtis wrote: > On Wed, Jul 31, 2024 at 4:32 AM Anton Khirnov wrote: > >> Quoting Dale Curtis (2024-07-31 01:14:13) >> > I realized there are a couple more allocations that can be skipped here >> > when a codec is not on the

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-07-31 Thread Dale Curtis
On Wed, Jul 31, 2024 at 4:32 AM Anton Khirnov wrote: > Quoting Dale Curtis (2024-07-31 01:14:13) > > I realized there are a couple more allocations that can be skipped here > > when a codec is not on the allow list. Here's the updated patch. > > > > - dale &g

Re: [FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-07-30 Thread Dale Curtis
I realized there are a couple more allocations that can be skipped here when a codec is not on the allow list. Here's the updated patch. - dale On Mon, Jul 29, 2024 at 10:19 AM Dale Curtis wrote: > This ensures that if a codec isn't on codec_whitelist, its VUI > informat

[FFmpeg-devel] [PATCH] Check codec_whitelist before reinitializing AVCtx.priv_data.

2024-07-29 Thread Dale Curtis
This ensures that if a codec isn't on codec_whitelist, its VUI information can still be populated during find_stream_info() via parsers. Signed-off-by: Dale Curtis --- libavcodec/avcodec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) no_reinit.patch Description: B

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

2024-04-14 Thread Dale Curtis
ffmpeg | branch: release/5.1 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [8f209d2c90e84cd250f1a4667d1d83ec196f51dc] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

2024-04-14 Thread Dale Curtis
ffmpeg | branch: release/6.0 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [90571795e208a7061eb358e7f0f073c17a7ecbcc] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] Don't throw an error when attached picture isn't recognized.

2024-03-28 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Mon Apr 10 10:52:08 2023 -0700| [bba6df9ac7bd8386d92e1a7f5c737ca4e575fccf] | committer: Michael Niedermayer Don't throw an error when attached picture isn't recognized. The MIME type field is required per the FLAC standard, but it's no

Re: [FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype

2024-03-27 Thread Dale Curtis
Bump on this patch -- it still applies cleanly. We're still seeing files in the wild like this. - dale On Mon, Apr 10, 2023 at 10:54 AM Dale Curtis wrote: > Will left Google, but I've updated the patch to only skip errors when the > type is unrecognized. > > On Wed, S

[FFmpeg-cvslog] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-21 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Fri Feb 2 20:49:44 2024 +| [6ef32ea5748e9dcc2c8d1c076607b8d15650a5fe] | committer: Michael Niedermayer Avoid OOM for invalid STCO / CO64 constructions. The `entries` value is read directly from the stream and used to allocate memory. This change

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-16 Thread Dale Curtis
On Thu, Feb 15, 2024 at 2:35 PM Michael Niedermayer wrote: > FFMIN/MAX can evaluate their arguments multiple times so avio_rb32() might > be executed more than once > Thanks. Good catch. Fixed. stco-clamp-entries-v4.patch Description: Binary data ___

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-15 Thread Dale Curtis
s possible, but I've added a FFMAX(0,) there too. - dale From db3e9ffc364cc94cb3a72696d4d4858af6abcc42 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 2 Feb 2024 20:49:44 + Subject: [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions. The `entries` value is read direct

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
On Fri, Feb 2, 2024 at 3:42 PM Dale Curtis wrote: > On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Dale Curtis: >> > +// Clamp allocation size for `chunk_offsets` -- don't throw an >> error for an

Re: [FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
On Fri, Feb 2, 2024 at 3:20 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Dale Curtis: > > +// Clamp allocation size for `chunk_offsets` -- don't throw an > error for an > > +// invalid count since the EOF path doesn't throw either. >

[FFmpeg-devel] [PATCH] [mov] Avoid OOM for invalid STCO / CO64 constructions.

2024-02-02 Thread Dale Curtis
The `entries` value is read directly from the stream and used to allocate memory. This change clamps `entries` to however many are possible in the remaining atom or file size (whichever is smallest). Fixes https://crbug.com/1429357 Signed-off-by: Dale Curtis --- libavformat/mov.c | 7

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

2023-12-29 Thread Dale Curtis
ffmpeg | branch: release/6.1 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [ca5ebfb066b1298c6b1f84b03185fb8463bc7884] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

2023-12-21 Thread Dale Curtis
ffmpeg | branch: release/4.4 | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [207e003758d80ffa595e21543007021659c0e535] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

Re: [FFmpeg-devel] [PATCH] avformat/mov: Ignore duplicate ftyp

2023-12-04 Thread Dale Curtis
Thanks! lgtm, defer to you on FF_COMPLIANCE_STRICT. On Fri, Dec 1, 2023 at 3:59 PM wrote: > > > On 2 Dec 2023, at 0:26, Michael Niedermayer wrote: > > > Fixes: switch_1080p_720p.mp4 > > Found-by: Dale Curtis > > Signed-off-by: Michael Niedermayer >

[FFmpeg-cvslog] avformat/mov: Fix integer overflow in mov_read_packet().

2023-12-01 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Wed Nov 22 22:17:37 2023 +| [2182173a6933c02b0853751034bd5e0bf829b5f7] | committer: Michael Niedermayer avformat/mov: Fix integer overflow in mov_read_packet(). Fixes https://crbug.com/1499669: runtime error: signed integer overflow

Re: [FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

2023-12-01 Thread Dale Curtis
On Fri, Nov 24, 2023 at 3:38 PM Michael Niedermayer wrote: > On Wed, Nov 22, 2023 at 02:20:59PM -0800, Dale Curtis wrote: > > Fixes https://crbug.com/1499669: > > > runtime error: signed integer overflow: 9223372036853334272 + 1375731456 > > this looks a bit close to AV

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Disallow FTYP after streams

2023-12-01 Thread Dale Curtis
FWIW, this ends up breaking files which are basically just concatenated fragmented mp4 files -- which is pretty sketchy, but we had some test content doing that: https://storage.googleapis.com/chromiumos-test-assets-public/Shaka-Dash/switch_1080p_720p.mp4 Is that intentional? Or should an alternat

[FFmpeg-devel] [PATCH] Fix integer overflow in mov_read_packet().

2023-11-22 Thread Dale Curtis
Fixes https://crbug.com/1499669: runtime error: signed integer overflow: 9223372036853334272 + 1375731456 cannot be represented in type 'int64_t' (aka 'long') Signed-off-by: Dale Curtis --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [blink-dev] Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

2023-10-27 Thread Dale Curtis
especially with Safari already > shipping. LGTM1 > > On Wed, Oct 18, 2023 at 7:18 PM Dale Curtis > wrote: > >> Contact emails v...@microsoft.com, gw...@microsoft.com, >> gur...@microsoft.com, dalecur...@chromium.org >> >> Explainer >> https://github.co

[blink-dev] Re: Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

2023-10-25 Thread Dale Curtis
On Wed, Oct 25, 2023 at 8:30 AM Yoav Weiss wrote: > > > On Thursday, October 19, 2023 at 1:18:44 AM UTC+2 blink-dev wrote: > > Contact emailsv...@microsoft.com, gw...@microsoft.com, gurvir@ > microsoft.com, dalecur...@chromium.org > > Explainerhttps://github.com/w3c/media-capabilities/blob/main/

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-25 Thread Dale Curtis
olks involved who got us here. > > On Wed, Oct 25, 2023 at 10:37 AM Yoav Weiss > wrote: > >> LGTM2 >> >> On Tue, Oct 24, 2023 at 7:05 PM Dale Curtis >> wrote: >> >>> WMF has long switched away from Theora (to VP9) per prior discussions >>&

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-24 Thread Dale Curtis
options. - dale On Mon, Oct 23, 2023 at 8:41 PM Yuhong Bao wrote: > > I am asking the WMF to add MP4: > https://phabricator.wikimedia.org/T329258 > On Monday, October 23, 2023 at 8:53:14 AM UTC-7 Dale Curtis wrote: > >> Contact emailsdalec...@chromium.or

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-24 Thread Dale Curtis
On Tue, Oct 24, 2023 at 4:49 AM Mike Taylor wrote: > On 10/23/23 1:13 PM, Dale Curtis wrote: > > On Mon, Oct 23, 2023 at 10:02 AM Mike Taylor > wrote: > >> On 10/23/23 11:54 AM, Dale Curtis wrote: >> >> Hmm, not sure why the description got reflowed

Re: [blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-23 Thread Dale Curtis
On Mon, Oct 23, 2023 at 10:02 AM Mike Taylor wrote: > On 10/23/23 11:54 AM, Dale Curtis wrote: > > Hmm, not sure why the description got reflowed, here's the formatted > version: > > Chrome will deprecate and remove support for the Theora video codec in > desktop Chrom

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-23 Thread Dale Curtis
On Mon, Oct 23, 2023 at 8:54 AM Dale Curtis wrote: > Hmm, not sure why the description got reflowed, here's the formatted > version: > > Chrome will deprecate and remove support for the Theora video codec in > desktop Chrome due to emerging security risks. Theora's low (

[blink-dev] Re: Intent to Ship: Deprecate and remove Theora support.

2023-10-23 Thread Dale Curtis
: launch at 100%. - ~Feb 2024: remove code and chrome://flag in M123. - ~Mar 2024: Chrome 123 will roll to stable. - dale On Mon, Oct 23, 2023 at 8:52 AM Dale Curtis wrote: > Contact emailsdalecur...@chromium.org > > ExplainerNone > > Specificationhttps://en.wikipedia.org/wiki/Theo

[blink-dev] Intent to Ship: Deprecate and remove Theora support.

2023-10-23 Thread Dale Curtis
Contact emailsdalecur...@chromium.org ExplainerNone Specificationhttps://en.wikipedia.org/wiki/Theora Summary Chrome will deprecate and remove support for the Theora video codec in desktop Chrome due to emerging security risks. Theora's low (and now often incorrect) usage no longer justifies su

[blink-dev] Intent to Ship: MediaCapabilities: Query HDR support with decodingInfo()

2023-10-18 Thread Dale Curtis
Contact emailsv...@microsoft.com, gw...@microsoft.com, gur...@microsoft.com , dalecur...@chromium.org Explainer https://github.com/w3c/media-capabilities/blob/main/explainer.md#decode-capabilities Specificationhttps://www.w3.org/TR/media-capabilities/#hdrmetadatatype Summary Extends the Media C

Re: [blink-dev] Intent to implement and ship: Media query support for video elements

2023-10-05 Thread &#x27;Dale Curtis' via blink-dev
Thanks! On Thu, Oct 5, 2023 at 12:53 PM Yoav Weiss wrote: > LGTM1 > > Thanks for correcting this historical mistake! > > On Thu, Oct 5, 2023, 21:11 Dale Curtis wrote: > >> Contact emailsdalecur...@chromium.org >> >> ExplainerNone >> > > We coul

[blink-dev] Intent to implement and ship: Media query support for video elements

2023-10-05 Thread Dale Curtis
Contact emailsdalecur...@chromium.org ExplainerNone Specification https://html.spec.whatwg.org/multipage/media.html#loading-the-media-resource Design docs https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#media Summary Adds support for CSS media queries to elements used with e

Re: [blink-dev] Re: Intent to Prototype And Ship: Allow transferring ArrayBuffer into VideoFrame, AudioData, EncodedVideoChunk, EncodedAudioChunk, ImageDecoder constructors

2023-09-05 Thread Dale Curtis
gene Zemtsov' via blink-dev < > blink-dev@chromium.org> wrote: > >  > TAG review: https://github.com/w3ctag/design-reviews/issues/889 > > On Wed, Aug 30, 2023 at 9:50 AM Dale Curtis > wrote: > >> Alex, I assume you mean TAG's views on consistency re

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

2023-08-30 Thread Dale Curtis
;> >> /Daniel >> On 2023-08-30 16:24, Yoav Weiss wrote: >> >> LGTM1 to ship, with a base flag to ensure we can rollback if needed. >> >> On Mon, Aug 28, 2023 at 6:16 PM Dale Curtis >> wrote: >> >>> On Mon, Aug 21, 2023 at 9:41 AM Dal

Re: [blink-dev] Re: Intent to Prototype And Ship: Allow transferring ArrayBuffer into VideoFrame, AudioData, EncodedVideoChunk, EncodedAudioChunk, ImageDecoder constructors

2023-08-30 Thread Dale Curtis
Alex, I assume you mean TAG's views on consistency regarding transfer ergonomics? Otherwise https://www.w3.org/TR/design-principles/#consistency is what we followed here. We have not asked, given that we felt this was a small performance improvement, with pre-existing ergonomics, and already has Me

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

2023-08-28 Thread Dale Curtis
On Mon, Aug 21, 2023 at 9:41 AM Dale Curtis wrote: > On Sun, Aug 20, 2023 at 7:36 PM Yoav Weiss wrote: > >> Thanks for working on this!! Eliminating resources which can't be loaded >> as CORS enabled resources is super useful! >> >> On Fri, Aug 18, 202

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

2023-08-21 Thread Dale Curtis
On Mon, Aug 21, 2023 at 1:24 AM Fredrik Söderquist wrote: > On Mon, Aug 21, 2023 at 4:36 AM Yoav Weiss wrote: > >> Thanks for working on this!! Eliminating resources which can't be loaded >> as CORS enabled resources is super useful! >> >> On Fri, Aug 18, 202

Re: [blink-dev] Intent to Implement and Ship: SVGImageElement.crossOrigin attribute.

2023-08-21 Thread Dale Curtis
On Sun, Aug 20, 2023 at 7:36 PM Yoav Weiss wrote: > Thanks for working on this!! Eliminating resources which can't be loaded > as CORS enabled resources is super useful! > > On Fri, Aug 18, 2023 at 11:28 PM Dale Curtis > wrote: > >> Contact emailsdalecur...@chr

Re: [blink-dev] Intent to Prototype: Zstd Content-Encoding

2023-06-21 Thread Dale Curtis
On Wed, Jun 21, 2023 at 3:18 AM Adam Rice wrote: > Drive by question: Given that the codec is going to be in the browser, are >> there plans to surface this up to CompressionStreams? (same question >> applies for Brotli, I suppose) > > > For the zstd Content-Encoding, we will only be linking in t

Re: [blink-dev] Re: Intent to Implement and Ship: WebCodecs dequeue event

2023-01-26 Thread Dale Curtis
Yes, it shipped in M106 per chrome status. The MDN documentation is here: https://developer.mozilla.org/en-US/docs/Web/API/AudioDecoder/dequeue_event https://developer.mozilla.org/en-US/docs/Web/API/VideoDecoder/dequeue_event https://developer.mozilla.org/en-US/docs/Web/API/AudioEncoder/dequeue_ev

Re: [blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

2022-09-21 Thread Dale Curtis
> wrote: > >> LGTM2 >> >> On 9/21/22 7:44 AM, Yoav Weiss wrote: >> >> LGTM1 >> >> It seems unlikely that even the (few) developers who access this data are >> somehow relying on it. >> >> On Tue, Sep 20, 2022 at 8:10 PM Dale Cur

Re: [blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

2022-09-20 Thread Dale Curtis
On Tue, Sep 20, 2022 at 3:36 AM Yoav Weiss wrote: > > > On Fri, Sep 16, 2022 at 11:19 PM Dale Curtis > wrote: > >> Contact emailsdalecur...@chromium.org >> >> ExplainerNone >> >> Specificationhttps://github.com/w3c/webcodecs/issues/508 >> &

[blink-dev] Intent to deprecate and remove ImageDecoderInit.premultiplyAlpha.

2022-09-16 Thread Dale Curtis
Contact emailsdalecur...@chromium.org ExplainerNone Specificationhttps://github.com/w3c/webcodecs/issues/508 Summary premultiplyAlpha tells ImageDecoder to multiply the alpha channel into the RGB channels of decoded images. It was added to mirror the capabilities of ImageBitmapOptions, but in re

Device change handling for AirPods in Big Sur?

2020-10-20 Thread Dale Curtis via Coreaudio-api
Hi, we have some users reporting that the AirPods Pro automatic switching does not work in any applications but Safari or QuickTime player. Is there any documentation for how to listen for the necessary device c

Re: [FFmpeg-devel] Question about HEIF/HEIC support

2020-09-29 Thread Dale Curtis
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-November/252827.html was the last discussion on this. At the time I found it broke some mp4 files. - dale On Sat, Sep 26, 2020 at 4:37 AM Tom Needham <06needh...@gmail.com> wrote: > Hello > > I have spent some time researching the possibility of addi

[FFmpeg-cvslog] avformat/mov: See if mfra makes up the difference for an incomplete sidx.

2020-08-28 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu Aug 13 15:02:02 2020 -0700| [2ff3c466eca66bb8eb32bb41a4ce70fe285e3ea0] | committer: Derek Buitenhuis avformat/mov: See if mfra makes up the difference for an incomplete sidx. A few popular sites have started generating MP4 files which have a sidx

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-27 Thread Dale Curtis
Bump to get this applied. Thanks! - dale On Wed, Aug 19, 2020 at 6:13 AM Michael Niedermayer wrote: > On Tue, Aug 18, 2020 at 02:04:04PM +0100, Derek Buitenhuis wrote: > > On 18/08/2020 04:57, Dale Curtis wrote: > > > Can't be an else statement since the prior clau

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > Patch lacks the context for stream_size here - will it always be > correct? Only asking since the check for the coede below this will > have changed from avio_size(pb) to stream_size. > stream_size == avio_si

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
Bump. Thanks for consideration! - dale On Thu, Aug 13, 2020 at 3:03 PM Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as

[FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-13 Thread Dale Curtis
k the index as complete. Fixes: https://crbug.com/1107130 Signed-off-by: Dale Curtis sidx_fix_v0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-07-07 Thread Dale Curtis
ffmpeg | branch: release/4.2 | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [361416218a2d3b4d83209b4ca5e36419cfd5eeb0] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avformat/mov: Don't allow negative sample sizes.

2020-07-05 Thread Dale Curtis
ffmpeg | branch: release/2.8 | Dale Curtis | Thu May 14 15:31:55 2020 -0700| [832ae51f9b4ce1003c2e817900b0332d1df457f7] | committer: Michael Niedermayer avformat/mov: Don't allow negative sample sizes. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer (cherry picked from c

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-14 Thread Dale Curtis
ffmpeg | branch: release/4.3 | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [8dee726b1a5c82c5e6578a606b299c6fdc74c142] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-12 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu May 14 14:38:07 2020 -0700| [bf446711bc8b7f316771870b8d4dc4dd65f5d94b] | committer: Michael Niedermayer avformat/mov: Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > h

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-11 Thread Dale Curtis
Bump again. Thanks. - dale On Fri, Jun 5, 2020 at 11:48 AM Dale Curtis wrote: > Bump for this one again. Thanks in advance. > > - dale > > On Thu, May 28, 2020 at 12:37 PM Dale Curtis > wrote: > >> Bump now that the saturated math operations have landed. Thanks

[FFmpeg-cvslog] avutil/mathematics: Fix overflow with NaN in av_add_stable()

2020-06-05 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu May 14 14:47:49 2020 -0700| [d9aa1ef2c2dfbadcfe3783cee97e9c59dbfe7fb1] | committer: Michael Niedermayer avutil/mathematics: Fix overflow with NaN in av_add_stable() Signed-off-by: Michael Niedermayer > http://git.videolan.org/gitweb.cgi/ffmpeg.

[FFmpeg-cvslog] avformat: Fix overflow in compute_pkt_fields().

2020-06-05 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu May 14 14:47:49 2020 -0700| [63ce7c71bc1b1b6c141df5daae0f8fed52194b72] | committer: Michael Niedermayer avformat: Fix overflow in compute_pkt_fields(). Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > http://git.videolan.

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-06-05 Thread Dale Curtis
Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> &g

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

2020-06-05 Thread Dale Curtis
Bump for this one again. Thanks in advance. - dale On Thu, May 28, 2020 at 12:37 PM Dale Curtis wrote: > Bump now that the saturated math operations have landed. Thanks! > > - dale > > On Thu, May 14, 2020 at 3:31 PM Dale Curtis > wrote: > >> Fixes one issue in

[FFmpeg-cvslog] avformat/oggparsetheora: Don't update start time when lastpts is AV_NOPTS_VALUE.

2020-05-30 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Fri May 15 12:37:02 2020 -0700| [57564a2cfc9c424d137e8279955ac9e892c8d794] | committer: Michael Niedermayer avformat/oggparsetheora: Don't update start time when lastpts is AV_NOPTS_VALUE. Signed-off-by: Dale Curtis Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

2020-05-29 Thread Dale Curtis
On Thu, May 28, 2020 at 1:33 PM Michael Niedermayer wrote: > I dont really have an oppinion about start_time, its more the change in > timestamps & duratiion on the output side which is whats user vissible > and that looked worse for the testcase > The difference is due to the decode stage apply

[FFmpeg-devel] [PATCH] Don't update start time when lastpts is AV_NOPTS_VALUE.

2020-05-29 Thread Dale Curtis
Signed-off-by: Dale Curtis --- libavformat/oggparsetheora.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) no_start_time_update_v0.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

[FFmpeg-cvslog] Use av_sat_sub64() when updating pts by duration.

2020-05-29 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu May 14 14:33:55 2020 -0700| [fc54db32652bc830fba002da19c2ba9ba4508ca5] | committer: Michael Niedermayer Use av_sat_sub64() when updating pts by duration. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > http://git.videolan.

[FFmpeg-cvslog] avformat/utils: Use av_sat_add64() when updating start_time by skip_samples.

2020-05-29 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu May 14 14:29:15 2020 -0700| [f3068be15b361698429ac205ebc728398b4a3cbb] | committer: Michael Niedermayer avformat/utils: Use av_sat_add64() when updating start_time by skip_samples. Avoids overflow from fuzzed skip_samples values. Signed-off-by

Re: [FFmpeg-devel] [PATCH 1/5] Use av_sat_add64() when updating start_time by skip_samples.

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Avoids overflow from fuzzed skip_samples values. > > Signed-off-by: Dale Curtis > --- > libavformat/utils.c | 4 ++-- > 1 file changed, 2 insertio

Re: [FFmpeg-devel] [PATCH 2/5] [oggparsetheora] Use av_sat_sub64() when updating pts by duration.

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Signed-off-by: Dale Curtis > --- > libavformat/oggparsetheora.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Fixes one issue in the function itself and one in the dependent > function av_add_stable() which wasn't checking for NaN. > > Signed-of

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > > Signed-off-by: Dale Curtis > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion

[FFmpeg-cvslog] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-27 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Fri May 1 10:20:43 2020 -0700| [fda1c74539d7b0680f34ca765c2c0055d8f2bb3e] | committer: Michael Niedermayer Use gcc/clang builtins for av_sat_(add|sub)_64_c if available. Signed-off-by: Dale Curtis Signed-off-by: Michael Niedermayer > h

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

2020-05-27 Thread Dale Curtis
On Wed, May 27, 2020 at 8:29 AM Michael Niedermayer wrote: > what id like to point out here is that the audio stream no > longer starts at the same time as the video > also the duration from adding the durations before is > exact but not afterwards > I'm not sure about the duration issue, I'd as

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-27 Thread Dale Curtis
On Wed, May 27, 2020 at 11:10 AM Michael Niedermayer wrote: > so the builtin does better and both locally do better than clang on the web > tool > Ah, sorry I forgot godbolt is compiling without any options, if you type -O9 in the compiler options fields you get: clang: https://godbolt.org/z/CAM

[FFmpeg-cvslog] lavf/mp3dec: don't adjust start time; packets are not adjusted.

2020-05-27 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Thu Apr 23 16:18:18 2020 -0700| [460132c9980f8a1f501a1f69477bca49e1641233] | committer: Anton Khirnov lavf/mp3dec: don't adjust start time; packets are not adjusted. 7546ac2fee4 made it so that the start_time for mp3 files is adjusted for skip_sa

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

2020-05-26 Thread Dale Curtis
On Wed, May 20, 2020 at 5:22 AM Anton Khirnov wrote: > > Looks reasonable, will push. > Thanks! I don't see this in the commit log. Did it end up getting pushed? - dale ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-26 Thread Dale Curtis
On Fri, May 22, 2020 at 1:34 PM Michael Niedermayer wrote: > > does this produce faster / better code ? > that is do compilers actually fail to optimize this from plain > clean C code ? > Here's the difference: clang trunk: https://godbolt.org/z/6SHmEo gcc trunk: https://godbolt.org/z/iKb9jZ I

Re: [FFmpeg-devel] [PATCH] [libavformat] Avoid integer overflow on start_time with skip_samples.

2020-05-26 Thread Dale Curtis
This patch can be abandoned in favor of the other one which uses av_sat_add64(). - dale On Thu, Apr 30, 2020 at 3:20 PM Dale Curtis wrote: > I've sent a follow up patch set implementing saturating operations if > that's something folks are interested in. > > - dale >

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-21 Thread Dale Curtis
On Thu, May 21, 2020 at 12:37 AM Michael Niedermayer wrote: > gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > used with ccache on a x86-64 > Huh, I guess there's no early abort for conditionals in a preprocessor statement with __has_builtin for some reason. I've added a AV_HAS_BUILTIN macro to workaro

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-20 Thread Dale Curtis
On Wed, May 20, 2020 at 1:17 AM Michael Niedermayer wrote: > > In file included from ./libavutil/avutil.h:296:0, > from ./libavutil/log.h:25, > from ./libavutil/thread.h:34, > from libavdevice/alldevices.c:22: > ./libavutil/common.h: In function

[FFmpeg-cvslog] avformat/mov: Free temp buffer upon negative sample_size error.

2020-05-20 Thread Dale Curtis
ffmpeg | branch: release/4.2 | Dale Curtis | Mon May 18 15:35:35 2020 -0700| [7c01f2770131f3e80d1e365f334c26b908178ad4] | committer: Michael Niedermayer avformat/mov: Free temp buffer upon negative sample_size error. 2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition to

[FFmpeg-cvslog] avformat/mov: Free temp buffer upon negative sample_size error.

2020-05-20 Thread Dale Curtis
ffmpeg | branch: master | Dale Curtis | Mon May 18 15:35:35 2020 -0700| [cd0771c38c06ef397466123c6c85521835f98bfd] | committer: Michael Niedermayer avformat/mov: Free temp buffer upon negative sample_size error. 2d8d554f15a7a27cfeca81467cc9341a86f784e2 added a new error condition to

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-18 Thread Dale Curtis
On Mon, May 18, 2020 at 3:24 PM Dale Curtis wrote: > On Mon, May 18, 2020 at 2:22 PM Michael Niedermayer > wrote: > >> >> > 38cfdcfc9d4fa1c1239dc01a766e369b20a0232a sat_math_builtin_v5.patch >> > > Latest upload is sat_math_builtin_v6.patch -- is that not

  1   2   3   4   5   >