> Hi,
>
> Could you review this fix? Under some special conditions, non-English
> characters were printed upside down.
>
> At printing with raster image, the image was generated from bottom to top.
> So, each characters should also be drawn as vertical mirrored. However,
> freetype doesn't sup
On Thu, 19 Nov 2020 18:40:55 GMT, Phil Race wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Checking horizontal mirror case
>
> test/jdk/java/awt/print/PrinterJob/PrintTranslateTest.java line 27:
>
>> 25: * @t
On Tue, 1 Dec 2020 08:20:20 GMT, Toshio Nakamura wrote:
>> Hi,
>>
>> Could you review this fix? Under some special conditions, non-English
>> characters were printed upside down.
>>
>> At printing with raster image, the image was generated from bottom to top.
>> So, each characters should als
On Tue, 1 Dec 2020 17:27:58 GMT, Phil Race wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Checking horizontal mirror case
>
> Marked as reviewed by prr (Reviewer).
Approved.
Whilst the fix looks reasonable and
On Fri, 20 Nov 2020 00:10:48 GMT, Sergey Bylokhov wrote:
> The method in which the assertion fails called from the different places,
> sometimes bounds are passed(dx/dy) and the transform only once here:
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/java2d/SunGr
On Wed, 18 Nov 2020 09:11:11 GMT, Sergey Bylokhov wrote:
> The fix for https://bugs.openjdk.java.net/browse/JDK-8137571 where HiDPI
> support on Linux was implemented missed the change in the X11 pipeline, only
> XRender pipeline was updated. The same logic should be implemented in
> X11Surfac
On Tue, 1 Dec 2020 17:34:43 GMT, Phil Race wrote:
>> Marked as reviewed by prr (Reviewer).
>
> Approved.
> Whilst the fix looks reasonable and important for on-screen, I am surprised
> it was an issue when printing.
> At *printer resolution* it is really surprising that there are any bitmaps
>
On Wed, 18 Nov 2020 09:11:11 GMT, Sergey Bylokhov wrote:
> The fix for https://bugs.openjdk.java.net/browse/JDK-8137571 where HiDPI
> support on Linux was implemented missed the change in the X11 pipeline, only
> XRender pipeline was updated. The same logic should be implemented in
> X11Surfac
On Tue, 1 Dec 2020 19:38:37 GMT, Sergey Bylokhov wrote:
>> Approved.
>> Whilst the fix looks reasonable and important for on-screen, I am surprised
>> it was an issue when printing.
>> At *printer resolution* it is really surprising that there are any bitmaps
>> for the glyphs.
>> We should be
