[OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 - Commit messages: - 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image Changes: https://git.openjdk.java.net/jdk/pull/562/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
On Fri, 9 Oct 2020 17:20:38 GMT, Dalibor Topic wrote: >> The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 > > Hi, please send the details whose OCA you are covered under to > [email protected] so that I can verify your > account. Thanks! @robilad Hi Dalibor! Have

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Andrii Rodionov
On Fri, 9 Oct 2020 18:31:50 GMT, Andrii Rodionov wrote: >> Hi, please send the details whose OCA you are covered under to >> [email protected] so that I can verify your >> account. Thanks! > > @robilad Hi Dalibor! Have sent you email with details. > Thanks! @bobvandette Could you pleas

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Dalibor Topic
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 Hi, please send the details whose OCA you are covered under to [email protected] so that I can verify your account. Thanks! - PR: https://git.

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Phil Race
On Wed, 14 Oct 2020 17:41:57 GMT, Andrii Rodionov wrote: >> @robilad Hi Dalibor! Have sent you email with details. >> Thanks! > > @bobvandette Could you please join to the review? It is generally not expected for such a proposed change to pop up out of nowhere from someone who is a new contrib

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Thu, 8 Oct 2020 12:57:29 GMT, Andrii Rodionov wrote: > The following PR fixes https://bugs.openjdk.java.net/browse/JDK-8254024 src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c line 820: > 818: > 819: JNIEXPORT void JNICALL > 820: Java_sun_xawt_motif_XsessionWMcommand(JNIEnv *env, jo

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Wed, 14 Oct 2020 17:56:34 GMT, Phil Race wrote: > It is generally not expected for such a proposed change to pop up out of > nowhere from someone who is a new contributor > without prior discussion and so forth. > I have no idea where this change is coming from, why we would want it, and > h

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Phil Race
On Wed, 14 Oct 2020 18:26:35 GMT, Bob Vandette wrote: >> It is generally not expected for such a proposed change to pop up out of >> nowhere from someone who is a new contributor >> without prior discussion and so forth. >> I have no idea where this change is coming from, why we would want it,

Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

2020-10-14 Thread Bob Vandette
On Wed, 14 Oct 2020 18:31:28 GMT, Phil Race wrote: > Sorry I am not familiar with that work. Please provide more info. Here's the JEP for the work done in JDK8 to allow libraries to be built and used statically. https://bugs.openjdk.java.net/browse/JDK-8046168 Here's the changes done to allow

[OpenJDK 2D-Dev] RFR: 8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit

2020-10-14 Thread Sergey Bylokhov
The XrSwToPMBlit is a blit which is used as a direct(unscaled) blit of the image in the memory to the pixmap. It tries to optimize the SrcOver composite in case of an opaque source image and use Src instead: if (CompositeType.SrcOverNoEa.equals(comp) && (src.getTransparency() == Transpa

[OpenJDK 2D-Dev] RFR: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module

2020-10-14 Thread Sergey Bylokhov
The java.desktop module has a few implementations of the finalize() method which do nothing. We can remove such methods if the class is not public API, and could mark these methods in the public classes as "forRemoval = true" - Commit messages: - @SuppressWarnings("removal") - Ini