Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-24 Thread Kumar Abhishek
Hi Phil, This bug was originally only for JPEG plugin though I have verified the changes for other plugins as well. Do you want me to divide the change for different plugins and create separate bugs or the current approach is fine? Please find the updated webrev with superfluous comme

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-24 Thread Jayathirth D V
Hi Yasumasa, I tried after changing the locale to Japanese but I don’t see the issue. Also tried to reproduce the issue by enabling/disabling setting "Beta:Use Unicode UTF-8 for worldwide language support" in my locale setting. @Others : Can somebody else try to reproduce this issue? Thanks, J

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-24 Thread Yasumasa Suenaga
Hi Jay, I share you hs_err log of this issue. `chcp` on my console shows "932" (MS932). It is Japanese locale. I can share you if you want to know. Thanks, Yasumasa On 2020/07/24 20:59, Jayathirth D V wrote: Hi Yasumasa, I tried after changing the locale to Japanese but I don’t see the is

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-24 Thread Philip Race
This is fine. Approved. -phil. On 7/24/20, 3:08 AM, Kumar Abhishek wrote: Hi Phil, This bug was originally only for JPEG plugin though I have verified the changes for other plugins as well. Do you want me to divide the change for different plugins and create separate bugs or the current a

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-24 Thread Alexey Ivanov
Hi Abhishek, *JPEGImageWriter.java* 240 public IIOMetadata convertStreamMetadata(IIOMetadata inData, 255 public IIOMetadata 256 convertImageMetadata(IIOMetadata inData, 1751 public synchronized void dispose() { These methods are missed: no @Override annotation. In the