Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

2020-07-23 Thread Jayathirth D v
Hi Prasanta, I again tested updated webrev in Windows and Linux and it works as expected. webrev.1 looks good to me. Thanks, Jay > On 20-Jul-2020, at 8:45 PM, Prasanta Sadhukhan > wrote: > > Actually, I was a bit wrong in construing that the button should just be > disabled for ServiceUI.pr

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-23 Thread Jayathirth D v
Hi, I tried reproducing the issue in my Windows 10 machine with UTF-8 encoding and test file mentioned in the bug, I don’t see any crash. Am I missing something? Also I think this should be in awt-dev so adding the mailing list. Thanks, Jay > On 20-Jul-2020, at 12:59 PM, Yasumasa Suenaga wrot

Re: [OpenJDK 2D-Dev] PING: RFR: 8249215: JFrame::setVisible crashed with -Dfile.encoding=UTF-8

2020-07-23 Thread Yasumasa Suenaga
Hi Jay, On 2020/07/23 19:09, Jayathirth D v wrote: Hi, I tried reproducing the issue in my Windows 10 machine with UTF-8 encoding and test file mentioned in the bug, I don’t see any crash. Am I missing something? OS locale may be affecting. My laptop has been set Japanese (CP932 / Windows-3

[OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-23 Thread Kumar Abhishek
Hello, Please review this small change for JDK-16 . This is a clean up task to verify and add missing annotations in ImageIO plugins Verified and added annotations for all the Writer and Reader implementation under src/java.desktop/share/classes/com/sun/imageio/plugins/ Bug/webrev : htt

Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

2020-07-23 Thread Philip Race
On 7/23/20, 5:20 AM, Kumar Abhishek wrote: Hello, Please review this small change for JDK-16 . This is a clean up task to verify and add missing annotations in ImageIO plugins They are missing in part because most of these classes were added in 1.4 and annotations were introduced in 1.5.

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

2020-07-23 Thread Philip Race
So the bug is that directly calling ServiceUI.printDialog() was enabling a non-functional properties button on just the Windows platform and you are adding an extra condition to prevent that without harming the goal of JDK-4673406 to have it enabled and functional when invoked by java.awt.Printe