Hi,
I guess it would make sense to offer logging methods that take a supplier as
input. That way we could pass String concatenations as Lambdas that only
evaluate when actually calling the logging.
Unfortunately, PlatformLogger does not (yet?) offer public logging methods
taking suppliers. Tho
>BTW I suppose you believe you have found all the cases in various packages
>and platform folders and converted them ?
>Or were there some cases you intentionally left alone ?
Hi Phil, I kept a few FontUtilities.getLogger - calls because they are a
bit special or they use later when loggin
Hi Matthias,
this looks good to me. I agree that one could look at refactoring regarding
Suppliers and maybe also improving the isLogging checks in a subsequent change.
I found a few lines where spaces around the plus signs are missing. Maybe you
can correct this formatting before pushing:
CFo
That would I think also take care of some "technical debt" which
is on the to-do list since I want to remove all unnecessary usage
of java.base internals.
-phil.
On 7/14/20, 8:39 AM, Daniel Fuchs wrote:
Hi Christoph,
Sorry - I'm not on 2d-dev - so please include me in cc: if you
reply to this
Hi Christoph,
Sorry - I'm not on 2d-dev - so please include me in cc: if you
reply to this mail. Also my apologies if I don't have the full
context of this discussion.
> Unfortunately, PlatformLogger does not (yet?) offer public logging
> methods taking suppliers.
I would suggest using System.L
On 7/14/20, 8:43 AM, Langer, Christoph wrote:
This should probably also be pushed to the client repo.
That is not just "probably", it is a definite yes.
-phil.
Hi Daniel,
thanks for this good suggestion. Matthias change won't go that far now anyway
but if font logging was to be further refactored, this should definitely be
taken into account.
Best regards
Christoph
> -Original Message-
> From: Daniel Fuchs
> Sent: Dienstag, 14. Juli 2020 17:
