[OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

2020-02-11 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 webrev: http://cr.openjdk.java.net/~prr/8238942/ As discussed in the bug, we are missing padding in the code that takes an LCD glyph from freetype and caches it in the 2D glyph cache. This padding is used in subpixel positioning with fraction

Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

2020-02-11 Thread Sergey Bylokhov
Hi, Phil. Could you please clarify these lines, from the patch it is unclear what they should do. "Why" + glyphInfo->topLeftX -= 1; + // WHY NOT ADD ? + glyphInfo->width += 1; On 2/11/20 8:15 pm, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 webrev: http://cr.openjdk

Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

2020-02-11 Thread Jayathirth D v
Change looks good to me. And we have good amount of time to notice any pixel accuracy issues. Thanks, Jay > On 12-Feb-2020, at 9:45 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 > webrev: http://cr.openjdk.java.net/~prr/8238942/ > > As discussed in the bug, w