[OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

2019-10-07 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8221741 Change: https://cr.openjdk.java.net/~itakiguchi/8221741/webrev.04/ JTreg testcase and results are including JDK-8221741 [1]. [1] https://bugs.openjdk.java.net/browse/JDK-8221741 Thanks, Ichiroh Takiguch

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java does not render Myanmar script correctly

2019-10-07 Thread Alexey Ivanov
Hi Phil, Thank you for your review. I have updated the summary of the bug to be more specific: “Java does not render Myanmar script correctly”. This fix addresses only the rendering of Myanmar characters. Adding Myanmar script and related languages to the list of supported locales is prematu

Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

2019-10-07 Thread Langer, Christoph
Hi Ichiroh, this is great, thanks for doing this. We regularly see this and just stumbled over it the other day where the fontconfig of our test user was corrupted somehow. As for the test, I would reduce the amount of reflection a little bit. It should not be necessary to access SunFontManage

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java does not render Myanmar script correctly

2019-10-07 Thread Phil Race
sounds good. -phil. On 10/7/19 5:07 AM, Alexey Ivanov wrote: Hi Phil, Thank you for your review. I have updated the summary of the bug to be more specific: “Java does not render Myanmar script correctly”. This fix addresses only the rendering of Myanmar characters. Adding Myanmar script an

Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

2019-10-07 Thread Ichiroh Takiguchi
Hello Christoph. I appreciate your suggestion. JTreg testcase could throw ClassCastException instead of InvocationTargetException. JTreg results were in JDK-8221741 Bug:https://bugs.openjdk.java.net/browse/JDK-8221741 Change: https://cr.openjdk.java.net/~itakiguchi/8221741/webrev.05/ Coul